Swing validation

[Dale Herring]

I finished this program and when I tested the first code group at the bottom validating the combobox entries it worked fine. Now this program freezes when I touch the radio buttons or comboboxes. The last block of code is supposed to immediatley revert back to the first selection in the array when the same position is picked in another combobox. I have looked it over and have no idea why it just freezes. The problem has to be in the lat bit performing the validation because it was fine before.

//Baseball lineup GUI
import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
import javax.swing.border.*;
import javax.swing.BorderFactory.*;

public class BaseballLine extends JFrame implements ActionListener
{
    JComboBox<String> one, two, three, four, five, six, seven, eight, nine;
    String[]pos = {"Choose a position", "Pitcher", "Catcher", "First Base", "Second Base", "Third Base", "Short stop", "Left field", "Center Field", "Right Field"};
    JLabel tName;
    JTextField tNameBox, pNameOne, pNameTwo, pNameThree, pNameFour, pNameFive, pNameSix, pNameSeven, pNameEight, pNameNine;
    JRadioButton HB, VB;
    ButtonGroup bg;
    JButton ok, exit;
    Border teamInfo,loweredbevel;

    String teamName, pOne, pTwo, pThree, pFour, pFive, pSix, pSeven, pEight, pNine;//data for textfields
    String lOne, lTwo, lThree, lFour, lFive, lSix, lSeven, lEight, lNine;//data for combobox

    Object source = new Object();

    BaseballLine()
    {
		//new frame
		setTitle("Baseball Lineup");
        setLayout(new BorderLayout());

		setSize(450, 500);
		setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

        //center frame
		Toolkit tk = Toolkit.getDefaultToolkit();
		Dimension d = tk.getScreenSize();
		int width = 450;
		int height = 500;
		setLocation((d.width - width)/2, (d.height - height)/2);

		//textboxes, labels, buttons
		one = new JComboBox<String>(pos);
		two = new JComboBox<String>(pos);
		three = new JComboBox<String>(pos);
		four = new JComboBox<String>(pos);
		five = new JComboBox<String>(pos);
		six = new JComboBox<String>(pos);
		seven = new JComboBox<String>(pos);
		eight = new JComboBox<String>(pos);
		nine = new JComboBox<String>(pos);

		tName = new JLabel("Team name: ");

		tNameBox = new JTextField(10);
		pNameOne = new JTextField(10);
		pNameTwo = new JTextField(10);
		pNameThree = new JTextField(10);
		pNameFour = new JTextField(10);
		pNameFive = new JTextField(10);
		pNameSix = new JTextField(10);
		pNameSeven = new JTextField(10);
		pNameEight = new JTextField(10);
		pNameNine = new JTextField(10);

		HB = new JRadioButton("Home");
		VB = new JRadioButton("Visitor");

		ok = new JButton("OK");
		exit = new JButton("Exit");

		//add listeners
		one.addActionListener(this);
		two.addActionListener(this);
		three.addActionListener(this);
		four.addActionListener(this);
		five.addActionListener(this);
		six.addActionListener(this);
		seven.addActionListener(this);
		eight.addActionListener(this);
		nine.addActionListener(this);

		HB.addActionListener(this);
		VB.addActionListener(this);
		ok.addActionListener(this);
		exit.addActionListener(this);

		//create north panel
		JPanel pNorth = new JPanel();
		pNorth.setLayout(new FlowLayout());
		loweredbevel = BorderFactory.createLoweredBevelBorder();
		teamInfo = BorderFactory.createTitledBorder(loweredbevel, "Team Information");
		pNorth.setBorder(teamInfo);

        //add components to north panel
		pNorth.add(tName);
		pNorth.add(tNameBox);
		pNorth.add(HB);
		pNorth.add(VB);
		bg = new ButtonGroup();
		bg.add(HB);
		bg.add(VB);

		//create main panel
		JPanel pCenter = new JPanel();
		pCenter.setLayout(new GridBagLayout());
		GridBagConstraints c = new GridBagConstraints();
		c.fill = GridBagConstraints.HORIZONTAL;
		c.insets = new Insets(7,5,5,7);

		//add components to center panel

		c.gridx = 0;
		c.gridy = 0;
		pCenter.add(pNameOne, c);

        c.gridx = 1;
		c.gridy = 0;
		pCenter.add(one, c);

		c.gridx = 0;
		c.gridy = 1;
		pCenter.add(pNameTwo, c);

		c.gridx = 1;
		c.gridy = 1;
		pCenter.add(two, c);

		c.gridx = 0;
		c.gridy = 2;
		pCenter.add(pNameThree, c);

		c.gridx = 1;
		c.gridy = 2;
		pCenter.add(three, c);

		c.gridx = 0;
		c.gridy = 3;
		pCenter.add(pNameFour, c);

		c.gridx = 1;
		c.gridy = 3;
		pCenter.add(four, c);

	    c.gridx = 0;
		c.gridy = 4;
		pCenter.add(pNameFive, c);

		c.gridx = 1;
		c.gridy = 4;
		pCenter.add(five, c);

		c.gridx = 0;
		c.gridy = 5;
		pCenter.add(pNameSix, c);

		c.gridx = 1;
		c.gridy = 5;
		pCenter.add(six, c);

		c.gridx = 0;
		c.gridy = 6;
		pCenter.add(pNameSeven, c);

		c.gridx = 1;
		c.gridy = 6;
		pCenter.add(seven, c);

		c.gridx = 0;
		c.gridy = 7;
		pCenter.add(pNameEight, c);

		c.gridx = 1;
		c.gridy = 7;
		pCenter.add(eight, c);

		c.gridx = 0;
		c.gridy = 8;
		pCenter.add(pNameNine, c);

		c.gridx = 1;
		c.gridy = 8;
		pCenter.add(nine, c);

		c.gridx = 2;
		c.gridy = 9;
		pCenter.add(ok, c);

		c.gridx = 3;
		c.gridy = 9;
		pCenter.add(exit, c);

		this.add("North",pNorth);
		this.add(pCenter);


	}//end construct

		//action performed
		public void actionPerformed(ActionEvent ae) throws NullPointerException
		{
           source = ae.getSource();

			if(source == exit)
			{
				System.exit(0);
			}


			if(source == ok)
			{
				try
				{
				teamName = tNameBox.getText();
				if(teamName.length() == 0)
				{
					throw new NullPointerException();
				}
					System.out.print(teamName);

                if(HB.isSelected())
                {
					System.out.println("(" + HB.getActionCommand() + " " + "team" + ")");
				}
				else if(VB.isSelected())
				{
					System.out.println("(" + VB.getActionCommand() + " " + "team" + ")");
				}

              System.out.println();

			    pOne = pNameOne.getText();
				if(pOne.length() == 0)
				{
					throw new NullPointerException();
				}
					System.out.print(pOne);

			System.out.print(",");

			lOne = (String) one.getSelectedItem();
			System.out.println(" " + lOne);

			pTwo = pNameTwo.getText();
			if(pTwo.length() == 0)
			{
				throw new NullPointerException();
			}
				System.out.print(pTwo);

			System.out.print(",");

			lTwo = (String) two.getSelectedItem();
			System.out.println(" " + lTwo);

			pThree = pNameThree.getText();
			if(pTwo.length() == 0)
			{
				throw new NullPointerException();
			}
				System.out.print(pThree);

			System.out.print(",");

			lThree = (String) three.getSelectedItem();
			System.out.println(" " + lThree);

			pFour = pNameFour.getText();
			if(pFour.length() == 0)
			{
				throw new NullPointerException();
			}
				System.out.print(pFour);

			System.out.print(",");

			lFour = (String) four.getSelectedItem();
			System.out.println(" " + lFour);

			pFive = pNameFive.getText();
			if(pFive.length() == 0)
			{
				throw new NullPointerException();
			}
				System.out.print(pFive);

			System.out.print(",");

			lFive = (String) five.getSelectedItem();
			System.out.println(" " + lFive);

			pSix = pNameSix.getText();
			if(pSix.length() == 0)
			{
				throw new NullPointerException();
			}
				System.out.print(pSix );

			System.out.print(",");

			lSix = (String) six.getSelectedItem();
			System.out.println(" " + lSix);

			pSeven = pNameSeven.getText();
			if(pSeven.length() == 0)
			{
				throw new NullPointerException();
			}
				System.out.print(pSeven);

			System.out.print(",");

			lSeven = (String) seven.getSelectedItem();
			System.out.println(" " + lSeven);

			pEight = pNameEight.getText();
			if(pEight.length() == 0)
			{
				throw new NullPointerException();
			}
				System.out.print(pEight);

			System.out.print(",");

			lEight = (String) eight.getSelectedItem();
			System.out.println(" " + lEight);

			pNine = pNameNine.getText();
			if(pNine.length() == 0)
			{
				throw new NullPointerException();
			}
				System.out.print(pNine);

			System.out.print(",");

			lNine = (String) nine.getSelectedItem();
			System.out.println(" " + lNine);

		}//end try

			catch(NullPointerException d)
			{
				JOptionPane.showMessageDialog(null, "All text fields must be entered", "alert", JOptionPane.ERROR_MESSAGE);
			}

             }// end if

			 if(one.getSelectedItem() == two.getSelectedItem())
			 {
				 one.setSelectedIndex(0);
			 }
			 if(one.getSelectedItem() == three.getSelectedItem())
			 {
				 one.setSelectedIndex(0);
			 }
			 if(one.getSelectedItem() == four.getSelectedItem())
			 {
				 one.setSelectedIndex(0);
			 }
			 if(one.getSelectedItem() == five.getSelectedItem())
			 {
				 one.setSelectedIndex(0);
			 }
			 if(one.getSelectedItem() == six.getSelectedItem())
			 {
				 one.setSelectedIndex(0);
			 }
			 if(one.getSelectedItem() == seven.getSelectedItem())
			 {
				 one.setSelectedIndex(0);
			 }
			 if(one.getSelectedItem() == eight.getSelectedItem())
			 {
				 one.setSelectedIndex(0);
			 }
			 if(one.getSelectedItem() == nine.getSelectedItem())
			 {
				 one.setSelectedIndex(0);
			 }

			 if(two.getSelectedItem() == one.getSelectedItem())
			 {
				 two.setSelectedIndex(0);
			 }
			 if(two.getSelectedItem() == three.getSelectedItem())
			 {
				 two.setSelectedIndex(0);
			 }
			 if(two.getSelectedItem() == four.getSelectedItem())
			 {
				 two.setSelectedIndex(0);
			 }
			 if(two.getSelectedItem() == five.getSelectedItem())
			 {
				 two.setSelectedIndex(0);
			 }
			 if(two.getSelectedItem() == six.getSelectedItem())
			 {
				 two.setSelectedIndex(0);
			 }
			 if(two.getSelectedItem() == seven.getSelectedItem())
			 {
				 two.setSelectedIndex(0);
			 }
			 if(two.getSelectedItem() == eight.getSelectedItem())
			 {
				 two.setSelectedIndex(0);
			 }
			 if(two.getSelectedItem() == nine.getSelectedItem())
			 {
				 two.setSelectedIndex(0);
			 }

			 if(three.getSelectedItem() == one.getSelectedItem())
			 {
				 three.setSelectedIndex(0);
			 }
			 if(three.getSelectedItem() == two.getSelectedItem())
			 {
				 three.setSelectedIndex(0);
			 }
			 if(three.getSelectedItem() == four.getSelectedItem())
			 {
				 three.setSelectedIndex(0);
			 }
			 if(three.getSelectedItem() == five.getSelectedItem())
			 {
				 three.setSelectedIndex(0);
			 }
			 if(three.getSelectedItem() == six.getSelectedItem())
			 {
				 three.setSelectedIndex(0);
			 }
			 if(three.getSelectedItem() == seven.getSelectedItem())
			 {
				 three.setSelectedIndex(0);
			 }
			 if(three.getSelectedItem() == eight.getSelectedItem())
			 {
				 three.setSelectedIndex(0);
			 }
			 if(three.getSelectedItem() == nine.getSelectedItem())
			 {
				 three.setSelectedIndex(0);
			 }

			 if(four.getSelectedItem() == one.getSelectedItem())
			 {
				 four.setSelectedIndex(0);
			 }
			 if(four.getSelectedItem() == two.getSelectedItem())
			 {
				 four.setSelectedIndex(0);
			 }
			 if(four.getSelectedItem() == three.getSelectedItem())
			 {
				 four.setSelectedIndex(0);
			 }
			 if(four.getSelectedItem() == five.getSelectedItem())
			 {
				 four.setSelectedIndex(0);
			 }
			 if(four.getSelectedItem() == six.getSelectedItem())
			 {
				 four.setSelectedIndex(0);
			 }
			 if(four.getSelectedItem() == seven.getSelectedItem())
			 {
				 four.setSelectedIndex(0);
			 }
			 if(four.getSelectedItem() == eight.getSelectedItem())
			 {
				 four.setSelectedIndex(0);
			 }
			 if(four.getSelectedItem() == nine.getSelectedItem())
			 {
				 four.setSelectedIndex(0);
			 }

			 if(five.getSelectedItem() == one.getSelectedItem())
			 {
				 five.setSelectedIndex(0);
			 }
			 if(five.getSelectedItem() == two.getSelectedItem())
			 {
				 five.setSelectedIndex(0);
			 }
			 if(five.getSelectedItem() == three.getSelectedItem())
			 {
				 five.setSelectedIndex(0);
			 }
			 if(five.getSelectedItem() == four.getSelectedItem())
			 {
				 five.setSelectedIndex(0);
			 }
			 if(five.getSelectedItem() == six.getSelectedItem())
			 {
				 five.setSelectedIndex(0);
			 }
			 if(five.getSelectedItem() == seven.getSelectedItem())
			 {
				 five.setSelectedIndex(0);
			 }
			 if(five.getSelectedItem() == eight.getSelectedItem())
			 {
				 five.setSelectedIndex(0);
			 }
			 if(five.getSelectedItem() == nine.getSelectedItem())
			 {
				 five.setSelectedIndex(0);
			 }

			 if(six.getSelectedItem() == one.getSelectedItem())
			 {
				 six.setSelectedIndex(0);
			 }
			 if(six.getSelectedItem() == two.getSelectedItem())
			 {
				 six.setSelectedIndex(0);
			 }
			 if(six.getSelectedItem() == three.getSelectedItem())
			 {
				 six.setSelectedIndex(0);
			 }
			 if(six.getSelectedItem() == four.getSelectedItem())
			 {
				 six.setSelectedIndex(0);
			 }
			 if(six.getSelectedItem() == five.getSelectedItem())
			 {
				 six.setSelectedIndex(0);
			 }
			 if(six.getSelectedItem() == seven.getSelectedItem())
			 {
				 six.setSelectedIndex(0);
			 }
			 if(six.getSelectedItem() == eight.getSelectedItem())
			 {
				 six.setSelectedIndex(0);
			 }
			 if(six.getSelectedItem() == nine.getSelectedItem())
			 {
				 six.setSelectedIndex(0);
			 }

			 if(seven.getSelectedItem() == one.getSelectedItem())
			 {
				 seven.setSelectedIndex(0);
			 }
			 if(seven.getSelectedItem() == two.getSelectedItem())
			 {
				 seven.setSelectedIndex(0);
			 }
			 if(seven.getSelectedItem() == three.getSelectedItem())
			 {
				 seven.setSelectedIndex(0);
			 }
			 if(seven.getSelectedItem() == four.getSelectedItem())
			 {
				 seven.setSelectedIndex(0);
			 }
			 if(seven.getSelectedItem() == five.getSelectedItem())
			 {
				 seven.setSelectedIndex(0);
			 }
			 if(seven.getSelectedItem() == six.getSelectedItem())
			 {
				 seven.setSelectedIndex(0);
			 }
			 if(seven.getSelectedItem() == eight.getSelectedItem())
			 {
				 seven.setSelectedIndex(0);
			 }
			 if(seven.getSelectedItem() == nine.getSelectedItem())
			 {
				 seven.setSelectedIndex(0);
			 }

			 if(eight.getSelectedItem() == one.getSelectedItem())
			 {
				 eight.setSelectedIndex(0);
			 }
			 if(eight.getSelectedItem() == two.getSelectedItem())
			 {
				 eight.setSelectedIndex(0);
			 }
			 if(eight.getSelectedItem() == three.getSelectedItem())
			 {
				 eight.setSelectedIndex(0);
			 }
			 if(eight.getSelectedItem() == four.getSelectedItem())
			 {
				 eight.setSelectedIndex(0);
			 }
			 if(eight.getSelectedItem() == five.getSelectedItem())
			 {
				 eight.setSelectedIndex(0);
			 }
			 if(eight.getSelectedItem() == six.getSelectedItem())
			 {
				 eight.setSelectedIndex(0);
			 }
			 if(eight.getSelectedItem() == seven.getSelectedItem())
			 {
				 eight.setSelectedIndex(0);
			 }
			 if(eight.getSelectedItem() == nine.getSelectedItem())
			 {
				 eight.setSelectedIndex(0);
			 }

			 if(nine.getSelectedItem() == one.getSelectedItem())
			 {
				 nine.setSelectedIndex(0);
			 }
			 if(nine.getSelectedItem() == two.getSelectedItem())
			 {
				 nine.setSelectedIndex(0);
			 }
			 if(nine.getSelectedItem() == three.getSelectedItem())
			 {
				 nine.setSelectedIndex(0);
			 }
			 if(nine.getSelectedItem() == four.getSelectedItem())
			 {
				 nine.setSelectedIndex(0);
			 }
			 if(nine.getSelectedItem() == five.getSelectedItem())
			 {
				 nine.setSelectedIndex(0);
			 }
			 if(nine.getSelectedItem() == six.getSelectedItem())
			 {
				 nine.setSelectedIndex(0);
			 }
			 if(nine.getSelectedItem() == seven.getSelectedItem())
			 {
				 nine.setSelectedIndex(0);
			 }
			 if(nine.getSelectedItem() == eight.getSelectedItem())
			 {
				 nine.setSelectedIndex(0);
			 }

	}//end actionperformed


public static void main(String[]args)
{
	BaseballLine bl = new BaseballLine();
	bl.setVisible(true);
}//end main
}//end class

[Paul Clapham]

In your action listener you are changing a combo box, which causes the action listener to be called, which then changes a combo box, which causes the action listener to be called, which then changes... you get the picture I hope.

It's a pity you wrote 500 lines of code before testing anything; try not to do that in future.

[Dale Herring]

MMM okay. Well I've figured out that it only breaks around the fifth box check but not sure why it's affecting the radio buttons and why it works until that point. Also refer to earlier post, I had checked the first block and just like now it did work, it just does not work all teh way through.

[Campbell Ritchie]

I tried your code and it hung on the first radio button click.

Your post sounds like you tying yourself in knots. I suspect you are going to have to delete a lot of that code (> 95%) and see what happens.
I do not like the multiple ifs. You are throwing an inappropriate Exception because none of those Strings is null. You should not be catching unchecked Exceptions. You need to alter your design and to check the contents of the fields when you push any of the buttons.
You should also not make a display class implement action listener. Apply different listeners to the different components. Or implement a Component, maybe a menu item, maybe a button, which checks that the fields contain text and then compiles the team.

Can you add some sort of listener to the combo boxes which removes the selected position from all the other boxes?

[Paul Clapham]

I would suggest you would have a lot less code if you used an array rather than nine variables. And also, don't call setSelectedIndex(0) if index 0 is already selected -- that may be causing the infinite loop.

You should also avoid using == to compare String values, although you are somehow getting away with it here. Use the equals() method instead.

[Campbell Ritchie]

Paul Clapham wrote:. . . avoid using == to compare String values, although you are somehow getting away with it here. . . .

A long time ago when I was working for the MSc, we had one chap on the course who had written a lot of C#, where (I think) == is overloaded on Strings. So he used == throughout and it worked nicely, because all the Strings were literals which were automatically interned, or assigned from those literals. “It works all right until I serialise it, Campbell, but it won't work afterwards.”

Even at that tender age I realised there was a problem because the deserialised Strings were being compared to the original literals with == and that wouldn't work; they were now new objects. Changing every occurrence of == to equals sorted out the problem.