Problem while using prepared statement

[Aashima Upadhyaya]

I have created the following program using prepared statement, but I am not able to go through and fetch its output accordingly.Please help.This is the program

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
import java.sql.*;
public class log extends JFrame implements ActionListener
{
String s1,s2;
JLabel l1=new JLabel("UID");
JLabel l2=new JLabel("PWD");
JButton b3=new JButton("RESET");
JLabel l3=new JLabel();
JTextField t1=new JTextField(10);
JPasswordField t2=new JPasswordField(15);
JButton b1=new JButton("SUBMIT");
JButton b2=new JButton("FORGET PASSWORD");
JPanel p1=new JPanel();
Container c=getContentPane();
Connection con;
PreparedStatement st;
ResultSet rs;
log()
{
c.setLayout(new FlowLayout());
p1.setLayout(new GridLayout(4,2));
p1.add(l1);p1.add(t1);p1.add(l2);
p1.add(t2);p1.add(b1);p1.add(b2);
p1.add(b3);p1.add(l3);
c.add(p1);
b1.addActionListener(this);
//b3.addActionListener(this);
s1=t1.getText();
s2=t2.getText();
try
{
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
con=DriverManager.getConnection("jdbc:odbc:ds2");
}
catch(Exception e)
{
System.out.println("first try "+e);
}
}
public void actionPerformed(ActionEvent e2)
{
String s=e2.getActionCommand();
if(s.equals("SUBMIT"))
{
try
{
st=con.prepareStatement("select * from login where u_id=? and pwd=?");
st.setString(1,s1);/* Here the value doesnt comes up , while when I entered value manually it worked perfectly. */
st.setString(2,s2);/* Here the value doesnt comes up , while when I entered value manually it worked perfectly. */

rs=st.executeQuery();
System.out.println("ps executed");
if(rs.next())
{
JOptionPane.showMessageDialog(this,"valid entry");
}
else{
JOptionPane.showMessageDialog(this,"invalid entry");
}
}
catch(Exception e1)
{
System.out.println("second try"+e1);
}
}
/*if(s.equals("RESET"));
{
t1.setText(" ");
t2.setText(" ");
}*/
}
public static void main(String aa[])
{
log o1=new log();
o1.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
o1.setSize(400,400);
o1.show();
}
}

Thanks in advance.

Aashima Upadhyay

[Jeanne Boyarsky]

Aashima,
Welcome to CodeRanch!

Just to make sure I'm understanding the problem correctly:

Works as expected:

st=con.prepareStatement("select * from login where u_id='myId' and pwd='myPassword'");  

Doesn't work as expected:

st=con.prepareStatement("select * from login where u_id=? and pwd=?");
st.setString(1,"myId");
st.setString(2, "myPassword");  

Can you try it with the values hardcoded in both as I have it (with the correct values of course.) I'm wondering if the variable somehow doesn't have what you expect. The JDBC looks fine.

[Aashima Upadhyaya]

Thanks a lot but it still doesn't works. The code doesnt gives any error at any step but the value of s1 and s2 doesnt reaches to the query

 st=con.prepareStatement("select * from login where u_id=? and pwd=?");  
 st.setString(1,s1);/* Here the value doesnt comes up , while when I entered value manually it worked perfectly. */  
 st.setString(2,s2);/* Here the value doesnt comes up , while when I entered value manually it worked perfectly. */  

I tried inserting the value manually in place of s1 and s2 it works perfectly well. Please help me out...

love,

aashima

[Ninad Kulkarni]

@Aashima

Instead of constructor use following assignment operations in action performed method at line number 45 & 46

s1=t1.getText();  
s2=t2.getText(); 

Let us know whether values are comming or not after above change

[Aashima Upadhyaya]

Thanks a lot Ninad Sir,it worked perfectly well for timely reply... you are a savior.