Three of Four fields must have a value.

[LaTeef Lusk]

I have a script that is not working. I have four form fields, and I want to script to check that at least 3 of the 4 have a value. When I submit the form it seems to bypass the validation. Please help. My script is below: Any help would be appreciated.

   
<script language="javascript">    
function validateFruitForm()    
{    

 //START Apple SCENARIO
if (document.getElementById('APPLE').value != "" && (document.getElementById('ORANGE').value == "" && document.getElementById('BANANA').value == "" && document.getElementById('PEAR').value == ""))    
{    
alert("You entered a Apple. You must also enter two of the following: Banana, Pear, or Orange.");    
return false; }  

if (document.getElementById('APPLE').value != "" && document.getElementById('ORANGE').value != "" && (document.getElementById('BANANA').value == "" && document.getElementById('PEAR').value == ""))    
{    
alert("You entered a Apple and Orange. You must also enter Banana or Pear.");    
return false; } 

if (document.getElementById('APPLE').value != "" && document.getElementById('BANANA').value != "" && (document.getElementById('ORANGE').value == "" && document.getElementById('PEAR').value == ""))    
{    
alert("You entered a Apple and Banana. You must also enter Orange or Pear.");    
return false; } 

if (document.getElementById('APPLE').value != "" && document.getElementById('PEAR').value != "" && (document.getElementById('BANANA').value == "" && document.getElementById('ORANGE').value == ""))    
{    
alert("You entered a Apple and Pear. You must also enter Banana or Orange.");    
return false; } 
//START Banana SCENARIO
if (document.getElementById('BANANA').value != "" && (document.getElementById('ORANGE').value == "" && document.getElementById('APPLE').value == "" && document.getElementById('PEAR').value == ""))    
{    
alert("You entered a Banana. You must also enter two of the following: Apple, Pear, or Orange.");    
return false; }  

if (document.getElementById('BANANA').value != "" && document.getElementById('ORANGE').value != "" && (document.getElementById('APPLE').value == "" && document.getElementById('PEAR').value == ""))    
{    
alert("You entered a Banana and Orange. You must also enter Apple or Pear.");    
return false; } 

if (document.getElementById('BANANA').value != "" && document.getElementById('PEAR').value != "" && (document.getElementById('APPLE').value == "" && document.getElementById('ORANGE').value == ""))    
{    
alert("You entered a Banana and Pear. You must also enter Apple or Orange.");    
return false; } 
 //START Orange SCENARIO
if (document.getElementById('ORANGE').value != "" && (document.getElementById('APPLE').value == "" && document.getElementById('BANANA').value == "" && document.getElementById('PEAR').value == ""))    
{    
alert("You entered a Orange. You must also enter two of the following: Banana, Apple, or Pear.");    
return false; }  

if (document.getElementById('ORANGE').value != "" && document.getElementById('BANANA').value != "" && (document.getElementById('APPLE').value == "" && document.getElementById('PEAR').value == ""))    
{    
alert("You entered a Orange and Banana. You must also enter Apple or Pear.");    
return false; } 

if (document.getElementById('ORANGE').value != "" && document.getElementById('PEAR').value != "" && (document.getElementById('BANANA').value == "" && document.getElementById('APPLE').value == ""))    
{    
alert("You entered a Orange and Pear. You must also enter Banana or Apple.");    
return false; } 
 //START Pear SCENARIO
if (document.getElementById('PEAR').value != "" && (document.getElementById('ORANGE').value == "" && document.getElementById('BANANA').value == "" && document.getElementById('APPLE').value == ""))    
{    
alert("You entered a Pear. You must also enter two of the following: Banana, Apple, or Orange.");    
return false; }  

if (document.getElementById('PEAR').value != "" && document.getElementById('ORANGE').value != "" && (document.getElementById('BANANA').value == "" && document.getElementById('APPLE').value == ""))    
{    
alert("You entered a Pear and Orange. You must also enter Banana or Apple.");    
return false; } 

if (document.getElementById('PEAR').value != "" && document.getElementById('BANANA').value != "" && (document.getElementById('ORANGE').value == "" && document.getElementById('APPLE').value == ""))    
{    
alert("You entered a Pear and Banana. You must also enter Orange or Apple.");    
return false; } 
 
</script> 
 

[Paul Clapham]

And it would also help to know what "not working" means. Read this for information about that: ItDoesntWorkIsUseless.

[Eric Pascarello]

Wow, you can make that code less complicated.

But how are you calling the validation function?

Eric

[Travis Hein]

yea, if you require 3 fields selected, is it important to know which ones not selected.

<script language="javascript">
function validateFruitForm() {

// get a reference on the form 'elements.
// this saves the many document.getElementById() calls, shortens code, might improve performance, 
// but certainly helps make code more readable.

  var appleElement = document.getElemntById('APPLE');
  var orangeElement = document.getElementById('Orange');
  var bananaElement = document.getElementById('BANANA');
  var pearElement = document.getElementById('PEAR');

  var countFieldsWithValues = 0;
  
  if (appleElement.value != "") {
    countFieldsWithValues ++;
  }
  
  if (orangeElement.value != "") {
    countFieldsWithValues ++;
  }
    
  if (bananaElement.value != "") {
    countFieldsWithValues ++;
  }
  
  if (pearElement.value != "") {
    countFieldsWithValues ++;
  }
  
  // because we require at least three out of the four fields selected.
  if (countFieldsWithValues < 3) {
    alert("You only have selected " + countFieldsWithValues + " fields. Please select at least 3 fields.");
    return false;
  }
  return true;
} 
 
</script> 

and maybe this could be called as

 <form name="myForm" method="post" onSubmit="validateFruitForm();">