how does rollbackFor work ?

[Girish Vasmatkar]

Hey guys,

I was going through the spring docs and came to know about this rollbackFor thing which's used to define the class for which the transaction must be rolled back in case exception occurs of that type. So tried the following-

  

@Transactional(readOnly = false, propagation = Propagation.PROPAGATION_REQUIRED, rollbackFor = RuntimeException.class)
public void saveFoo(Foo foo) {
getHibernateTemplate().save(foo);
throw new RuntimeException("Rollback test succeeded");
}

But it does not work. It basically inserts the record and throws the runtime exception and does not rollback.

Am I right in assuming that that's the way it is supposed to work?

[Christophe Verré]

Can you show your application context file ?

[Girish Vasmatkar]

Thanks Christophe for the reply, here is the config file

   

<?xml version="1.0" encoding="UTF-8"?>
<beans xmlns="http://www.springframework.org/schema/beans"
	xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:aop="http://www.springframework.org/schema/aop"
	xmlns:tx="http://www.springframework.org/schema/tx" xmlns:context="http://www.springframework.org/schema/context"
	xmlns:p="http://www.springframework.org/schema/p"
	xsi:schemaLocation="http://www.springframework.org/schema/beans 
	                    http://www.springframework.org/schema/beans/spring-beans.xsd 
	                    http://www.springframework.org/schema/tx
	                    http://www.springframework.org/schema/tx/spring-tx.xsd
	                    http://www.springframework.org/schema/aop
	                    http://www.springframework.org/schema/aop/spring-aop.xsd
	                    http://www.springframework.org/schema/context
		http://www.springframework.org/schema/context/spring-context-3.0.xsd">
	<context:component-scan base-package="actions" />
	<bean id="multipartResolver"
		class="org.springframework.web.multipart.commons.CommonsMultipartResolver">
		<!-- one of the properties available; the maximum file size in bytes -->
		<property name="maxUploadSize" value="100000" />
	</bean>

	<bean id="viewResolver"
		class="org.springframework.web.servlet.view.UrlBasedViewResolver">
		<property name="viewClass"
			value="org.springframework.web.servlet.view.JstlView" />
		<property name="prefix" value="WEB-INF/jsp/" />
		<property name="suffix" value=".jsp" />
	</bean>

	<bean id="myDataSource" class="org.apache.commons.dbcp.BasicDataSource"
		destroy-method="close">
		<property name="driverClassName" value="com.mysql.jdbc.Driver" />
		<property name="url" value="jdbc:mysql://localhost:3306/new" />
		<property name="username" value="root" />
		<property name="password" value="root" />
	</bean>


	<bean id="mySessionFactory"
		class="org.springframework.orm.hibernate3.annotation.AnnotationSessionFactoryBean">
		<property name="dataSource" ref="myDataSource" />
		<property name="annotatedClasses">
			<list>
				<value>domain.Foo</value>
				<value>domain.Test</value>
			</list>
		</property>
		<property name="hibernateProperties">
			<props>
				<prop key="hibernate.dialect">org.hibernate.dialect.MySQLDialect</prop>
				<prop key="hibernate.show_sql">true</prop>
				<prop key="hibernate.hbm2ddl.auto">update</prop>
			</props>
		</property>
	</bean>

	<bean id="myFooDAO" class="dao.FooDao">

		<property name="sessionFactory" ref="mySessionFactory" />
	</bean>
	<bean id="transactionManager"
		class="org.springframework.orm.hibernate3.HibernateTransactionManager"
		p:sessionFactory-ref="mySessionFactory" />


	<tx:annotation-driven />

	<bean id="testDAO" class="dao.TestDao">
		<property name="sessionFactory" ref="mySessionFactory" />
	</bean>

	<bean name="/*.htm" class="actions.UserController">
		<property name="fooDAO" ref="myFooDAO" />

	</bean>
	<bean name="/*.file" class="actions.FileController" p:formView="uploadForm"
		p:successView="userForm">
		<property name="validator">
			<bean class="domain.FileValidator" />
		</property>

	</bean>

	<bean name="/*.test" class="actions.TestController" p:formView="testForm"
		p:successView="xForm">
		<property name="dao" ref="testDAO" />
	</bean>
	

</beans>
 

[Mark Spritzler]

By default transactions @Transactional will automatically rollback when any RuntimeException is thrown. So rollbackFor and noRollbackFor are used to customize specifically what exceptions you want to rollback for. So say you have 15 different RuntimeExceptions that might be thrown and you want only two of them to actually rollback your transaction, then you use the rollbackFor property to list just those two. If you want 12 to rollback and 3 not to rollback, then you use the noRollbackFor property. Basically they are the opposite of each other and you choose the one that will cause you the least amount of typing.

Mark

[Girish Vasmatkar]

Thanks Mark for the nice explanation.

But here, in my case, why is it not roll backing the transaction?

Do I need to specify any subclass of RuntimeException for it to work ?

I see the records being inserted in the database even if the rollbackFor is defined here.

Best

[pete reisinger]

as far as I know, your db needs to support transactions, so I can see that you are using mysql, is it innodb or myisam engine? only innodb supports transactions (I think)

[Mark Spritzler]

Pete.

This is a thread from last August. Please try not to resurrect old threads.

Thanks

Mark