Forum:

JDBC and Relational Databases

Error coming 500 please an code is

Greenhorn

Posts: 6

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

<%-- 
    Document   : Salary
    Created on : Mar 24, 2012, 11:27:02 PM
    Author     : Rushi
--%>

<%@page contentType="text/html" pageEncoding="UTF-8"%>
<!DOCTYPE html>
<html>
    <head>
        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
        <title>Salary Result</title>
    </head>
    <body>
        <%@ page import="java.sql.*" language="java" %>
        <%@ page import="java.io.*"%>
        <%@include file="Administrator.html"%>
    
        <%
        try
          {
   
String eid=null,uname;
String salary,hra,ta,da,pf,gross,nets;
String eid2=request.getParameter("eid");
String uname1=request.getParameter("uname");
String salary1=request.getParameter("salary");
int sal1=Integer.parseInt(salary1);
Connection con = null;
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
con = DriverManager.getConnection("jdbc:odbc:Employee","system","tiger");
Statement stmt = con.createStatement();
ResultSet rs = stmt.executeQuery("select * from EMPLOYEE where eid="+eid2+"'uname='"+uname1+"");
if(rs.next()){ 
        %>
        <table border="1" align="center">
    <tr><td>EID</td><td><input type="text" value="<%=rs.getString("eid")%>"> </td></tr>
    <tr><td>Uname</td><td><input type="text" value="<%=rs.getString("uname")%>"> </td></tr>
   <%}
if(sal1<=4700)
       {%>
    <tr><td> hra</td><td><input type="text" value="<%hra=("sal1+3000");%>"></td></tr>
    <tr><td>da</td><td><input type="text" value="<%da=("sal1+2000");%>"></td></tr>
   <tr><td> ta</td><td><input type="text" value="<%ta=("sal1+3000");%>"></td></tr>
   <tr><td>gross=</td><td><input type="text" value="<%gross=("hra+da+ta");%>"></td></tr>
   <tr><td>nets=</td><td><input type="text" value="<%nets=("gross-pf(480)");%>"></td></tr>
    <%}
else
     {
        System.out.println("Record is not found");
               }
        
String Eid=request.getParameter("eid");
String Uname=request.getParameter("uname");
String Hr=request.getParameter("hra");
String DA=request.getParameter("da");
String TA=request.getParameter("ta");
String Gross=request.getParameter("gross");
String Nets=request.getParameter("nets");

Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
Connection cn = DriverManager.getConnection("jdbc:odbc:Employee","system","tiger");
PreparedStatement s = cn.prepareStatement("insert into Salary values(?,?,?,?,?,?,?)");
s.setString(1,Eid);
s.setString(2,Uname);
s.setString(3,Hr);
s.setString(4,DA);
s.setString(5,TA);
s.setString(6,Gross);
s.setString(7,Nets);
s.executeUpdate();
System.out.println("Record is save");

}catch(Exception e)
                               {
            System.out.println(e);
        }

%>
    </body>
</html>

hello sir here this is the code for inputing salary and output display the payment slip but it give me error 500
first i am running administrator form

this is the administrator form i am inputing value and click on show button it cant show the slip please help me sir

[Added code tags - see UseCodeTags for details]

Matthew Brown

Bartender

Posts: 4568

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Two things spring to mind.

Firstly, telling us you're getting an "error 500" doesn't give us anything to go on - that could be anything. You need to give us more details of exactly what the error is, and the stack trace. That should be available in your logs if it's not actually being displayed on the page.

Secondly, all that Java code should be in a servlet, not in a JSP page. Using scriptlets is a very outdated practice, and one of the problems with it is that it makes it much harder to debug.

[This may or may not be a database issue, and if it isn't it would be much better off in a different forum - but I can't tell without details of what the error is.]

Ronak Trivedi

Greenhorn

Posts: 6

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

when i entering the empid uname and salary it cant go to the salary page it would be refresh the page sir please help me a boutthis code i want to display

Tim Moores

Saloon Keeper

Posts: 7590

177

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Why isn't the "catch" handler in line 76 printing out the entire stack trace so that you'll know in which statement, exactly, the problem occurs?

As I pointed out earlier, your code is still wide open to SQL injection attacks. It would be irresponsible to put it into use. And looking at the syntax of the SELECT query, it seems broken; not sure what you're trying to do there, but that's likely a cause for problems.

Paul Clapham

Marshal

Posts: 28226

I like...

posted 12 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Well, the code does have the usual list of beginner faults. Uses JDBC-ODBC driver -- JSP with scriptlets -- Fails to use PreparedStatement -- Database connection not closed -- Inadequate error handling. Hopefully it's a school exercise from one of those places which, after you graduate, you start again and learn how things are really supposed to be done.

Java 8 (verified skill)
Skill verified by Paul Clapham

When evil is afoot and you don't have any arms you gotta be hip and do the legwork, but always kick some ... tiny ad:

a bit of art, as a gift, the permaculture playing cards

https://gardener-gift.com