js form validation

[Mary Wallace]

I have a form to validate email address and texbox. The email validation is not working. Below is my code. Can someone help me !!

 
 

var testresults
function checkemail(){
var str=document.claims.email.value
var filter=/^([\w-]+(?:\.[\w-]+)*)@((?:[\w-]+\.)*\w[\w-]{0,66})\.([a-z]{2,6}(?:\.[a-z]{2})?)$/i
if (filter.test(str))
testresults=true
else{
alert("Please input a valid email address!")
testresults=false
}
return (testresults)
}
 

 
function testscript(frm)
{
 var tmplen;
 var tmpvalue = new String(document.claims.comments.value);
     tmplen=document.claims.comments.value.length;
     tmpvalue=tmpvalue.substr(0,1000);
     if (tmplen >=1000){
document.claims.comments.value = tmpvalue;
window.alert("Number of characters is limited to 1000");
     }
 

}
function ValidateForm(claims)
{
   if(IsEmpty(claims.comments)) 
   { 
      alert('You have not entered any comments') 
      claims.comments.focus(); 
      return false; 
   }
   
  function checkbae(){
if (document.layers||document.getElementById||document.all)
return checkemail()
else
return true
 
}
    return true;
 }
 
 

 
function IsEmpty(comments) {
  if ((comments.value.length==0) ||
  (comments.value==null)) {
      return true;
   }
   else { return false; }
}
 

[Eric Pascarello]

You have a function inside a function.

Remove the function amd its closing bracket...

function checkbae(){

Eric

[Mary Wallace]

Thanks Eric. As per your suggestion I remvoved the function inside the function.

And in form submission

onsubmit="javascript:return ValidateForm(this);return checkbae()"  

But checkbae is not doing anything

[Eric Pascarello]

AHHH

I was not awake when I looked at the code

keep it the way you had it initially! LOL, I thought it was

function num1(){
  function num2(){
  }
}

oppps

Try this

onsubmit="javascript:return (ValidateForm(this) && checkbae())"  

I think that should work...

Eric

[Mary Wallace]

It worked.............

Million thanks!!!