DOM-problems

[Sebastian Green]

Hi Im using this examplecode below to update an xml file with a new value. It works not so good. I therefor submiting this list and hopefully someone can help.

1. Im having problems to add an attribiute to my elemenst, Im keep getting the error "HIERARCHY_REQUEST_ERR: An attempt was made to insert a node where it is not permitted". I think the idAtt2 is the right way to go, but how to append it?

2. If I comment the attr-part, the new data will end upp in my xmlfile. However there will be NONE indent even when I submit "yes". Why is that?

3. Finally, if some errors will come up it often result in an empty xmlfile. Thats no good, so if you have an better way to update an ceratin xml file with indent and the data is stored. Pls let me know.

package common;
 
import java.io.*;
import javax.xml.parsers.*;
import org.w3c.dom.*;
 
public class JAXPFileWriter{
 
static String usersXMLpath = "users.xml";
 
NodeHandler offer = new NodeHandler();
Document myDocument;
BufferedWriter out;
 
public static void main(String[] ninjax){
 
try{
JAXPFileWriter dom=new JAXPFileWriter(usersXMLpath);
dom.addNode();
dom.writeXML();
}catch(Exception e){
e.printStackTrace();}
}
 
public JAXPFileWriter(String pathToXML){
try{
 
DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
DocumentBuilder builder = factory.newDocumentBuilder();
myDocument = builder.parse(pathToXML);
out = new BufferedWriter(new PrintWriter(new FileWriter(usersXMLpath)));
}catch(Exception s){s.printStackTrace();}

}
 
public void addNode(){
 
Node usrNode = myDocument.createElement("user");
Node nameNode = myDocument.createElement("name");
Node idAtt = myDocument.createAttribute("id");
Attr idAtt2 = myDocument.createAttribute("id");
 
usrNode.appendChild(idAtt2);
usrNode.appendChild(nameNode);
 

idAtt2.setValue("0001");
nameNode.appendChild(myDocument.createTextNode("John Doe"));
 
myDocument.getDocumentElement().appendChild(usrNode);
 
}
 
private Object fileLock=new Object();
 
public void writeXML(){
try{
javax.xml.transform.TransformerFactory myFactory =
javax.xml.transform.TransformerFactory.newInstance();
 
javax.xml.transform.dom.DOMSource myDOMSource=
new javax.xml.transform.dom.DOMSource(myDocument);
 
javax.xml.transform.Transformer myTransformer=myFactory.newTransformer();
 
javax.xml.transform.stream.StreamResult myResult;
myResult=new javax.xml.transform.stream.StreamResult(out);
myTransformer.setErrorListener(new MyErrorListener());
 
DocumentType myDocType=myDocument.getDoctype();
if(myDocType!=null){
String temp=myDocType.getPublicId();
if(temp!=null)
myTransformer.setOutputProperty(javax.xml.transform.OutputKeys.DOCTYPE_PUBLIC,temp);
temp=myDocType.getSystemId();
if(temp!=null)
myTransformer.setOutputProperty(javax.xml.transform.OutputKeys.DOCTYPE_SYSTEM,temp);
myTransformer.setOutputProperty(javax.xml.transform.OutputKeys.INDENT,"yes");
myTransformer.transform(myDOMSource,myResult);
}else
}catch(Exception e){
e.printStackTrace();
}finally{
try{
out.close();
}catch(Exception e){}
}
}
}

[William Brogden]

Yes, you are using it wrong. Look at the org.w3c.dom.Element documentation for the setAttributeNode( ) and related methods. An Attr can't be the child of another Node.

Bill

[Sebastian Green]

I mange to solve the Attr, thanks for the tip. I was looking around in the org.w3c.dom.Node instead of org.w3c.dom.Element.

But I still have the INDENT problem, all the new element are positioned as the root element. Any clue?
[ September 03, 2004: Message edited by: Sebastian Green ]

[Lasse Koskela]

Why not use Element#setAttribute(String, String) instead?

[Sebastian Green]

Thx Lasse. I thougth I would edit the post instead post a new, but as I mention I done with the Element interface. But still, the indent problem. grrr.

[William Brogden]

I can't see anywhere in your code that you log or System.println() any indication that the code path which is supposed to do the setOutputProperty is actually taken. Perhaps it is never called.
Bill

[Sebastian Green]

out = new BufferedWriter(new PrintWriter(new FileWriter(usersXMLpath))) is where is save alla the data. I added some setOutputProperty and the resulted in that alla the nodes where indented but the first!

myTransformer.setOutputProperty(OutputKeys.METHOD, "xml");
myTransformer.setOutputProperty(OutputKeys.ENCODING,"ISO-8859-1");
myTransformer.setOutputProperty("{http://xml.apache.org/xslt}indent-amount", "4");