Problem in Adding Attributes to TLD file

[Micheal John]

How to add more attribute for the customm tags? below is the one of the example, I am trying.. If I am running with one attribute in the TLD, then it's running fine. If I add another attribute, some error is diplaying..

If we are adding attribute elements in the TLD, then setter method for that attribute should be placed in the tag handler..right?

See the below code and where I did the mistake..?

<?xml version="1.0" encoding="ISO-8859-1" ?>
 
<taglib xmlns="http://java.sun.com/xml/ns/j2ee" 
xmlns:xsi="http://www/w3.org/2001/XMLSchema-instance" 
xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee/web-jsptaglibrary_2_0.xsd" 
version="2.0">
 
<tlib-version>1.2</tlib-version>
<uri>SampleAppln</uri>
<function>
<name>call</name>
<function-class>com.example.model.Sample</function-class>
<function-signature>void aMethod()</function-signature>
</function>
 
<tag>
<description>random advice</description>
<name>advice</name>
<tag-class>com.example.model.AdvisorTagHandler</tag-class>
<body-content>empty</body-content>
 
<attribute>
<name>user</name>
<required>true</required>
<rtexprvalue>true</rtexprvalue>
</attribute>
 
[B]<attribute>
<name>user1</name>
<required>true</required>
<rtexprvalue>true</rtexprvalue>
</attribute>[/B] 
</tag>
</taglib>

package com.example.model;
 
import javax.servlet.jsp.*; 
import javax.servlet.jsp.el.*; 
import javax.servlet.jsp.tagext.*; 
import java.io.*;
 
public class AdvisorTagHandler extends SimpleTagSupport{
private String user;
private String user1;
 
public void doTag() throws JspException, IOException{
getJspContext().getOut().write("Hello user::"+ user +"<br>");
getJspContext().getOut().write("Hello user1::"+ user1 +"<br>");
getJspContext().getOut().write("Your advice is: "+ getAdvice() +"<br>");
}
 
public void setUser(String user){
this.user = user;
}
 
[B]public void setUser1(String user1){
this.user1 = user1;
}
 [/B]
String getAdvice(){
String[] adviceStrings = {"That's color's not working for you.","You should call in sick.","You might want to rethink that haircut."};
int random = (int)(Math.random() * adviceStrings.length);
return adviceStrings[random];
}
 
}

<%@ taglib prefix="mine" uri="SampleAppln"%>
 
<%
 
pageContext.setAttribute("userName","Fredrick");
[B]pageContext.setAttribute("userName1","Fred");[/B]%>
 
 
<mine:advice user="${userName}"/>
[B]<mine:advice user1="${userName1}"/> // error come here..???[/B] 

Error Mesasge

org.apache.jasper.JasperException: /customTags.jsp(25,0) According to the TLD or the tag file, attribute user1 is mandatory for tag advice
org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:512)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:377)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
 
 

[ January 10, 2007: Message edited by: Micheal John ]

[Stary Kapec]

<mine:advice user="${userName}"/>
<mine:advice user1="${userName1}"/> // error come here..???

As you configured your TLD both user and user1 attributes are mandatory per every invocation.

Change the code to:

<mine:advice user="${userName} user1="${userName1}" />
<mine:advice user1="${userName1}" user="{userName}" />

But I have a question to you and others. Is there a way to set the TLD so that one attribute was mandatory but only one from the two. For example user or user1 but not both at the same time?

Or is it possible only programmatically for example:

    
public void doTag() throws JspException, IOException {
    if ((user != null) && (user1 != null)) {
        throw new JspException("User and User1 cannot be set both at the same time");
    }
    if ((user == null) && (user1 == null)) {
        throw new JspException("User or User1 must be set");
    }
    ...
}

[ January 10, 2007: Message edited by: Jasiek Motyka ]

[Micheal John]

Hello ranchers,

I am expecting the answer for my problem.. But Jasiek Motyka raised another question for my question, instead of answer.. and finally there is no answer for both of us and thread is seems to be die...

Sorry Ignore this POST !!! I am not read the reply from Jasiek Motyka properly... I got the answer for my question... answer for Jasiek question...

Thanks Jasiek Motyka

[ January 10, 2007: Message edited by: Micheal John ]
[ January 10, 2007: Message edited by: Micheal John ]

[Stary Kapec]

Hi,
sorry for the confusion. I should not have put my own question in your thread but I thought my doubt is somewhat connected with yours.

[Manikandan Jayaraman]

Having one of the two attributes. I hope this are your rules:

- One of the two attributes shd be specified.
- Both shd not appear.

Keep one attribute in tld with 'required' as false. Use one of them as dynamic attrbute. Do programmatic checking for your conditions.