Mark had this to say in the huge Connection lock/unlock
thread (which was a very good read BTW):
"The points I lost was because I added two methods to the Data class that should have been in the CriteriaFindBuilder class..."
Glad I saw this. I've got
public
String getFormattedCriteriaString(
String[][] fieldsAndValues) in Data. Was patting self on back til I saw Mark's post.
Question is: doesn't this method have a good home in Data? Data requires this format, and so should offer this formatting service.
Also, what were your string builder methods, Mark? Is there a more eloquent way to provide raw info to a string builder method than a 2-level array?
p.s. started coding the assignment in earnest just last week and have come to LOVE this site!
), -- each class should focus on the specific purpose. The criteria building (parsing, storing the key-value entries in some data structure, etc) have nothing to do with Data, whose purpose is to describe Data. But since we need the criteriaFind() implemented in data, the criteria building functionality should be isolated in a helper class.
