• Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

What is this sc = 'A' in Data.java ?

 
Stephane Weber
Ranch Hand
Posts: 110
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Can someone tell me what the following line in the Data.java file (provided by SUN in the assignement jar) is ?
Apparently it is not used, but still we probably have to Javadoc that, or do we simply let it like that, uncommented ?

Stephane
P.S. It is also present the same way in DataInfo and FieldInfo.
 
Michael Morris
Ranch Hand
Posts: 3451
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi Stephane,
Here's what I did with it:

Michael Morris
 
Stephane Weber
Ranch Hand
Posts: 110
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Thanks Michael,
I will do just that
Stephane
 
Pete Lyons
Ranch Hand
Posts: 109
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I removed it entirely from Data.java. I just realized I forgot to remove it from FieldInfo and DataInfo, but I think it can be removed from there as well (already turned my assignment in though, D'oh!). It's confusing cruft that just makes any new developer who works on the project spend 10 minutes hunting around for references to it. Get rid of it.
 
BJ Grau
Ranch Hand
Posts: 234
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Also note that it does not follow Sun's convention for naming a constant, and it's modifiers "final static" should be ordered "static final".
I think I'm going to take mine out also.
 
Thomas Fly
Ranch Hand
Posts: 164
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I just zapped it after checking whether there were any javac warning options that would flag such (like Visual C++ has, for example)- there aren't any.
 
Allen Chan
Ranch Hand
Posts: 64
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
ANyone who passed could double confirmed this (just get rid of it) and explain what and where need to be document?
Thanks
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic