Win a copy of Programmer's Guide to Java SE 8 Oracle Certified Associate (OCA) this week in the OCAJP forum!
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Please review my criteriaFind method

 
Sergei Simonov
Greenhorn
Posts: 3
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi there
Please review and comment my criteriaFind method implementation.
fieldMap - HashMap contains field name as the Key and order number of it as the value.

[ December 20, 2002: Message edited by: Junilu Lacar ]
 
Mag Hoehme
Ranch Hand
Posts: 194
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi Sergei,
if it works, it is ok.
However, I find your method somewhat long. I stuffed all this parsing and matching into a separate class, thus encapsulating it.
As a rule of thumb: your methods should be so long that you can view them on the screen without scrolling. If your methods are longer than that, consider refactoring them.
Besides, I used two tokenizers, one for separating the key-value pairs, and the other one for separating the key from the value. Instead of putting all possible delimiters into one string you could use the nextToken(String delim) method.
Hope this helps.
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic