Please help with BufferReader.read()

[V Johnson]

The problem is that my application is hanging on the br.read()line!! Please help me...

//***************************************
// HTTP Server
//***************************************
import java.net.*;
import java.io.*;
import java.util.*;
import java.lang.*;
public class HttpServer01 {
  public static void main(String args[]) {
    int port;
    ServerSocket server_socket;
    try {
       //Set the port number
        port = Integer.parseInt(args[0]);
    }
    catch (Exception e) {
        port = 8080;
    }

    try {
      
      server_socket = new ServerSocket(port);
      System.out.println("HttpServer running on port " +
                   server_socket.getLocalPort());
      // server infinite loop
      while(true) {
        Socket socket = server_socket.accept();
        System.out.println("New connection accepted " +
                   socket.getInetAddress() +
                   ":" + socket.getPort());
        // Construct handler to process the HTTP request message.
        try {
            httpRequestHandler request =
                    new httpRequestHandler(socket);
            // Create a new thread to process the request.
            Thread thread = new Thread(request);
            // Start the thread.
            thread.start();
        }
        catch(Exception e) {
            System.out.println(e);
        }
       } // while
    } // try
    catch (IOException e) {
        System.out.println(e);
    }
 } 
} 
class httpRequestHandler implements Runnable {
    final static String CRLF = "\r\n";
    private Socket socket;
    private InputStream input;
    private OutputStream output;   
    private BufferedReader br; 
    
 
   // Constructor
   public httpRequestHandler(Socket socket) throws Exception {
      this.socket = socket;
      // Get a reference to the socket's input and output streams.      
      this.input = socket.getInputStream();
      this.output = socket.getOutputStream();
      //get input stream from client
      this.br =
       new BufferedReader(new InputStreamReader(socket.getInputStream()));
   }

    // *****************************************************************
    // Implement the run() method of the Runnable interface.
    // *****************************************************************
    public void run() {
     try {
         processRequest();
     }
     catch(Exception e) {
        System.out.println(e);
     }
    }
    private void processRequest() throws Exception {
        
        // read firstline
        String cmdLine = br.readLine();
        System.out.println(cmdLine);
        request.setCommand(cmdLine);
      while(true) {
        String headerLine = br.readLine();
        System.out.println(headerLine);
        // see if we are at end of headers
        if(headerLine.equals(CRLF) || headerLine.equals("")) break;
        // if we have a header, add it to Request object
        request.setHeaderKeyValue(headerLine); 
     }
    
     int contentLength = request.getContentLength();  
     // If Content-length is indicated, read in all the payload bytes
     if ( contentLength > 0) {    
  
      // define byte and char arrays of a specified length
byte [] payload = new byte[contentLength]; char [] buf =
new char[contentLength];
// read the payload data from the BufferedReader     
int count = br.read(buf, 0, contentLength);  //***HERE'S THE PROBLEM!!

// Create a string out of the char array and convert
//that string into byte array
String bufStr = String.copyValueOf(buf); payload =
bufStr.getBytes();
// set the payload as a byte array in the request class
request.setPayload(payload);

System.out.println(request.getPayloadAsString() );
     }

Code Tags added by M^2
[ July 28, 2003: Message edited by: Michael Morris ]

[gautham kasinath]

well, if your program is *hanging* with the buffered reader, then I guess the read() is blocking.
There seems to be nothing on the network i/p buffer and hence the read() blocks, waiting for something to arrive.
It would be great if you can post the client code too.
In the meantime, I will look around the problem with a client of my own.
Cheers
Lupo

[Nick Revak]

The third parameter in the read is the maximum characters to attempt to read.
You could simply try setting your array size to a value much bigger than your would ever expect for contentLength.
But I also think you'd want to do your reads within a while loop (checking for end of stream). If you do this, you need to manage the size of each read to ensure you don't exceed your array.
Try this ....
int currentArrayPos = 0;
int count = 0;
//then, change the max char parameter in your read ....
while ((count = br.read(buf, 0, contentLength - currentArrayPos) != -1 ) {; //***HERE'S THE PROBLEM!!
// and limit the size of each read
currentArrayPos = currentArrayPos + count
}