Chat At Server Part Both write and read at the same time?

[ahmet oguz]

Hi,
I wrote a simple Server/Client chat program. But there is a problem Server always write after client writes something and client always write after server writes something. Because in my while loop first takes from other part(Server or Client) then write.
But i want to write and read at the same time like Msn messenger. So I wrote this code. When i run the server part, server waits for client but when client comes, there is an error like this:

Started: ServerSocket[addr=0.0.0.0/0.0.0.0,port=0,localport=8083]
Acceptted: Socket[addr=/127.0.0.1,port=4500,localport=8083]-->inetAddress:/127.0.0.1
constructor ici:/127.0.0.1
hazir:false
Read class READ error:socket closed

This is my code: Where is wrong? Thanks...
---------------------------------------------------------------------

import java.io.BufferedReader;
import java.io.BufferedWriter;
import java.io.IOException;
import java.io.InputStreamReader;
import java.io.OutputStreamWriter;
import java.io.PrintWriter;
import java.net.ServerSocket;
import java.net.Socket;
 

class Read extends Thread{
private Socket s;
private BufferedReader in;
public Read(Socket s) throws IOException{
System.out.println("constructor ici:" + s.getInetAddress());
this.s = s;
this.in = new BufferedReader(new InputStreamReader(s.getInputStream()));
System.out.println("hazir:" + String.valueOf(in.ready()));
start();
}
public void run(){
try {
while (true){
String s;

s = in.readLine();
System.out.println("Client: " + s);
if (s.equals("bye"))
break;
}
} catch (IOException e) {
// TODO Auto-generated catch block
System.out.println("Read class READ error:" +e.getMessage());
}
finally{
try {
in.close();
s.close();
} catch (IOException e) {
// TODO Auto-generated catch block
System.out.println("Read class Close error:" +e.getMessage());
}
}
}
}
 
class Write extends Thread{
Socket s;
PrintWriter out;
BufferedReader klavye;
public Write(Socket s) throws IOException{
this.s = s;
this.out = new PrintWriter(new OutputStreamWriter(s.getOutputStream()),true);
this.klavye = new BufferedReader(new InputStreamReader(System.in));
start();
}
public void run(){
try {
while(true){
String sz;

sz = klavye.readLine();
out.println(sz);
System.out.println("Server:" + sz);
if (sz.equals("bye"))
break;
}


} catch (IOException e) {
// TODO Auto-generated catch block
System.out.println("Write class Read Error:" + e.getMessage());
}
finally{
out.close();
try {
klavye.close();
s.close();
} catch (IOException e) {
// TODO Auto-generated catch block
System.out.println("Write class Close Error:" + e.getMessage());
}
}

}
}
 

public class ServerBoth {
public static final int port = 8083;
 
public static void main(String[] args) {
// TODO Auto-generated method stub
ServerSocket s = null;
Socket socket = null;
BufferedReader in = null;
//PrintWriter out = null;
//BufferedReader klavye = new BufferedReader(new InputStreamReader(System.in));
try {
 s = new ServerSocket(port);
System.out.println("Started: " + s);
 socket = s.accept();
System.out.println("Acceptted: " + socket + "-->inetAddress:" + socket.getInetAddress());
 //in = new BufferedReader(new InputStreamReader(socket.getInputStream()));
// System.out.println("main ici in durumu:" + String.valueOf(in.ready()));
//out = new PrintWriter( new BufferedWriter(new OutputStreamWriter(socket.getOutputStream())),true);
/*while (true){
System.out.println("while ici in durumu:" + String.valueOf(in.ready()));
String gelen = in.readLine();
if (gelen.equals("gule gule"))
break;
System.out.println("Client: " + gelen);
//out.println(gelen);
//String sz = klavye.readLine();
//out.println(sz);
//System.out.println("Server:" + sz);
//Read r = new Read(in);
//Write w = new Write(out,klavye);

}*/

Read r = new Read(socket);
Write w = new Write(socket);

} catch (IOException e) {
// TODO Auto-generated catch block
e.printStackTrace();
}
finally{
try {
socket.close();
s.close();
//in.close();
//out.close();
} catch (IOException e) {
// TODO Auto-generated catch block
System.out.println("IOException:" + e.getMessage());
}
catch (Exception e) {
// TODO Auto-generated catch block
System.out.println("Exception:" + e.getMessage());
}
}
 
}
 
}

[Mike Guze]

Hi, the socket is closed because in the finally block(in main method) you are closing the socket. When you start the Read and Write, the main method follow his execution and close the socket in the finally block. The program is alive because the Write thread isn't dead.
[ June 09, 2007: Message edited by: Miguel Ivan Gutierrez ]