Hibernate not saving

[Mike London]

I have a simple situation: a single table in MySQL with a primary key set to autogenerate.

However, when I issue code like this (after doing all the setters to set the newUser fields after Users newUser = new Users()):

dao.save(newUser);

A new record does *not* get added to the database.

My users.hbm.xml file has the following for the user PK:

<id name="usrPk" type="java.lang.Integer">
<column name="usr_pk" />
<generator class="identity" />
</id>

My understanding is that the generator class="identity" means that MySQL (5.0x) will create the required PK.

However since a record is not being added, I'm not sure what could be wrong.

Reading from the database using the same dao works fine.

I also have

<property name="hibernate.show.sql">true</property>

set in the hibernate config file, but it doesn't show any sql at all in the output window in Eclipse.

Any advise or suggestions would be appreciated.

Thanks...Mike

[Mark Spritzler]

What does your code look like? Are you opening a session and starting a transaction, then after you create your object are you calling saveOrUpdate() in the Session object or if using JPA calling persist(), then after that committing the transaction?

Please post your code. (Use the code button below to keep the formatting and indentation of code)

Thanks

Mark

[Mike London]

  
 
Code that calls Dao Class below:
 
UsersDAO dao = new UsersDAO();
      try
      {
     // basic testing DAO stuff...all the reading part works (create and save does not)! 
 
         // Step 2 - Use findById to retrieve the message with ID = 1
         Users user = dao.findById(new Integer(1));
         System.out.println("Entity retrieval successful, message is: "
               + user.getUsrFname() + " "+ user.getUsrLastlogindate());
 
        
        // use Dao to get all users
        List <Users> userList = dao.findAll();
        System.out.println(userList.size());
        
        // -----------------------  create and save a new user --------------------------------------------------------
        
     
        Users newUser = new Users();
        newUser.setUsrAccountactive((byte) 1);
        
        newUser.setUsrAccountExpires((byte)0);
        
//        // set expiration date from one year from now       
        Calendar now = Calendar.getInstance();
        now.add(Calendar.YEAR, 1);
        Date dateToStore = now.getTime();        
        newUser.setUsrAccountExpireDate(dateToStore);
        
        // set user first name and last name
        newUser.setUsrFname("admin");
        newUser.setUsrLname("admin");
        
        // user doesn't have to pay.
        newUser.setUsrIsPaidUser((byte) 0);
        
        // set user login/password
        newUser.setUsrLogin("sa");
        newUser.setUsrPassword("");
        
        // save user
        
        dao.save(newUser);
        
      }
      catch (HibernateException e)
      {
         System.err.println("Entity retrieval failed.");      
         e.printStackTrace();
         
      }
      finally
      {
         try
         {
            dao.getSession().close();
         }
         catch (Exception e)
         {
            // do nothing
         }
      }
 
// users mapping file:
 
<hibernate-mapping>
    <class name="testProject.Users" table="users" catalog="users">
        <id name="usrPk" type="java.lang.Integer">
            <column name="usr_pk" />
            <generator class="identity" />
        </id>
        <property name="usrIsPaidUser" type="java.lang.Byte">
            <column name="usr_isPaidUser" not-null="true" />
        </property>
        <property name="usrAccountExpires" type="java.lang.Byte">
            <column name="usr_accountExpires" not-null="true" />
        </property>
        <property name="usrAccountExpireDate" type="java.util.Date">
            <column name="usr_accountExpireDate" length="19" />
        </property>
        <property name="usrFname" type="java.lang.String">
            <column name="usr_fname" length="20" not-null="true" />
        </property>
        <property name="usrMi" type="java.lang.String">
            <column name="usr_mi" length="1" />
        </property>
        <property name="usrLname" type="java.lang.String">
            <column name="usr_lname" length="25" not-null="true" />
        </property>
        <property name="usrEmail" type="java.lang.String">
            <column name="usr_email" length="45" />
        </property>
        <property name="usrPhone" type="java.lang.String">
            <column name="usr_phone" length="25" />
        </property>
        <property name="usrLastlogindate" type="java.util.Date">
            <column name="usr_lastlogindate" length="19" />
        </property>
        <property name="usrAccountactive" type="java.lang.Byte">
            <column name="usr_accountactive" not-null="true" />
        </property>
        <property name="usrLogin" type="java.lang.String">
            <column name="usr_login" length="45" not-null="true" />
        </property>
        <property name="usrPassword" type="java.lang.String">
            <column name="usr_password" length="20" not-null="true" />
        </property>
    </class>
</hibernate-mapping>
 
// usersDao class:
 
import java.util.List;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.hibernate.LockMode;
import org.hibernate.Query;
import org.hibernate.criterion.Example;
 
/**
 * A data access object (DAO) providing persistence and search support for Users
 * entities. Transaction control of the save(), update() and delete() operations
 * can directly support Spring container-managed transactions or they can be
 * augmented to handle user-managed Spring transactions. Each of these methods
 * provides additional information for how to configure it for the desired type
 * of transaction control.
 * 
 * @see testProject.Users
 * @author MyEclipse Persistence Tools
 */
 
public class UsersDAO extends BaseHibernateDAO
{
   private static final Log log = LogFactory.getLog(UsersDAO.class);
 
   // property constants
   public static final String USR_IS_PAID_USER = "usrIsPaidUser";
 
   public static final String USR_ACCOUNT_EXPIRES = "usrAccountExpires";
 
   public static final String USR_FNAME = "usrFname";
 
   public static final String USR_MI = "usrMi";
 
   public static final String USR_LNAME = "usrLname";
 
   public static final String USR_EMAIL = "usrEmail";
 
   public static final String USR_PHONE = "usrPhone";
 
   public static final String USR_ACCOUNTACTIVE = "usrAccountactive";
 
   public static final String USR_LOGIN = "usrLogin";
 
   public static final String USR_PASSWORD = "usrPassword";
 
   public void save(Users transientInstance)
   {
      log.debug("saving Users instance");
      try
      {
         getSession().save(transientInstance);
         log.debug("save successful");
      }
      catch (RuntimeException re)
      {
         log.error("save failed", re);
         throw re;
      }
   }
 
   public void delete(Users persistentInstance)
   {
      log.debug("deleting Users instance");
      try
      {
         getSession().delete(persistentInstance);
         log.debug("delete successful");
      }
      catch (RuntimeException re)
      {
         log.error("delete failed", re);
         throw re;
      }
   }
 
   public Users findById(java.lang.Integer id)
   {
      log.debug("getting Users instance with id: " + id);
      try
      {
         Users instance = (Users) getSession().get("testProject.Users",
               id);
         return instance;
      }
      catch (RuntimeException re)
      {
         log.error("get failed", re);
         throw re;
      }
   }
 
   public List findByExample(Users instance)
   {
      log.debug("finding Users instance by example");
      try
      {
         List results = getSession()
               .createCriteria("testProject.Users").add(
                     Example.create(instance)).list();
         log
               .debug("find by example successful, result size: "
                     + results.size());
         return results;
      }
      catch (RuntimeException re)
      {
         log.error("find by example failed", re);
         throw re;
      }
   }
 
   public List findByProperty(String propertyName, Object value)
   {
      log.debug("finding Users instance with property: " + propertyName
            + ", value: " + value);
      try
      {
         String queryString = "from Users as model where model." + propertyName
               + "= ?";
         Query queryObject = getSession().createQuery(queryString);
         queryObject.setParameter(0, value);
         return queryObject.list();
      }
      catch (RuntimeException re)
      {
         log.error("find by property name failed", re);
         throw re;
      }
   }
 
   public List findByUsrIsPaidUser(Object usrIsPaidUser)
   {
      return findByProperty(USR_IS_PAID_USER, usrIsPaidUser);
   }
 
   public List findByUsrAccountExpires(Object usrAccountExpires)
   {
      return findByProperty(USR_ACCOUNT_EXPIRES, usrAccountExpires);
   }
 
   public List findByUsrFname(Object usrFname)
   {
      return findByProperty(USR_FNAME, usrFname);
   }
 
   public List findByUsrMi(Object usrMi)
   {
      return findByProperty(USR_MI, usrMi);
   }
 
   public List findByUsrLname(Object usrLname)
   {
      return findByProperty(USR_LNAME, usrLname);
   }
 
   public List findByUsrEmail(Object usrEmail)
   {
      return findByProperty(USR_EMAIL, usrEmail);
   }
 
   public List findByUsrPhone(Object usrPhone)
   {
      return findByProperty(USR_PHONE, usrPhone);
   }
 
   public List findByUsrAccountactive(Object usrAccountactive)
   {
      return findByProperty(USR_ACCOUNTACTIVE, usrAccountactive);
   }
 
   public List findByUsrLogin(Object usrLogin)
   {
      return findByProperty(USR_LOGIN, usrLogin);
   }
 
   public List findByUsrPassword(Object usrPassword)
   {
      return findByProperty(USR_PASSWORD, usrPassword);
   }
 
   public List findAll()
   {
      log.debug("finding all Users instances");
      try
      {
         String queryString = "from Users";
         Query queryObject = getSession().createQuery(queryString);
         return queryObject.list();
      }
      catch (RuntimeException re)
      {
         log.error("find all failed", re);
         throw re;
      }
   }
 
   public Users merge(Users detachedInstance)
   {
      log.debug("merging Users instance");
      try
      {
         Users result = (Users) getSession().merge(detachedInstance);
         log.debug("merge successful");
         return result;
      }
      catch (RuntimeException re)
      {
         log.error("merge failed", re);
         throw re;
      }
   }
 
   public void attachDirty(Users instance)
   {
      log.debug("attaching dirty Users instance");
      try
      {
         getSession().saveOrUpdate(instance);
         log.debug("attach successful");
      }
      catch (RuntimeException re)
      {
         log.error("attach failed", re);
         throw re;
      }
   }
 
   public void attachClean(Users instance)
   {
      log.debug("attaching clean Users instance");
      try
      {
         getSession().lock(instance, LockMode.NONE);
         log.debug("attach successful");
      }
      catch (RuntimeException re)
      {
         log.error("attach failed", re);
         throw re;
      }
   }
}
 

// Fields in MySQL Users Table:
 
CREATE TABLE `users` (
  `usr_pk` int(10) unsigned NOT NULL auto_increment,
  `usr_isPaidUser` bit(1) NOT NULL default '\0',
  `usr_accountExpires` bit(1) NOT NULL default '\0',
  `usr_accountExpireDate` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP,
  `usr_fname` varchar(20) NOT NULL,
  `usr_mi` varchar(1) default NULL,
  `usr_lname` varchar(25) NOT NULL,
  `usr_email` varchar(45) default NULL,
  `usr_phone` varchar(25) default NULL,
  `usr_lastlogindate` timestamp NOT NULL default '0000-00-00 00:00:00',
  `usr_accountactive` bit(1) NOT NULL default '\0',
  `usr_login` varchar(45) NOT NULL,
  `usr_password` varchar(20) NOT NULL,
  PRIMARY KEY  USING BTREE (`usr_pk`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
 

 

  

[Cameron Wallace McKenzie]

You might also want to make sure you're catching any exceptions and gathering information from them. You should be getting some feedback if your code isn't working. Do you know that the code is even being encountered?

-Cameron McKenzie

[Pedro Erencia]

Though i'm lacking BaseHibernateDAO code, it seems that the code lacks the transaction demarcation.. It should be something like this..

Session session = sessions.openSession();
[B]Transaction tx = session.beginTransaction();[/B]
session.save(user);
[B]tx.commit()[/B]

Maybe you can consider HibernateTemplate from Spring..

[Cameron Wallace McKenzie]

Indeed.

Even though the Data Access Object will hide much of the Hibernate plumbing from the developer, transaction demarcation is still the responsibility of the integrator who is using the DAO.

You've got to start the transaction before using the DAO, and commit the transaction when you are done.

-Cameron McKenzie

[Mike London]

Yup, that was it!!!

Thanks very much to all who replied!!!

MUCH APPRECIATED.

[Cameron Wallace McKenzie]

You are more than welcome.

-Cameron McKenzie
[ April 24, 2008: Message edited by: Cameron Wallace McKenzie ]