Reading Terminal Input

[Ranjani Swa]

if i enter 5 lines of input by pressing enter, it writes only the 1st line to the file. why is that?

import java.io.*;
class Editor {
public static void main(String[] args) throws IOException{
BufferedReader bin = new BufferedReader(new InputStreamReader(System.in));
FileWriter fw = new FileWriter("Test.txt");
PrintWriter pw = new PrintWriter(fw, false);
String s = "p";
while(true){
try{
s = bin.readLine();
System.out.println(s);
pw.println(s);
if (s.equals(new String("done"))) {
System.out.println(s);
break;
}
}
catch(IOException e) {
System.out.println("Error " + e);
}
pw.close();
}
}
}

[Anna Dow]

I believe that's because you close your PrintWriter after the first pass, so nothing is written after that. After moving pw.close():

public class Test {
public static void main(String[] args) throws IOException{
BufferedReader bin = new BufferedReader(new InputStreamReader(System.in));
FileWriter fw = new FileWriter("Test.txt");
PrintWriter pw = new PrintWriter(fw, false);
String s = "p";
while(true){
try {
s = bin.readLine();
System.out.println(s);
pw.println(s);
if (s.equals(new String("done"))) {
System.out.println(s);
pw.close();
break;
}
}
catch(IOException e) {
System.out.println("Error " + e);
}
}
}
} 
  

all input is written to the file.
Regards,
Anna

[Jessica Sant]

"super co"
Welcome to the JavaRanch! Please adjust your displayed name to match the JavaRanch Naming Policy.
You can change it here.
Thanks! and again welcome to the JavaRanch!

[Ranjani Swa]

Thanks, it worked! I didnt realise that it was inside the loop