Win a copy of Escape Velocity: Better Metrics for Agile Teams this week in the Agile and Other Processes forum!
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
programming forums Java Mobile Certification Databases Caching Books Engineering Micro Controllers OS Languages Paradigms IDEs Build Tools Frameworks Application Servers Open Source This Site Careers Other Pie Elite all forums
this forum made possible by our volunteer staff, including ...
Marshals:
  • Campbell Ritchie
  • Liutauras Vilda
  • Tim Cooke
  • Paul Clapham
  • Jeanne Boyarsky
Sheriffs:
  • Ron McLeod
  • Frank Carver
  • Junilu Lacar
Saloon Keepers:
  • Stephan van Hulst
  • Tim Moores
  • Tim Holloway
  • Al Hobbs
  • Carey Brown
Bartenders:
  • Piet Souris
  • Frits Walraven
  • fred rosenberger

Problem While Removing Element From List

 
Ranch Hand
Posts: 643
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator

output is-> 1 3
i am not able to understand why 1 and 3 is not removed from List.
 
Ranch Hand
Posts: 2023
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator


Because i add 1 in each loop.
1) i=0, remove "0"; The "1" element move to index 0 and l.size()=3
2) i=1, remove "2"; The "3" element move to index 1 and l.size()=2
3) i=2, exit loop because the condition of "i<l.size();"
[ August 04, 2006: Message edited by: wise owen ]
 
Ranch Hand
Posts: 697
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
wise is correct. try to remove the elements from the list backwards.
using highest indeces first. that way, it won't mess up your for loop.
 
Greenhorn
Posts: 1
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
try out this:

////////////////////////////////////////////////////////////////////////////
import java.util.*;
class test
{
public static void main(String args[]){
List<String> l=new ArrayList<String>();
l.add("0");
l.add("1");
l.add("2");
l.add("3");
int size = l.size();
for(int i=0; i < size ; i++){
System.out.println("Removing "+l.get(0));
l.remove(0);
System.out.println("Size is now: "+l.size());
}
for(int i=0;i<l.size();i++){
System.out.println(l.get(i));
}
}
}
//////////////////////////////////////////////////////////////////////////
 
Greenhorn
Posts: 5
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
Hi,

See, your code is running in follwoing manner:
1. Go to first for loop: size of list is 4 and value of i =0.
2. First Attampt: In for loop i < l.size() means 0<4, condition is true go to inside loop and remove "0" from the list and "1" moved to 0th location of the list, now value of list is 3 and i is 1.
Second Attampt: Again go to inside loop and remove "2" because "2" on the 1st position, and then "3" moved to 1th location and then i is 2 and size of list is 2 then condition is false.
 
Ranch Hand
Posts: 59
  • Mark post as helpful
  • send pies
    Number of slices to send:
    Optional 'thank-you' note:
  • Quote
  • Report post to moderator
You should use iterator to remove them.

Iterator iterator=list.iterator();
while(iterator.hasNext()){
iterator.remove();
}


So you can scan and remove all of them. It is more reasonable.
 
Doody calls. I would really rather that it didn't. Comfort me wise and sterile tiny ad:
Garden Master Course kickstarter
https://coderanch.com/t/754577/Garden-Master-kickstarter
reply
    Bookmark Topic Watch Topic
  • New Topic