ZipOutputStream

[Craig Parsons]

I am running a simple compression program I found on the web. I'm trying to get a better idea of how it works. It runs OK but the final Zip file isn't compressed. I am compressing 2 pictures which are about 1.6 MB total but the final zip file is also 1.6 MB. Attached is my source.
Any suggestions?

 
import java.io.*; 
import java.util.zip.*; 
 
public class Zip
{ 
    public static void main(String[] args) throws IOException
    {
       // These are the files to include in the ZIP file
       String[] filenames = new String[]{"c:\\pictures\\Jack_Craig.jpg" , "c:\\pictures\\Stacey with duck_1.jpg"};
    
       // Create a buffer for reading the files
       byte[] buf = new byte[2048];
    
       try  
       { 
           // Create the ZIP file
           String outFilename = "c:\\pictures\\outfile.zip";
           ZipOutputStream out = new ZipOutputStream(new FileOutputStream(outFilename));
          
          
           
           // Compress the files
           for (int i=0; i <filenames.length; i++)
           { 
         
               FileInputStream in = new FileInputStream(filenames[i]);
    
               // Add ZIP entry to output stream.
               out.putNextEntry(new ZipEntry(filenames[i]));
    
               // Transfer bytes from the file to the ZIP file
               int len;
               while ((len = in.read(buf)) > 0)
               {
                   out.setMethod(ZipOutputStream.DEFLATED);
                   out.write(buf, 0, len);
               }
    
               // Complete the entry
               out.closeEntry();
               in.close();
           }
     
           // Complete the ZIP file
           out.close();
           System.err.println("ZIP is done "); 
       }
       catch (IOException e)
       {
           System.err.println("Address is BAD: "); 
       }   
    }
} 

[Joe Ess]

JPG's are already compressed, so it's unlikely they will be compressed further (otherwise, what's to stop you from compressing and re-compressing until you have 1 bit?). Try it with text files. They compress dramatically.

[Craig Parsons]

That was it.
Thanks.