• Post Reply Bookmark Topic Watch Topic
  • New Topic
programming forums Java Mobile Certification Databases Caching Books Engineering Micro Controllers OS Languages Paradigms IDEs Build Tools Frameworks Application Servers Open Source This Site Careers Other all forums
this forum made possible by our volunteer staff, including ...
  • Campbell Ritchie
  • Ron McLeod
  • Paul Clapham
  • Bear Bibeault
  • Junilu Lacar
  • Jeanne Boyarsky
  • Tim Cooke
  • Henry Wong
Saloon Keepers:
  • Tim Moores
  • Stephan van Hulst
  • Tim Holloway
  • salvin francis
  • Frits Walraven
  • Scott Selikoff
  • Piet Souris
  • Carey Brown

input number to array --not displaying right item [code included]

Posts: 18
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator

I'm learning java on my own. I'm on arrays now.

This program is supposed to ask the user to input numbers. As soon as you hit zero (0) the program prints the largest item entered and then quits.

BUG: for some reason, the code sometimes works, sometimes it doesn't. More likely a logical error somewhere I can't see.

For example, you enter 9,3,4,5,7 sometimes it prints out 9. Sometimes it prints 7. It is always the first number or the last one.

Any ideas what's up? many thanks in advance.

[ June 26, 2004: Message edited by: Benjamin Mulder ]
Ranch Hand
Posts: 71
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
>>//added number to array. What if user enters 1? off-by-one error avoided by adding 1
>>list = new int[ number + 1 ] ;

you don't add anything here. you create a new array of length [number]

rewrite your program and add values to an array using:

>>int[] list = new int[ 0 ] ; //array initialiazed to zero length
doesn't make sense. initialiaze it to some other length

>>String inputNumber = "0" ; //initialized to zero
is not as good as
String inputNumber = null; //no reference yet

good luck
Hey! You're stepping on my hand! Help me tiny ad!
the value of filler advertising in 2020
    Bookmark Topic Watch Topic
  • New Topic