Not writing to new file...

[Brandi Love]

Hey all!

This window is part of a project I'm working on. It is supposed to take in a customer's ID number and validate it (the validation as far as I've tested it works perfectly fine). A new file, rewritten.txt, is then created. It reads from the customer information file and rewrites the customer information file to it, making any changes to the customer information that the user has entered and simply rewriting the data otherwise. The problem is, it doesn't write to the rewritten file at all and I can't figure out why. Another window I wrote is similar, yet it does the file writing correctly. Here I'm testing it to make sure it rewrites properly, I'm not actually using the code that makes changes from the original file. I'm sure this is something simple and small that I'm missing, it usually is. Code is below, important stuff bolded...

public class EditCustomerInfo extends JApplet 
{
  private JButton 
    reg = new JButton("Change Customer Info"), 
    menu = new JButton("           Main menu           "), 
    exit = new JButton("                  Exit                  ");
  
  private JTextField
    memIDField = new JTextField(7),
    fNameField = new JTextField(20),
    lNameField = new JTextField(20),
    add1Field = new JTextField(20),
    add2Field = new JTextField(20),
    cityField = new JTextField(20),
    stateField = new JTextField(2),
    zipField = new JTextField(5);
  
  class RegButtonListener implements ActionListener
  {
    public void actionPerformed(ActionEvent e)
    {
      
      String MemID = memIDField.getText();
      String FirstName = fNameField.getText();
      String LastName = lNameField.getText();
      String AddyLine1 = add1Field.getText();
      String AddyLine2 = add2Field.getText();
      String City = cityField.getText();
      String State = stateField.getText();
      String ZipCode = zipField.getText();
      
      try
      {
        String filename = "c:/basicCustomerInfo.txt";
        FileReader fr = 
          new FileReader(filename);
        BufferedReader br =
          new BufferedReader(fr);
        //Allows for reading of customer information file.
        
        [B]FileReader fr2 = 
          new FileReader(filename);
        BufferedReader br2 =
          new BufferedReader(fr2);
        
        String rewriteFile = "c:/rewritten.txt";
        BufferedWriter bw = 
          new BufferedWriter(new FileWriter(rewriteFile, true));
        PrintWriter pw = 
          new PrintWriter(bw);[/B]
        
        boolean valid = false;
        String inLine = "";
        while (inLine != null)
        {
          inLine = br.readLine();
          String equal = "1. " + MemID;
          if (equal.equals(inLine) && equal != null)
          {
            valid = true;
            System.out.println("Member ID Validated");
          }
        }
        
        if (valid == false)
        {
          JOptionPane.showMessageDialog(null, "Error: Invalid customer ID. Please try again.", 
             "ERROR", JOptionPane.WARNING_MESSAGE);
          run(new EditCustomerInfo(), 350, 325);
        }
        
        [B]else
        {
          String fileMemID, fileName, fileAddyLine1, fileAddyLine2,
             fileCityState, fileZip, fileBreak;
          fileMemID = br2.readLine();
          while (fileMemID != null)
          {
              fileName = br2.readLine();
              fileAddyLine1 = br2.readLine();
              fileAddyLine2 = br2.readLine();
              fileCityState = br2.readLine();
              fileZip = br2.readLine();
              fileBreak = br2.readLine();
              System.out.println("Entry read for" + fileMemID);
              
              if (fileMemID != null && !fileMemID.equals("1. " + MemID))
              {
                System.out.println("Entry Writing Started");
                pw.println();
                pw.append(fileMemID);
                pw.println();
                pw.append(fileName);
                pw.println();
                pw.append(fileAddyLine1);
                pw.println();
                pw.append(fileAddyLine2);
                pw.println();
                pw.append(fileCityState);
                pw.println();
                pw.append(fileZip);
                pw.println();
                pw.append(fileBreak);
                System.out.println("Entry Writing Complete");
              }[/B]
              
              else
              {
                pw.println();
                pw.append(fileMemID);
                
                //****************** Checks for Name ******************
                if (!FirstName.equals("") && !LastName.equals(""))
                {
                  pw.println();
                  pw.append(FirstName + " " + LastName);
                }
                else if (FirstName.equals("") && LastName.equals(""))
                {
                  pw.println();
                  pw.append(fileName);
                }
                else
                {
                  StringTokenizer st = new StringTokenizer(fileName);
                  String FirstNameLine = st.nextToken();
                  String LastNameLine = st.nextToken();
                  
                  if (!FirstName.equals("") && LastName.equals(""))
                  {
                    pw.println();
                    pw.append(FirstName + " " + LastNameLine);
                  }
                  else if (FirstName.equals("") && !LastName.equals(""))
                  {
                    pw.println();
                    pw.append(FirstNameLine + " " + LastName);
                  }
                }
                //****************** Checks for Address Line 1 ******************
                if (!AddyLine1.equals(""))
                {
                  pw.println();
                  pw.append(fileAddyLine1);
                }
                
                else
                {
                  pw.println();
                  pw.append(AddyLine1);
                }
                //****************** Checks for Address Line 2 ******************
                if (!AddyLine2.equals(""))
                {
                  pw.println();
                  pw.append(fileAddyLine2);
                }
                
                else
                {
                  pw.println();
                  pw.append(AddyLine2);
                }
                 //****************** Checks for City and State ******************
                if (!City.equals("") && !State.equals(""))
                {
                  pw.println();
                  pw.append(City + " , " + State);
                }
                
                else if (City.equals("") && State.equals(""))
                {
                  pw.println();
                  pw.append(fileCityState);
                }
                
                else
                {
                  StringTokenizer st = new StringTokenizer(fileCityState);
                  String CityLine = st.nextToken();
                  String StateLine = st.nextToken();
                  StateLine = st.nextToken();
                  
                  if (!City.equals("") && State.equals(""))
                  {
                    pw.println();
                    pw.append(City + " , " + StateLine);
                  }
                  else if (City.equals("") && !State.equals(""))
                  {
                    pw.println();
                    pw.append(CityLine + " , " + State);
                  }
                }
                //****************** Checks for Zip ******************
                if (!ZipCode.equals(""))
                {
                  pw.println();
                  pw.append(ZipCode);
                }
                
                else
                {
                  pw.println();
                  pw.append(fileZip);
                }
                //****************** Checks Complete ******************
                pw.println();
                pw.append(fileBreak);
              }
              fileMemID = br.readLine();    
          }
        }
        run(new MenuScreen(), 625, 550);
      }
 
      catch (IOException error) 
      {
        JOptionPane.showMessageDialog(null, "Error: IO exception caught", 
           "ERROR", JOptionPane.WARNING_MESSAGE);
      }
    }
  }
  
  class MenuButtonListener implements ActionListener
  {
    public void actionPerformed(ActionEvent e)
    {
      run(new MenuScreen(), 625, 550);
    }
  }
  
  class ExitButtonListener implements ActionListener
  {
    public void actionPerformed(ActionEvent e)
    {
      System.exit(0);
    }
  }
  
  private RegButtonListener rhandler = new RegButtonListener();
  private MenuButtonListener mhandler = new MenuButtonListener();
  private ExitButtonListener ehandler = new ExitButtonListener();
  
  public void init()
  {
    reg.addActionListener(rhandler);
    menu.addActionListener(mhandler);
    exit.addActionListener(ehandler);
    Container cp = getContentPane();
    cp.setLayout(new GridBagLayout());
     
    GridBagConstraints c = new GridBagConstraints();
    c.gridx = 0;
    c.gridy = GridBagConstraints.RELATIVE;
    c.weightx = 1.0;
    c.insets = new Insets(2, 2, 2, 2);
    c.anchor = GridBagConstraints.EAST;
 
    cp.add(new JLabel("Member ID:", SwingConstants.RIGHT), c);
    cp.add(new JLabel("First name:", SwingConstants.RIGHT), c);
    cp.add(new JLabel("Last name:", SwingConstants.RIGHT), c);
    cp.add(new JLabel("Address (line 1):", SwingConstants.RIGHT), c);
    cp.add(new JLabel("Address (line 2)", SwingConstants.RIGHT), c);
    cp.add(new JLabel("City:", SwingConstants.RIGHT), c);
    cp.add(new JLabel("State:", SwingConstants.RIGHT), c);
    cp.add(new JLabel("Zip:", SwingConstants.RIGHT), c);
    
    c.gridx = 1;    c.gridy = 0;
    c.anchor = GridBagConstraints.WEST;
    cp.add(memIDField, c);
    
    c.gridx = 1;
    c.gridy = GridBagConstraints.RELATIVE;
    cp.add(fNameField, c);
    cp.add(lNameField, c);
    cp.add(add1Field, c);
    cp.add(add2Field, c);
    cp.add(cityField, c);
    cp.add(stateField, c);
    cp.add(zipField, c);
    c.gridx = 0;
    c.gridwidth = 2;
    c.anchor = GridBagConstraints.CENTER;
    cp.add(reg, c);
    cp.add(menu, c);
    cp.add(exit, c);
  }
  
  public static void run(JApplet applet, int width, int height)
  {
    JFrame frame = new JFrame("Red Fox Books and Wax - Edit Customer Information");
    frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    frame.getContentPane().add(applet);
    frame.setSize(width, height);
    applet.init();
    applet.start();
    frame.setVisible(true);
  }
  
  public static void main(String[] args) 
  {
    run(new EditCustomerInfo(), 350, 325);
  }
}

If it helps to make sense of the code, the original customer information (basicCustomerInfo.txt) file is in the following format:

1. 0802636
2. Joe Schmo
3. 123 Main St.
4. Apt 3b.
5. Anywhere , NJ
6. 12345
-----
1. 1837844
2. Jane Doe
3. 98 Sherry Ave.
4.
5. Someplace , NY
6. 01010
-----

[ March 20, 2006: Message edited by: Brandi Love ]
JCE: broke up long lines
[ March 20, 2006: Message edited by: Joe Ess ]

[Paul Clapham]

I don't see "pw.close()" anywhere in those many lines of code. You have to close your file after you finish writing to it.

[Brandi Love]

I'm sure this is something simple and small that I'm missing, it usually is.

Silly mistake, lol. Thanks