file renaming...

[Brandi Love]

I have a file, already on the hard drive (basicCustomerInfo) and another file (rewritten) which I'd like to rename to basicCustomerInfo, getting rid of the original basicCustomerInfo file and replacing it with the contents of rewritten. It doesn't rename it and replace the contents. I saw that trying to rewrite a file while input and output streams are open is a common problem, so I made sure they were all closed properly. It still doesn't rename with the new contents. Does anyone have any idea what I might be doing wrong?

File f1 = new File("c:\\RFBAW\\files\\rewrite.txt");
f1.renameTo(new File ("c:\\RFBAW\\files\\basicCustomerInfo.txt"));

[ March 20, 2006: Message edited by: Brandi Love ]

[Keith Lynn]

Is it possible that the file might still be in use somewhere else?

[Brandi Love]

That doesn't seem to be the case, I closed everything. I checked the other code I wrote that uses these files but I've closed all the input and output, as far as I can see. Could it be possible that the file is in use within another class and that is causing the problem? Maybe I'm missing something...

Here's the code that I wrote, I bolded the relevant stuff.

public class EditCustomerInfo extends JApplet 
{
  private JButton 
    reg = new JButton("Change Customer Info"), 
    menu = new JButton("           Main menu           "), 
    exit = new JButton("                  Exit                  ");
  
  private JTextField
    memIDField = new JTextField(7),
    fNameField = new JTextField(20),
    lNameField = new JTextField(20),
    add1Field = new JTextField(20),
    add2Field = new JTextField(20),
    cityField = new JTextField(20),
    stateField = new JTextField(2),
    zipField = new JTextField(5);
  
  static JFrame frame = new JFrame("Red Fox Books and Wax - Edit Customer Information");
  
  class RegButtonListener implements ActionListener
  {
    public void actionPerformed(ActionEvent e)
    {
      
      String MemID = memIDField.getText();
      String FirstName = fNameField.getText();
      String LastName = lNameField.getText();
      String AddyLine1 = add1Field.getText();
      String AddyLine2 = add2Field.getText();
      String City = cityField.getText();
      String State = stateField.getText();
      String ZipCode = zipField.getText();
      
      try
      {
        [B]String filename = "c:\\RFBAW\\files\\basicCustomerInfo.txt";
        FileReader fr = 
          new FileReader(filename);
        BufferedReader br =
          new BufferedReader(fr);
        //Allows for reading of customer information file.
        
        FileReader fr2 = 
          new FileReader(filename);
        BufferedReader br2 =
          new BufferedReader(fr2);
        
        String rewriteFile = "c:\\RFBAW\\files\\rewritten.txt";
        BufferedWriter bw = 
          new BufferedWriter(new FileWriter(rewriteFile, true));
        PrintWriter pw = 
          new PrintWriter(bw);[/B]
        
        boolean valid = false;
        String inLine = "";
        while (inLine != null)
        {
          inLine = br.readLine();
          String equal = "1. " + MemID;
          if (equal.equals(inLine) && equal != null)
          {
            valid = true;
          }
        }
        br.close();
        
        if (valid == false)
        {
          JOptionPane.showMessageDialog(null, "Error: Invalid customer ID. Please try again.", "ERROR", JOptionPane.WARNING_MESSAGE);
          run(new EditCustomerInfo(), 350, 325);
        }
        
        else
        {
          String fileMemID, fileName, fileAddyLine1, fileAddyLine2, fileCityState, fileZip, fileBreak;
          fileMemID = br2.readLine();
          while (fileMemID != null)
          {
            fileName = br2.readLine();
            fileAddyLine1 = br2.readLine();
            fileAddyLine2 = br2.readLine();
            fileCityState = br2.readLine();
            fileZip = br2.readLine();
            fileBreak = br2.readLine();
            if (fileMemID != null && !fileMemID.equals("1. " + MemID))
            {
              pw.println();
              pw.append(fileMemID);
              pw.println();
              pw.append(fileName);
              pw.println();
              pw.append(fileAddyLine1);
              pw.println();
              pw.append(fileAddyLine2);
              pw.println();
              pw.append(fileCityState);
              pw.println();
              pw.append(fileZip);
              pw.println();
              pw.append(fileBreak);
            }
            
            else
            {
              pw.println();
              pw.append(fileMemID);
              
              if (!FirstName.equals("") && !LastName.equals(""))
              //Changes first and last name.
              {
                pw.println();
                pw.append("2. " + FirstName + " " + LastName);
              }
              else if (FirstName.equals("") && LastName.equals(""))
              {
                //Doesn't change any name information
                pw.println();
                pw.append(fileName);
              }
              else
              {
                StringTokenizer st = new StringTokenizer(fileName);
                String FirstNameLine = st.nextToken();
                FirstNameLine = st.nextToken();
                String LastNameLine = st.nextToken();
                
                if (!FirstName.equals("") && LastName.equals(""))
                {
                  pw.println();
                  pw.append("2. " + FirstName + " " + LastNameLine);
                }
                else if (FirstName.equals("") && !LastName.equals(""))
                {
                  pw.println();
                  pw.append("2. " + FirstNameLine + " " + LastName);
                }
              }
              
              if (!AddyLine1.equals(""))
              {
                pw.println();
                pw.append("3. " + AddyLine1);
              }
                
              else
              {
                pw.println();
                pw.append(fileAddyLine1);
              }
 
              if (!AddyLine2.equals(""))
              {
                pw.println();
                pw.append("4. " + AddyLine2);
              }
                
              else
              {
                pw.println();
                pw.append(fileAddyLine2);
              }
 
              if (!City.equals("") && !State.equals(""))
              {
                pw.println();
                pw.append("5. " + City + " , " + State);
              }
              
              else if (City.equals("") && State.equals(""))
              {
                pw.println();
                pw.append(fileCityState);
              }
                
              else
              {
                StringTokenizer st = new StringTokenizer(fileCityState);
                String CityLine = st.nextToken();
                CityLine = st.nextToken();
                String StateLine = st.nextToken();
                StateLine = st.nextToken();
                  
                if (!City.equals("") && State.equals(""))
                {
                  pw.println();
                  pw.append("5. " + City + " , " + StateLine);
                }
                else if (City.equals("") && !State.equals(""))
                {
                  pw.println();
                  pw.append("5. " + CityLine + " , " + State);
                }
              }
 
              if (!ZipCode.equals(""))
              {
                pw.println();
                pw.append("6. " + ZipCode);
              }
                
              else
              {
                pw.println();
                pw.append(fileZip);
              }
 
              pw.println();
              pw.append(fileBreak);
            }
            fileMemID = br2.readLine();
          }
          [B]pw.close();
          br.close();
          br2.close();
        }
        File f1 = new File("c:\\RFBAW\\files\\rewrite.txt");
        f1.renameTo(new File ("c:\\RFBAW\\files\\basicCustomerInfo.txt"));
        frame.setVisible(false); //closes out reigster new member screen
        MenuScreen.run(new MenuScreen(), 625, 550); //open menu screen in a new frame[/B]
      }
 
      catch (IOException error) 
      {
        JOptionPane.showMessageDialog(null, "Error: IO exception caught", "ERROR", JOptionPane.WARNING_MESSAGE);
      }
    }
  }
  
  class MenuButtonListener implements ActionListener
  {
    public void actionPerformed(ActionEvent e)
    {
      run(new MenuScreen(), 625, 550);
    }
  }
  
  class ExitButtonListener implements ActionListener
  {
    public void actionPerformed(ActionEvent e)
    {
      System.exit(0);
    }
  }
  
  private RegButtonListener rhandler = new RegButtonListener();
  private MenuButtonListener mhandler = new MenuButtonListener();
  private ExitButtonListener ehandler = new ExitButtonListener();
  
  public void init()
  {
    reg.addActionListener(rhandler);
    menu.addActionListener(mhandler);
    exit.addActionListener(ehandler);
    Container cp = getContentPane();
    cp.setLayout(new GridBagLayout());
     
    GridBagConstraints c = new GridBagConstraints();
    c.gridx = 0;
    c.gridy = GridBagConstraints.RELATIVE;
    c.weightx = 1.0;
    c.insets = new Insets(2, 2, 2, 2);
    c.anchor = GridBagConstraints.EAST;
 
    cp.add(new JLabel("Member ID:", SwingConstants.RIGHT), c);
    cp.add(new JLabel("First name:", SwingConstants.RIGHT), c);
    cp.add(new JLabel("Last name:", SwingConstants.RIGHT), c);
    cp.add(new JLabel("Address (line 1):", SwingConstants.RIGHT), c);
    cp.add(new JLabel("Address (line 2)", SwingConstants.RIGHT), c);
    cp.add(new JLabel("City:", SwingConstants.RIGHT), c);
    cp.add(new JLabel("State:", SwingConstants.RIGHT), c);
    cp.add(new JLabel("Zip:", SwingConstants.RIGHT), c);
    
    c.gridx = 1;    c.gridy = 0;
    c.anchor = GridBagConstraints.WEST;
    cp.add(memIDField, c);
    
    c.gridx = 1;
    c.gridy = GridBagConstraints.RELATIVE;
    cp.add(fNameField, c);
    cp.add(lNameField, c);
    cp.add(add1Field, c);
    cp.add(add2Field, c);
    cp.add(cityField, c);
    cp.add(stateField, c);
    cp.add(zipField, c);
    c.gridx = 0;
    c.gridwidth = 2;
    c.anchor = GridBagConstraints.CENTER;
    cp.add(reg, c);
    cp.add(menu, c);
    cp.add(exit, c);
  }
  
  public static void run(JApplet applet, int width, int height)
  {
    //JFrame frame = new JFrame("Red Fox Books and Wax - Edit Customer Information");
    frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    frame.getContentPane().add(applet);
    frame.setSize(width, height);
    applet.init();
    applet.start();
    frame.setVisible(true);
  }
  
  public static void main(String[] args) 
  {
    run(new EditCustomerInfo(), 350, 325);
  }

[ March 20, 2006: Message edited by: Brandi Love ]

[Keith Lynn]

You might also try closing the FileReaders. I'm not sure if that will fix it, but it might.

[Brandi Love]

tried closing everything, still gettin' the error.

pw.close();
br.close();
br2.close();
fr.close();
fr2.close();
bw.close();

I'll try playing around and testing it, there must be something I'm missing somewhere.