Reading file in and sperating it out :URGENT

[Roberto Favaro]

Hey all,
Im really stuck.Im trying to select a file and read its data.I want to seperate this data out so I can assign it to variables. I dont know if i need input streams???.Could someone please help me......

//imports are all corect [using eclipse]
public class Analyser extends JFrame implements ActionListener
{
private Container container;
private JPanel buttonsPanel;

private JButton openButton, analyseButton, generateButton;
private JTextArea textArea;
 
    private File fileName;
private BufferedReader fileInput;
    private String data[];
    private int numLines;
    
    public Analyser(String s)
    {
        super(s);
        // Content pane
        container = getContentPane();
        buttonsPanel = new JPanel();
        buttonsPanel.setLayout(new FlowLayout());
 
        // Open button
        openButton = new JButton("Get File");
        openButton.addActionListener(this);
        buttonsPanel.add(openButton);
        
        // Analyse button
        analyseButton = new JButton("Analyse");
        analyseButton.addActionListener(this);
        buttonsPanel.add(analyseButton);
        analyseButton.setEnabled(false);
 
        // Generate button
        generateButton = new JButton("Generate");
        generateButton.addActionListener(this);
        buttonsPanel.add(generateButton);
        generateButton.setEnabled(false);

        // Text area
        textArea = new JTextArea(5,2);
        
        container.add(buttonsPanel, BorderLayout.NORTH);
        container.add(new JScrollPane(textArea), BorderLayout.SOUTH);
    }
    
    /* ACTION PERFORMED */
    public void actionPerformed(ActionEvent event)
    {
        if (event.getActionCommand().equals("Get File"))
        {
        getFileData();
        }
        else if (event.getActionCommand().equals("Analyse"))
        {
        //analyseFile();
        }
        else if (event.getActionCommand().equals("Generate"))
        {
        //generate();
        }
    }
    
    /* GET FILE */
    private void getFileData()
    {
    // Display file options
JFileChooser fileChooser = new JFileChooser();
fileChooser.setFileSelectionMode(JFileChooser.FILES_ONLY);

int select = fileChooser.showOpenDialog(this);

// Cancel option
if (select == JFileChooser.CANCEL_OPTION)
return;

// Selected file
fileName = fileChooser.getSelectedFile();

if (checkFile())
    analyseButton.setEnabled(true);
    // Read data
    readFile();
}    
    
    /* READ FILE */
    private void readFile()
    {
    generateButton.setEnabled(true);
    
    // Open the file
    openFile();
    getNumberOfLines();
    data = new String[numLines];

// Output to text area
textArea.setText(data[0] + "\n");
for(int i=1; i < 7; i++)
{
    textArea.append(data[i] + "\n");
}
}

    /* GET NUMBER OF LINES */
    private void getNumberOfLines()
    {
        int counter = 0;
// Loop through file incrementing counter
try 
{
    String line = fileInput.readLine();
    while (line != null)
    {
        counter++;
        System.out.println(line);
            line = fileInput.readLine();
}
    numLines = counter;
        closeFile();
    }
catch(IOException ioException)
{
JOptionPane.showMessageDialog(this,"Error reading File", "Error 5: ",JOptionPane.ERROR_MESSAGE); 
closeFile();
System.exit(1);
    }    
}
 
     /* CHECK FILE NAME */
    private boolean checkFile()
    {
    if (fileName.exists())
    return true;
    else 
    JOptionPane.showMessageDialog(null, "ERROR 3: File is a directory");
    if (fileName.canRead())
    return true;
    else
    JOptionPane.showMessageDialog(null, "ERROR 2: Access denied");   
    if (fileName.isFile())
    return(true);
    else
    JOptionPane.showMessageDialog(null, "ERROR 1: No such file!"); 
return(false);
}
    
    /* ------------------------------------------------------- */
    /*                                                         */
    /*                  FILE HANDLING UTILITIES                */
    /*                                                         */
    /* ------------------------------------------------------- */

    /* OPEN FILE */
    private void openFile()
    {
    try 
    {
    // Open file
    FileReader file = new FileReader(fileName);
    fileInput = new BufferedReader(file);
    }
    catch(IOException ioException)
    {
    JOptionPane.showMessageDialog(this,"Error Opening File", "Error 4: ",JOptionPane.ERROR_MESSAGE);
    }
    System.out.println("File opened.......");
}
   
    /* CLOSE FILE */
    private void closeFile()
    {
        if (fileInput != null)
        {
        try
        {
        fileInput.close();
        }
        catch (IOException ioException)
        {
        JOptionPane.showMessageDialog(this,"Error Opening File", "Error 4: ",JOptionPane.ERROR_MESSAGE);
        }
    }
        System.out.println("File closed.......");
}

    /* ------------------------------------------------------- */
    /*                                                         */
    /*                         MAIN METHOD                     */
    /*                                                         */
    /* ------------------------------------------------------- */
    
    /* MAIN METHOD */
    public static void main(String[] args) throws IOException
    {
// Create analyser
Analyser analyser = new Analyser("Travelling Salesman Analyser");
        
// Make window vissible
analyser.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
analyser.setSize(500,400);
analyser.setVisible(true);
    }
}
 

example of data to be read from file

  1 288 149
  2 288 129
  3 270 133
  4 256 141
  5 256 157
  6 246 157

[Stan James]

Set this aside for a minute and put together the smallest program you can that shows where you are stuck. I pulled these lines from different places in your code:

FileReader file = new FileReader(fileName);
fileInput = new BufferedReader(file);
 
String line = fileInput.readLine();
while (line != null)
{
   System.out.println(line);
   line = fileInput.readLine();
}
 
fileInput.close();

If you put that in the main() of a tiny new class, does it work? Does that answer the question about needing streams? What do you want to do to each line next?

[Joe Ess]

Have you taken a look at our FAQ, How To Ask Questions On JavaRanch? It has sections like Ease Up and Isolate The Problem that will help us help you.