Need help writing LoginCheck.jsp page

[Sean Gildea]

I am trying to write a LoginCheck.jsp page so that when someone visits any page on my site, it will check this jsp script thru a <jsp:include... to see if the session value "isValid" is set to true, if so, it will let them continue, if not, it directs them to "login.jsp"

But im having troubles writing this script in JSP.

Can someone look at it and let me know what I'm doing wrong?

Thanks,
Sean

<%// session exists
if ( session != null)
{
System.out.println("Session is not null");
    // retrieve authentication parameter from the session
    Boolean isAuthenticated = (Boolean)session.getAttribute("isValid");
 
    // if the user is not authenticated
    if ( isAuthenticated.booleanValue() == false) { %>
    <jsp:forward page="login.jsp"  />
<%}
}
else { %>
<jsp:forward page="login.jsp"  />
<%
}
%>

[ March 14, 2005: Message edited by: Sean Gildea ]
[ March 14, 2005: Message edited by: Sean Gildea ]

[Ben Souther]

If this is a new session, your isAuthenticated object will be null.

try:

 
if (null == isAuthenticated ||  isAuthenticated.booleanValue() == false) 

The second half will never be evaluated and probably isn't necessary.
[ March 14, 2005: Message edited by: Ben Souther ]