Trouble with dynamic text field in table

[phani kon]

I have a table in jsp like this

mon yr atype comm


All are drop down values except comm. comm is a text field. I am able to update and insert all drop down values . But for comm which is a text field is not updating. Anybody can tell how to add a comm text field to the table
mon yr atype comm
[ October 04, 2005: Message edited by: Bear Bibeault ]

[Ben Souther]

You might want to post some of your code or spend some more time giving us some details about how it is written.

[Bear Bibeault]

"lak kal", please read this.
[ October 03, 2005: Message edited by: Bear Bibeault ]

[phani kon]

[Bear edit: removed complete JSP file on one line that made it impossible to read]
[ October 04, 2005: Message edited by: Bear Bibeault ]

[Bear Bibeault]

"lak kal",

You and I have a number of things to talk about.

Firstly, as I mentioned before, please use a descriptive subject title. "jsp" is not very informative. I have changed the title of this topic for you to something that describes your problem better.

Secondly, please be sure that any code you post to the forum is well-formatted and is not going to screw up the formatting of the topic as the code that you posted has done. I tried to go in and fix the formatting for you, but it was just too much work. So I have removed the code. Please re-post it with line breaks and proper formatting.

Lastly, you are going to need to change your display name to something that is not so obviously fictitious. Just reversing the letters of one name to make another is a bit too obvious.

The JavaRanch is a great place to come and get help with your Java and JSP code. These tips, suggestions and requirements are to help you make the most of this resource.

thanks,
bear
Forum bartender
[ October 04, 2005: Message edited by: Bear Bibeault ]

[phani kon]

 
<table width="430" border="1" cellspacing="0" cellpadding="0">
 <%  int len = months.length;
  for (int i = (len-1); i >= 0; i--) {
  %>
<tr <%if ((i+1) % 2 == 0) {%>class="gridRowAlt"<%} else {%>class="gridRow"<%}%>>
<td style="padding-left=3px" class="formField"><%=monthNames[months[i].intValue()-1]%></td>
<input type="hidden" name="smonth<%=i%>" value="<%=monthNames[months[i].intValue()-1]%>">
<td class="formField" align="center"><%=years[i]%></td>
<input type="hidden" name="syear<%=i%>" value="<%=years[i]%>">
<input type="hidden" name="syrmon<%=i%>" value="<%=years[i]+monthNames[months[i].intValue()-1]%>">
<td class="formField" align="center"><select size="1" name="appstatus<%=i%>" class="formList">
<script>
document.write(top.buildDropdownList("APP"));
/script>
Comments:
<td class="formField" align ="center"><input type="text" name="Comments<%=i%>" </td>
</tr>
<%}%>
</table>[B]Comments:[/B]
 
I want to know how to add comments. How can I get values for comments??
Please help me in this case
  

[phani kon]

Could anyone help me in solving the above problem???

[Bear Bibeault]

"lak kal",

My request that you change your display name was not a suggestion.

Please take a look at the JavaRanch Naming Policy and adjust your display name to match it.

In particular, your display name must be a first and a last name separated by a space character, and [b]must not be obviously fictitious[/b} as yours is.

bear
Forum Bartender

[phani kon]

could any one tell me. Is it possible to add text array field in a jsp table which has got only drop down values???
[ October 05, 2005: Message edited by: lakshmi manepally ]

[Ben Souther]

Create a form parameter with the months size in it.

<input type="hidden" name="months_length" value=\"" + months.length + "\" />"

In the servlet (or jsp if that's your form's target), use that variable to determine how many entries you're dealing with, create an array of that size, and then, within a loop, fill the array elements with the parameters.

 
int monthsLength = 0;
try{
    monthsLength = Integer.parseInt(request.getParameter("months_length"));
}catch(exception e){ // most likely an NPE or NFE
    // deal with exception
}
 
String[] comments = new String[monthsLength];
for(int i = 0; i < monthsLength; i++){
    comments[i] = request.getParameter("Comments" + i);
}

[phani kon]

Can I do like this after

String[] comments = new String[monthsLength];
for(int i = 0; i < monthsLength; i++)
{  
  comments[i] = request.getParameter("Comments" + i);
}
 
 <td class="formField" align ="center"><input type="text" name="apprComment<%=i%>" value ="<%=comments[i]%>"> </td>  

[ October 06, 2005: Message edited by: lakshmi manepally ]

[phani kon]

If I do in the same way as you said it is updating, but after when I was trying to retrive the same value again I am getting nulls.Why it is happening like that??

[Tien-Chih Wang]

Hi,
you can try to store comment values in Session.

Tien-Chih Wang

[phani kon]

I have done like this

int len = month.lenght;
String comment[] = new String[len];
 
 for (int i = (len-1); i >= 0; i--) {
  comment[i] = request.getParameter("Comment" + i);
  session.setAttribute("comm", comment[i]);  
<td class="formField" align ="center"><input type="text" name="comment<%=i%>" value ="<%=session.getAttribute("comm") %>"> </td>
}
 

It is updating successfully on that page and also going to the database.But when I go to previous page and display this page again it is showing null values. I don't understand what is the problem.

[Tien-Chih Wang]

Hi,
When initializing the comment value, the value should be retrieved from DB rather than request.getParameter().
comment = request.getParameter() only used when doing the FORM udpate.
Hope that helps,

Tien-Chih Wang

[phani kon]

No it didn't work. If I update the values it is updating properly, but if go back and try to see the values again, it is showing null values.

[Makarand Parab]

Lakshmi
Can you write step by step scenario what your trying to do. We have seen your code, let me know what exactly your requirement is.

Regards
Makarand Parab

[phani kon]

My requirement is adding a text comment field to this table. If I update the values for comments it updates properly and also going to the database.But if I go back and come to this page and look for the values it is showing null values.

<table width="430" border="1" cellspacing="0" cellpadding="0"> 
<%  int len = months.length;
 String comment[] = new String[len];
  for (int i = (len-1); i >= 0; i--) 
  {%>
 comment[i] = request.getParameter("comments" +i);
 
<tr <%if ((i+1) % 2 == 0) {%>class="gridRowAlt"<%} else{%class="gridRow"<%}%>>
<td style="padding-left=3px" class="formField"><%=monthNames[months[i].intValue()-1]%></td>
<input type="hidden" name="smonth<%=i%>" value="<%=monthNames[months[i].intValue()-1]%>">
<td class="formField" align="center"><%=years[i]%></td><input type="hidden" name="syear<%=i%>" value="<%=years[i]%>">
<input type="hidden" name="syrmon<%=i%>" value="<%=years[i]+monthNames[months[i].intValue()-1]%>">
<td class="formField" align="center"><select size="1" name="appstatus<%=i%>" class="formList">
<script>document.write(top.buildDropdownList("APP"));
/script>
<td class="formField" align ="center"><input type="text" name="comments<%=i%>" value ="<%=comment[i]%>"> 
</td></tr>
<%}%>
</table>
 

<td class="formField" align ="center"><input type="text" name="comments<%=i%>" value ="<%=comment[i]%>">
[ October 06, 2005: Message edited by: lakshmi manepally ]

[s penumudi]

Lakshmi,

Try to understand reply posted by Tien-Chih Wang.
Tien-Chih Wang made a right point.

After updating values into the database, the request is comepleted.
Hence your request object does not contain comments.

To get these values back from the request object you have to explicitly add these comments to request scope. Else, you have to forward your request to same JSP page from your controller/servlet.

Hope this helps.

[phani kon]

How would I add explicilty comment to the request scope

[s penumudi]

From your controller/servlet from where you are navigating back to your JSP page, say

request.setParameter("comment"+i,commentFromDatabase)

Which would make all comments available to the request object.