Problem with c:forEach Tag

[Vidya Moorthy]

Hi all
I am trying to learn JSP Core tags from a book. I am following the sample code in the book for a cart jsp and on pressing update or remove button, it sends it to a servlet showCart. I will post the code for both of them below. The problem is while I click the first product in the cart and click on update, it does the job. For any other product in the cart, it doesn't update the vaule and show the new amount. Please let me know the mistake.

 
<td>
<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
    
<h1>Your cart</h1>
<form action="showProduct" method="post">
<table cellspacing="5" border="0">
  <tr>
    <th align="left">Qty</th>
<th align="left">Name</th>
    <th align="left">Description</th>
    <th align="left">Price</th>
    <th align="left">Amount</th>
  </tr>
 
  <c:forEach var="item" items="${shoppingCart.items}">
  <tr valign="top">
    <td>
        <input type="hidden" name="productCode" value="${item.product.productCode}">
        <input type="text" size="2" name="quantity" value="${item.quantity}">
        <input type="submit" value="Update">
    </td>
<td>${item.product.name}</td>
    <td>${item.product.description}</td>
    <td>${item.product.priceCurrencyFormat}</td>
    <td>${item.grandTotalCurrencyFormat}</td>
    <td><input type="submit" name="removeButton" value="Remove"></td>
  </tr>
  
  </c:forEach>
   
  <tr>
    <td colspan="3">
      <p><b>To change the quantity for an item</b>, enter the new quantity 
            and click on the Update button.</p>
      <p><b>To remove an item</b>, click on the Remove button.</p>
    </td>
  </tr>
</table>
</form>
<form action="<c:url value='ProductsList.jsp' />" method="post">
  <input type="submit" value="Continue Shopping">
</form>
 
 
<form action="<c:url value='displayInvoice' />" method="post">
  <input type="submit" value="Checkout">
</form>
 
 
 
 
</td>
   

This is the code for the servlet

import java.io.IOException;
 
import javax.servlet.RequestDispatcher;
import javax.servlet.Servlet;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;
import com.WebShop.Data.*;
import com.WebShop.Business.Product;
import com.WebShop.Business.ShoppingCart;
import com.WebShop.Business.ShoppingCartItem;
 
public class ShowProduct extends HttpServlet implements Servlet {
public void doPost(HttpServletRequest request,HttpServletResponse response) throws ServletException, IOException{
String productCodeString = request.getParameter("productCode");
String quantityString = request.getParameter("quantity");
String removeButtonValue = request.getParameter("removeButton");
System.out.println("Product Code " + productCodeString);
HttpSession session = request.getSession();
ShoppingCart shoppingCart = (ShoppingCart) session.getAttribute("shoppingCart");
if (session.getAttribute("shoppingCart") == null){
 shoppingCart = new ShoppingCart();
session.setAttribute("shoppingCart", shoppingCart);
}
// If the user enters a negative or invalid number in the
        // Update text box, the quantity is automatically reset to 1.
int quantity = 1;
//int quantity = 0;
try{

quantity = Integer.parseInt(quantityString);

if(quantity < 0)
quantity = 1;

}
catch(NumberFormatException nfe){
quantity = 1;
}
 // If the user clicks the Remove button
if(removeButtonValue !=null){
quantity = 0;
}
Product product = ProductDB.selectProduct(productCodeString);

System.out.println("Product Name " +product.getName());
session.setAttribute("product", product);
if(product != null){

ShoppingCartItem item = new ShoppingCartItem();
item.setProduct(product);
System.out.println("Item name"+ item.getProduct());
item.setQuantity(quantity);

if(quantity>0)
shoppingCart.addItem(item);

else
shoppingCart.removeItem(item);


}

session.setAttribute("shoppingCart", shoppingCart);
String url = "";
       if (shoppingCart.getItems().size() <= 0)
        {
            url = "/ProductsList.jsp";
        }
        else
        {
            url = "/ProductsCart.jsp";
        }
 

RequestDispatcher dispatcher =
getServletContext().getRequestDispatcher(url);
dispatcher.forward(request, response);  
}
public void doGet(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
doPost(request, response);
}
 

}

Thanks in advance
Vidya
[ September 23, 2008: Message edited by: Bear Bibeault ]

[John Schretz]

Rather that repost this, i am having this same exact problem. As i debug in eclipse no matter what row i am on it always grabs the first row of the cart. I assume its because all the qty textfields have the same name, but how would you correct this in the loop?