insert statement

[meena latha]

Hi all...
I am not able to insert the record into the database.
I use able to execute my select statement .
So to check the error i use System.out.println().
Using that i was able to get output just before line 1 .
Below is my code.

 
try{
System.out.println("Inside the try block");
Connection con = ConnectionDB.getConnection();

//ConnectionDB is my database Connection class where i have written code for database connection.
 
StringBuffer sql=new StringBuffer("Insert into customerTable(");
sql.append("FirstName,LastName,Role)value(");
sql.append("?,?,?)");

 prepared = con.prepareStatement(sql.toString());

prepared.setString(1,firstname);
prepared.setString(2,lastname);
prepared.setString(3,address);

 
count =prepared.executeUpdate();//line 1
if(count==1){
message="Successfully added one user.";
}
prepared.close();
con.close();
}catch(SQLException sq){
message = "Error."+sq.toString();
sq.printStackTrace();
}
catch(Exception e){
e.printStackTrace();
}

My printStackTrace gives the following error

[Microsoft][ODBC Microsoft Access Driver] Syntax error in INSERT INTO statement.
at sun.jdbc.odbc.JdbcOdbc.createSQLException(JdbcOdbc.java:6958)
at sun.jdbc.odbc.JdbcOdbc.standardError(JdbcOdbc.java:7115)
at sun.jdbc.odbc.JdbcOdbc.SQLExecute(JdbcOdbc.java:3150)
at sun.jdbc.odbc.JdbcOdbcPreparedStatement.execute(JdbcOdbcPreparedStatement.java:214)
at sun.jdbc.odbc.JdbcOdbcPreparedStatement.executeUpdate(JdbcOdbcPreparedStatement.java:136)
at com.eminence.servlet.InsertServlet.service(InsertServlet.java:56)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.StandardContextValve.invokeInternal(StandardContextValve.java:198)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:152)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:137)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:118)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:929)
at org.apache.coyote.tomcat5.CoyoteAdapter.service(CoyoteAdapter.java:160)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:799)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:705)
at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:577)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:683)
at java.lang.Thread.run(Thread.java:534)

I am not able to locate the error in my insert statement.
Can anybody help me out.
Thanks in advance
Ramya.A

[miguel lisboa]

i'm really not sure, but since error msg says:

Syntax error in INSERT INTO statement

i guess it might be in your insert statement:

Insert into customerTable
values(FirstName,LastName,Role)

hope this helps

[Carol Enderlin]

Not sure why you need to wait for someone else to check your insert statement.

Print out the sql, the values and try it out.

Discussion started over in servlets forum, insert statement.
[ May 15, 2005: Message edited by: Carol Enderlin ]

[Anna Madhusudhanan Natanagopalan]

The problem is in your insert statement.

you mistyped the key word values as value.(second line in your query)

StringBuffer sql=new StringBuffer("Insert into customerTable(");
sql.append("FirstName,LastName,Role)values(");
sql.append("?,?,?)");

Thanks and regards
Anna Madhusudhanan

[Amarender Reddy]

ramya!

you posted the same query in Servlets forum with code. Problem

persists even after the INSERT statement have been corrected. So, to be

sure of everything I insists

==> to check whether the getConnection is declared a static method

==> to check whether the output statements of the getConnection are being

displayed.

==>to override a doGet() or doPost() rather service() method as this could

pose a series of internal problems

cheers
amar

[meena latha]

Thanks amar......
My getConnection() is declared static only.
I am able to manually enter the value into the data base.
Say for like
String sql = "Insert into EntryTable values('ramya','jp','beach');
where ramya,jp,beach are the value i wanted to insert into the database.

The problem arises when i try to take the data from my html page and then insert into the database.

To make sure whether i am able to get the data from html page i outputted the data in my console using System.out.println().

I was able to get the data output from the html page into my console.
I dont know other than these what are the things i should take care off.

[Amarender Reddy]

===========================================================================

The problem arises when i try to take the data from my html page and then insert into the database.

===========================================================================

Then it is clear that your HTML is not able to call the concerned servlet

which would interact with the database. Check the web.xml file for this

servlet and also make sure that the action tag of your HTML page points to

the exact location of this srevlet.

cheers

[meena latha]

Thanks a lot.....
It is working now

[Amarender Reddy]

hi all,

-----------------------------------------------------------

Thanks a lot.....
It is working now

------------------------------------------------------------

i kindly request one-and-all to please post the solution of the queries

that have been answered through this group. Forum is a family and we need

to share not just our questions but answers also, so that others who have a

similar query will be happpy with the answer.

Thank you.

Regards,
amar