commit() and rollback() in a finally block

[Jean Fore]

Hi, according to the Java coding conventions, isn't it appropriate to use the commit() or rollback() in a finally block? Please see the following code which is a portion of my program. Please let me know is it appropriate.

finally {
try {
if (dbConnection != null) {
if (errorFound) {
dbConnection.rollback();
} else {
dbConnection.commit();
}
dbConnection.close();
dbConnection = null;
}
} catch (Exception e) {
e.printStackTrace();
}
}

Thanks
-JEAN

[Bear Bibeault]

Moved to the JDBC forum.

[Mattias Arthursson]

In your code you risk leaving the connection hanging if any exception is encountered during commit() or rollback(). I'd probably put the rollback() in the catch block and the commit() last in the original try block, like so:

Connection dbConnection = null;
try{
  dbConnection = getConnection();
  <your stuff here>
  ...
  dbConnection.commit();
}catch(SQLException e){
  try{
    dbConnection.rollback();
  }catch(Exception e){
    // Log this
  }
  // Log the original error or throw the exception on upwards
  // to be handled elsewhere
}finally{
  try{
    dbConnection.close();
  }catch(Exception e){
    // Never mind this
  }
}

[Jean Fore]

Thank you so much for the response. Now I understand the flow of how to do this!
-JEAN