• Post Reply Bookmark Topic Watch Topic
  • New Topic

Shorten setString lines  RSS feed

 
Ed Carrington
Ranch Hand
Posts: 77
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I have a PreparedStatement with alot of values to insert into an Oracle Database.
Anyway to shorten the setString lines in a loop or any other way to shorten this??



[added line breaks so page doesn't wrap horizontally]
[ November 14, 2007: Message edited by: Jeanne Boyarsky ]
 
Jeanne Boyarsky
author & internet detective
Sheriff
Posts: 36453
456
Eclipse IDE Java VI Editor
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Ed,
You could shorten the code by having a method that loops through a string array and calls setString on each element.

However, I think the current code is clearer. It seems like coincidence that all the values are strings. What if you had a date field? I expect you would want to call setDate rather than setString.
 
It is sorta covered in the JavaRanch Style Guide.
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
Boost this thread!