Comparable

[Frank Jacobsen]

It seems that I still dont understand this, look at this example:

// Here is a class where i try to sort a list of Beans

private static void sortHistSortTekstAsc(KontoViewbean kvb, SortingRules ortingrules) {
 
kvb.setSortingrules(sortingrules);
 
PosteringsListBean plb = kvb.getPosteringsList();
 
HistSortTekstComparator sammenligner = new HistSortTekstComparator();
 
java.util.Collections.sort(plb.getHistoriskList(), sammenligner);
 
}
 
Here is my Comparator:
 
package dk.bankdata.portlet.xko.kontobevaegelser.sorting;
 
import java.util.Comparator;
 
import dk.bankdata.portlet.xko.kontobevaegelser.bean.HistoriskViewbean;
 
public class HistSortBeloebComparator implements Comparator {
 
/**
 * @see Comparator#compare(Object, Object)
 */
 
public int compare(Object element0, Object element1) {
 
System.out.println("FJA er i HistSortBeloebComparator");

return sammenlign(element0, element1);
}
 
private static int sammenlign(Object element0, Object element1) {
 
HistoriskViewbean hvbA = (HistoriskViewbean) element0;
 
HistoriskViewbean hvbB = (HistoriskViewbean) element0;
 
double beloebA = Double.parseDouble(hvbA.getBeloeb().trim());
double beloebB = Double.parseDouble(hvbB.getBeloeb().trim());
double sammenlignBeloeb = beloebA - beloebB;

if (sammenlignBeloeb < 0) return -1;

if (sammenlignBeloeb < 0) return 1;

return 0;
 


 

}
 
}
 
Here is the a littel of the objekt i try to sort:
 
public class HistoriskViewbean extends PosteringViewbean implements Comparable {
 
public static final String NAME = "HistoriskViewbean";
 
public static final char TYPE = 'H';
 
private long identifikation;
private List detailposter;
private boolean samlepostering;
private boolean detailpostering;
private Hashtable detailpostTabel;
private String valoerdato;
private String postSaldo;
private char postType;
private GregorianCalendar bogfDato;
private HistoriskDetaljerViewbean detaljer;
 
private long sort = 0;
 
private boolean visEnkeltposter;
private boolean visEnkeltposterIkon = true;
private boolean visMeddelelser;
private boolean visMeddelelserIkon = true;
private boolean visDetaljer;
private boolean visDetaljerIkon = false;
private boolean visFoldsammenIkon = false;
 
private SortingRules sortingrules;
 
public HistoriskViewbean(HistoriskPosteringEIS hist, String noegle, Locale locale) {
super(noegle, DateFormatter.format(hist.getBogfDato(), locale), hist.getTekst(), hist.getBeloeb().format(locale));
this.identifikation = hist.getIdentifikation();
samlepostering = hist.getType() == '1';
detailpostering = hist.getType() == '2';
detailposter = Collections.synchronizedList(new ArrayList());
detailpostTabel = new Hashtable();
valoerdato = DateFormatter.format(hist.getValoerDato(), locale);
postSaldo = hist.getPostSaldo().format(locale);
postType = hist.getType();
bogfDato = hist.getBogfDato();
}
 
public char getType() {
return TYPE;
}
 
public int compareTo(Object o) {
 
System.out.println("FJA er i compare to i HistorikViewBEan");
 
long resultat = ((HistoriskViewbean) o).getIdentifikation() - this.identifikation;
 
if (resultat < 0)
return -1;
else if (resultat > 0)
return 1;
else
return 0;
 
}
 

The amounts before and after looks like this:

-14,45
123
243,54
776,33

The confused Frank !


[ June 09, 2004: Message edited by: Carl Trusiak ]

[Frank Jacobsen]

I will do it a litte bit simpler:


public class HistSortBeloebComparator implements Comparator {

/**
* @see Comparator#compare(Object, Object)
*/

public int compare(Object element0, Object element1) {

System.out.println("FJA er i HistSortBeloebComparator1");

return sammenlign(element0, element1);
}

private static int sammenlign(Object element0, Object element1) {

HistoriskViewbean hvbA = (HistoriskViewbean) element0;

HistoriskViewbean hvbB = (HistoriskViewbean) element1;

double beloebA = Double.parseDouble(hvbA.getBeloeb().trim());
double beloebB = Double.parseDouble(hvbB.getBeloeb().trim());

if (beloebA < beloebB) return -1;

if (beloebA > beloebB) return 1;

return 0;

}

}

I have + and - ammounts, but it dont sort the amount in the right order !

Help Frank

[Carl Trusiak]

They are sorted by the logic you have, apparently they are in the correct order already. Try this for a quick test, shift the returns for a reverse order and run it.

Instead of

if (beloebA < beloebB) return -1;
if (beloebA > beloebB) return 1;

Try

if (beloebA < beloebB) return 1;
if (beloebA > beloebB) return -1;

Is the ordering different now?