Updating a JTree

[Jennifer Sohl]

Hi. I have an app that I want to update a JTree as a user enters data. Right now, I have a JTree as the left component on a JSplitPane, and a panel for Maintenance for this JTree as the right component. When the user adds a new entry into the DB, I want the JTree to automatically show the new data after the user presses save.
I am trying to use the reload() method to accomplish this, but am not seeing any changes in the JTree. Could someone tell me what I've missed or done wrong? Here's the method that runs when the user presses Save...

public void saveAssyFamily() {
CallableStatement csSave = null;
ResultSet rsSave = null;
try {
csSave = con.prepareCall("{call essp_updateAssyFamily(?,?,?,?)}");
csSave.setString(1,assyNo.getText().trim());
csSave.setString(2,SKValues.getFamilyID(con,(String)families.getSelectedItem()));
csSave.setString(3,SKValues.getGroupID(con,(String)groups.getSelectedItem()));
csSave.setString(4,SKValues.getSubID(con,(String)subGroups.getSelectedItem()));
csSave.executeUpdate();
assyNo.setText("");
families.setSelectedIndex(0);
groups.setSelectedIndex(0);
subGroups.setSelectedIndex(0);
fTree.refreshTree();
}
catch(SQLException sqle) {
JOptionPane.showMessageDialog(this,"AssyProductMaintE03-"+sqle,"ERROR",JOptionPane.ERROR_MESSAGE);
}
finally {
try {
if(csSave != null) csSave.close();
}
catch(SQLException sqle) {
JOptionPane.showMessageDialog(this,"AssyProductMaintE04-"+sqle,"ERROR",JOptionPane.ERROR_MESSAGE);
}
}
}  

Here's the "refreshTree" method from another class...

public void refreshTree() {
treeModel.reload();
}  

I am using the DefaultTreeModel. Let me know if you need to see any other code. Thanks for any help!

[Nathan Pruett]

You'll need to rebuild the tree model from the database in the "refreshTree()" method. "reload()" tells the tree model that some of its nodes were changed and it needs to update. Since your nodes aren't actually tied to the database, but only hold data that was pulled from the database at the time they are created, the nodes haven't changed, only the data in the database has. You'll need to rebuild the tree model, just like you did when you first created it.

[Jennifer Sohl]

Thanks for straightening me out. I've got the tree updating now.
However, I do have another question on why my tree is doing something.
Here are some records from the db:
Backsplash Laminated Finished
Backsplash Top No Sub-Group
Backsplash Top Without Doors
Basically, from left to right these values are being added into my tree. If the third column has a value of "No Sub-Group" , I do not want to add this as a node to the value in the second column (as you will see in my code).
My problem is I keep getting two "Top" nodes showing up under my "Backsplash" node, and I don't know why. One of the "Top" nodes has no children, and the other has a child ("Without Doors").Could someone take a look at my code and tell me why?
Thanks again!!

public void createNodes() {
CallableStatement csGet = null;
ResultSet rsGet = null;
top = new DefaultMutableTreeNode("Family");
DefaultMutableTreeNode family = null;
DefaultMutableTreeNode group = null;
DefaultMutableTreeNode subGroup = null;
String lastFam = null;
String lastGrp = null;
try {
csGet = con.prepareCall("{call essp_getAssyFamilies()}");
rsGet = csGet.executeQuery();
while(rsGet.next()) {
// Add families to tree (Only if it hasn't already been added)
if(!rsGet.getString(1).trim().equals(lastFam)) {
family = new DefaultMutableTreeNode(rsGet.getString(1));
top.add(family);
lastFam = rsGet.getString(1).trim();
}
// Add groups to tree (if not blank, and hasn't already been added)
if(!rsGet.getString(2).trim().equals("No Group")) {
group = new DefaultMutableTreeNode(rsGet.getString(2));
if(!group.isNodeChild(family)) {
family.add(group);
lastGrp = rsGet.getString(2).trim();
}
}
// Add subgroups to tree (if not blank, and hasn't already been added)
if(!rsGet.getString(3).trim().equals("No Sub-Group")) {
subGroup = new DefaultMutableTreeNode(rsGet.getString(3));
if(!subGroup.isNodeChild(group)) {
group.add(subGroup);
}
}
}
}
}  

[ April 15, 2003: Message edited by: Jennifer Sohl ]

[Nathan Pruett]

I think your problem is that the "isNodeChild()" method is not returning what you think it is. For example :

group = new DefaultMutableTreeNode(rsGet.getString(2));
if(!group.isNodeChild(family)) {

Right before you called "isNodeChild()" you created a new node. So it is impossible for this new node to be a child of the family node! Instead of checking whether a node is a child, you need to see if one of the existing nodes contains the string value you are trying to add.

This would be done like this (modified your code):

    public void createNodes() {
        top = new DefaultMutableTreeNode("Family");
        DefaultMutableTreeNode family = null;
        DefaultMutableTreeNode group = null;
        DefaultMutableTreeNode subGroup = null;
        try {
            CallableStatement csGet = con.prepareCall("{call essp_getAssyFamilies()}");
            ResultSet rsGet = csGet.executeQuery();
            while( rsGet.next() ) {
                // Add families to tree (Only if it hasn't already been added)
                String familyName = rsGet.getString( 1 ).trim();
                family = checkNode( familyName, top );
                // Add groups to tree (if not blank, and hasn't already been added)
                String groupName = rsGet.getString( 2 ).trim();
                if ( !groupName.equals( "No Group" ) ) {
                    group = checkNode( groupName, family );
                    // Add subgroups to tree (if not blank, and hasn't already been added)
                    String subGroupName = rsGet.getString( 3 ).trim();
                    if ( !subGroupName.equals( "No Sub-Group" ) ) {
                        subGroup = checkNode( subGroupName, group );
                    }
                }
            }
        }
        catch( Exception x ) {
            x.printStackTrace();
        }
    }
    
    private DefaultMutableTreeNode checkNode( Object name, DefaultMutableTreeNode parent ) {
        // Return the node if it already exists
        Enumeration children = parent.children();
        DefaultMutableTreeNode temp = null;
        while ( children.hasMoreElements() ) {
            temp = (DefaultMutableTreeNode)children.nextElement();
            if ( temp.getUserObject().equals( name ) ) {
                return temp;
            }
        }
        // If the node hasn't been found, create it under parent, then return it.
        temp = new DefaultMutableTreeNode( name );
        parent.add( temp );
        return temp;
    }

[Jennifer Sohl]

Aha! You were right. isNodeChild() was not doing what I thought it was. The modified code you gave me works wonderfully.
But now I wonder, what does isNodeChild() exactly do, and when would be a situation that I would need to use it?
Thanks again for all of your help!!
I really, really appreciate it.

[Nathan Pruett]

isNodeChild() tests to see if the specified node is a child of this one. The node is separate from the value it contains. I haven't tested this out, but I assume that DefaultMutableTreeNode just uses the equals() method to find this out. Default equals() just tests references. You can override equals() to test equality in other ways (for example, test the values of the User Objects contained in the node rather than test node references against each other.), but I'm not sure how this would affect the tree...