Slight JTable problem

[Amy Phillips]

Hi,
I have created a JTable and displayed the results of a SQL query. It compiles and runs fine but displays each recordSet 10 times. Can anyone see why this is happening?

  
import java.awt.*;
import java.awt.event.*;
import java.sql.*;
import java.util.*;
import javax.swing.*;
import javax.swing.event.*;
import javax.swing.table.*;
public class SearchView extends JPanel
{
private String searchTable;
private Connection connection;
private Statement statement;
private TableModel model;
private JTable table;
private final String searchCriteria = " ";

public SearchView(Connection c)
{
connection = c;
BorderLayout layout = new BorderLayout();
setLayout(layout);

//create form objects
JLabel titleLabel = new JLabel("Showing all Defect Reports");
resultSet(connection);
JScrollPane tableScroller = new JScrollPane();
tableScroller.add(table);
//add components to the screen
add(titleLabel, BorderLayout.NORTH);
add(new JScrollPane(table), BorderLayout.CENTER);
}
    private void resultSet(Connection c)
    {
    connection = c;
try
{
Statement statement = connection.createStatement();

        String query = "SELECT * FROM DefectReport";
ResultSet rs = statement.executeQuery(query);

    table = new JTable(new CachingResultSetTableModel(rs));
rs.close();
}
catch(SQLException e)
{
System.out.println("Error");
}
    }
}
abstract class ResultSetTableModel extends AbstractTableModel
{
public ResultSetTableModel(ResultSet aResultSet)
{
rs = aResultSet;
try
{
rsmd = rs.getMetaData();
}
catch(SQLException e)
{
e.printStackTrace();
}
}

public String getColumnName(int c)
{
try
{
return rsmd.getColumnName(c + 1);
}
catch(SQLException e)
{
e.printStackTrace();
return " ";
}
}

public int getColumnCount()
{
try
{
return rsmd.getColumnCount();
}
catch(SQLException e)
{
e.printStackTrace();
return 0;
}
}

protected ResultSet getResultSet()
{
return rs;
}

private ResultSet rs;
private ResultSetMetaData rsmd;
}

class CachingResultSetTableModel extends ResultSetTableModel
{
public CachingResultSetTableModel(ResultSet aResultSet)
{
super(aResultSet);
try
{
cache = new ArrayList();
int cols = getColumnCount();
ResultSet rs = aResultSet;

while(rs.next())
{
Object[] row = new Object[cols];
for (int j = 0; j < row.length; j++)
{
row[j] = rs.getObject(j + 1);
cache.add(row);
}
}
}
catch(SQLException e)
{
System.out.println("Error " + e);
}
}

public Object getValueAt(int r, int c)
{
if(r < cache.size())
return ((Object[])cache.get(r))[c];
else
return null;
}

public int getRowCount()
{
return cache.size();
}

private ArrayList cache;
}

Thanks
[ February 13, 2004: Message edited by: Amy Phillips ]

[Stuart Hoffman]

Amy, I'm a newbie but is it possible in this piece of the code that the for loop is executed too many times since it is inside of a while loop?
while(rs.next()){Object[] row = new Object[cols];for (int j = 0; j < row.length; j++){row[j] = rs.getObject(j + 1);cache.add(row);}}

Hope that helps
Stuart

[Amy Phillips]

Hi Stuart,
Thanks for your help, the problem was with the loop - I had the add(row) line inside the for loop so every line was being added 10 times.

btw - Welcome to the Java Ranch