Regarding JComboBox in a JTable

[seema prakash]

Hi ,
I have the JTable with my last column that has to be rendered as a JComboBox. But, I'm not able to expand it and select a different value. I'm not able to find out what am I doing wrong. Please can anyone help.
My code is as follows:

    
import javax.swing.*;
import javax.swing.table.*;
import java.awt.*;
import java.awt.event.*;
 
class JTableButtonRenderer implements TableCellRenderer {
  private TableCellRenderer __defaultRenderer;
 
  public JTableButtonRenderer(TableCellRenderer renderer) {
    __defaultRenderer = renderer;
  }
 
  public Component getTableCellRendererComponent(JTable table, Object value,
 boolean isSelected,
 boolean hasFocus,
 int row, int column)
  {
    if(value instanceof Component)
      return (Component)value;
    return __defaultRenderer.getTableCellRendererComponent(
   table, value, isSelected, hasFocus, row, column);
  }
}
 
class JTableButtonModel extends AbstractTableModel {
  private Object[][] __rows = {
      { new JButton("Button One"),"One", "AND"},
      { new JButton("Button Two"),"Two", "OR" },
      { new JButton("Button Three"),"Three", "AND" },
      { new JButton("Button Four"),"Four", "OR" }
    };
 
  private String[] __columns = { "Buttons","Numbers", "Combo Box"  };
  
  public String getColumnName(int column) { 
    return __columns[column];
  }
 
  public int getRowCount() {
    return __rows.length;
  }
 
  public int getColumnCount() {
    return __columns.length;
  }
 
  public Object getValueAt(int row, int column) { 
      return __rows[row][column];
  }
 
  public boolean isCellEditable(int row, int column) {
    return false;
  }
 
  public Class getColumnClass(int column) {
    return getValueAt(0, column).getClass();
  }
}
 
public final class JTableButton extends JFrame {
  private JTable __table;
  private JScrollPane __scrollPane;
  String[] values = {"AND", "OR"};
  
  public JTableButton() {
    super("JTableButton Demo");
       
    TableCellRenderer defaultRenderer;
    
 
    __table = new JTable(new JTableButtonModel());
    
    defaultRenderer = __table.getDefaultRenderer(JButton.class);
    //cell renderer for column with JButton
    __table.getColumnModel().getColumn(0).setCellRenderer(new 
                         JTableButtonRenderer(defaultRenderer));  
 
    //cell renderer for column with JComboBox 
    __table.getColumnModel().getColumn(2).setCellRenderer(new 
                         MyComboBoxRenderer(values));
    //cell editor for column with JButton
    __table.getColumnModel().getColumn(2).setCellEditor(new MyComboBoxEditor(values));    
     
    __table.setPreferredScrollableViewportSize(new Dimension(400, 200));
   
    __scrollPane = new JScrollPane(__table);
    setContentPane(__scrollPane); 
  }
 
    class MyComboBoxRenderer extends JComboBox implements TableCellRenderer {
        public MyComboBoxRenderer(String[] items) {
            super(items);
        }
    
        public Component getTableCellRendererComponent(JTable table, Object value,
                boolean isSelected, boolean hasFocus, int row, int column) {
            if (isSelected) {
                setForeground(table.getSelectionForeground());
                super.setBackground(table.getSelectionBackground());
            } else {
                setForeground(table.getForeground());
                setBackground(table.getBackground());
            }
    
            // Select the current value
            setSelectedItem(value);
            return this;
        }
    }
    
     class MyComboBoxEditor extends DefaultCellEditor {
        public MyComboBoxEditor(String[] items) {
            super(new JComboBox(items));
        } 
    }
 
 
 
  public static void main(String[] args) {
    Frame frame;
    WindowListener exitListener;
 
    exitListener = new WindowAdapter() {
      public void windowClosing(WindowEvent e) {
Window window = e.getWindow();
window.setVisible(false);
window.dispose();
System.exit(0);
      }
    };
 
    frame = new JTableButton();
    frame.addWindowListener(exitListener);
    frame.pack();
    frame.setVisible(true);
  }
}
 

[seema prakash]

I did get help and the mistake was in my
class JTableButtonModel extends AbstractTableModel {
.....
public boolean isCellEditable(int row, int column) {
return false;
}
....
}


I had to change it to this

class JTableButtonModel extends AbstractTableModel {
.....
public boolean isCellEditable(int row, int column) {
// 1st solution
return true;

// or 2nd solution, make it such that only column 2 it editable
if(column == 2) {
return true;
}

return false;
}
....
}

I hope it will be helpful for someone with the similar problem.