values changed, math didnt.

[ken zemaitis]

Hi everyone, I've made a calculator that calculates the amount of calories burned during a workout, and body mass index. Most of the calculations work well, however, when the user changes their body weight, the calories burned calculation doesn't change. The JButtons I am using work fine the first time, however if you go back and change the weight value you input after the first calculation, the calculation doesn't change. Any help would be greatly appreciated as this is due very soon. Thank you very much.

    
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.event.*;
import java.text.*;
public class App {
 
//I have created a calorie calculator.  I have determined the standard amounts of calories burned for each activity for
//a 150 pound human being.  The weight they enter is compared with the 150 pound human and the correct calculations are
//made to determine how many calories you burn while running, biking, swimming or walking.
//K!Zemaitis
 
 
  JFrame frame;
  JButton about;
  JList choice;
  JTextField time;
  JTextField weight;
  JTextField heightFeet;
  JTextField heightInch;
  JButton calculate;
  JButton bmi;
  JButton clear;
  JTextArea message;
  String[] activities = {"Running", "Biking", "Swimming", "Walking"};
  double[] calories = {15.33, 6.83, 8.33, 5.33};
 
  public static void main(String[] args) {
    App me = new App();
    me.go();
  }
 
//This is the layout for my calorie calculator.  It is a flow layout and it is designed to be easy to read and easy to use.
//K!Zemaitis
 
  public void go() {
    frame = new JFrame("Calorie Calculator");
    frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
    frame.setSize(500, 400);
    frame.setBackground(Color.blue);
    frame.setVisible(true);
    frame.setResizable(false);
    frame.getContentPane().setLayout(new FlowLayout());
    frame.getContentPane().add(new JLabel("Selection:"));
    choice = new JList(activities);
    choice.setSelectedIndex(0);
    frame.getContentPane().add(choice);
    frame.getContentPane().add(new JLabel("  Time:"));
    time = new JTextField(4);
    time.addActionListener(new TimeListener());
    frame.getContentPane().add(time);
    frame.getContentPane().add(new JLabel("  Weight:"));
    weight = new JTextField(4);
    weight.addActionListener(new WeightListener());
    frame.getContentPane().add(weight);
    frame.getContentPane().add(new JLabel("  Height:"));
    heightFeet = new JTextField(2);
    heightFeet.addActionListener(new heightFeetListener());
    frame.getContentPane().add(heightFeet);
    frame.getContentPane().add(new JLabel("ft."));
    heightInch = new JTextField(2);
    heightInch.addActionListener(new heightFeetListener());
    frame.getContentPane().add(heightInch);
    frame.getContentPane().add(new JLabel("in."));
    calculate = new JButton("Calculate Calories");
    calculate.addActionListener(new CalcuListener());
    frame.getContentPane().add(calculate);
    bmi = new JButton("Calculate BMI");
    bmi.addActionListener(new bmiListener());
    frame.getContentPane().add(bmi);
    clear = new JButton("Clear");
    clear.addActionListener(new ClearListener());
    frame.getContentPane().add(clear);
    about = new JButton("About");
    about.addActionListener(new AboutListener());
    frame.getContentPane().add(about);
    message = new JTextArea(6, 28);
    message.setBackground(Color.black);
    message.setForeground(Color.green);
    message.setFont(new Font("Courier", Font.BOLD, 24));
    message.setEditable(false);
    frame.getContentPane().add(message);
    frame.setVisible(true);
  }
 
//Listener for the about button.  This sets the properties for the pop up.
//K!Zemaitis
 
   public class AboutListener implements ActionListener {
    public void actionPerformed(ActionEvent e) {
      JFrame popUp = new JFrame("K. Zemaitis!");
      popUp.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
      popUp.setSize(200,400);
      MyPanel panel = new MyPanel();
      popUp.getContentPane().add(panel);
      popUp.setVisible(true);
    }
 
//This is for my "about" pop up window.  It is a simple design done for... fun?  It shows my name with a graphic I created.
//K!Zemaitis
 
    public class MyPanel extends JPanel {
      public void paintComponent(Graphics g) {
        int width = this.getWidth();
        int height = this.getHeight();
        g.fillRect(0, 0, width, height);
        g.setColor(Color.black);
        g.setColor(Color.red);
        g.fillArc(0, 100, width/1, height/1, 0, 360);
        g.setColor(Color.magenta);
        g.fillArc(0, 150, width/1, height/1, 0, 360);
        g.setColor(Color.yellow);
        g.fillArc(0, 200, width/1, height/1, 0, 360);
        g.setColor(Color.pink);
        g.fillArc(0, 250, width/1, height/1, 0, 360);
        g.setColor(Color.green);
        g.fillArc(0, 300, width/1, height/1, 0, 360);
        g.setColor(Color.white);
        g.setFont(new Font("Courier", Font.BOLD, 18));
        g.drawString("K. Zemaitis!", width/5, height/5);
      }
    }
  }
 
 
  class TimeListener implements ActionListener {
    public void actionPerformed(ActionEvent e) {
    }
  }
  class WeightListener implements ActionListener {
    public void actionPerformed(ActionEvent e) {
    }
  }
  class heightFeetListener implements ActionListener {
    public void actionPerformed(ActionEvent e) {
    }
  }
  class heightInchListener implements ActionListener {
    public void actionPerformed(ActionEvent e) {
    }
  }
//If the clear button is clicked, it removes data from all fields.  This sets the fields to be blank.
//K!Zemaitis
 
  class ClearListener implements ActionListener {
    public void actionPerformed(ActionEvent e) {
      time.setText("");
      weight.setText("");
      message.setText("");
      heightFeet.setText("");
      heightInch.setText("");
      time.requestFocus();
    }
  }
 
 
//When the calculate calories burned button is clicked, it displays the summary which is created later,
// unless invalid data is entered.
//K!Zemaitis
 
  class CalcuListener implements ActionListener {
    public void actionPerformed(ActionEvent e) {
      if (time.getText().length() > 0 && weight.getText().length() > 0) {
      showSummary();
      }
      else {
        message.setText("");
        message.append("\n" + "Invalid input(s).");
 
      }
    }
  }
 
//When the calculate body mass index button is clicked,
//the necessary information is gathered and the bmi is calculated.
//K!Zemaitis
 
  class bmiListener implements ActionListener {
    public void actionPerformed(ActionEvent e) {
    try {
      if (weight.getText().length() > 0 && heightFeet.getText().length() > 0) {
      int qty = Integer.parseInt(weight.getText().trim());
        double bmiWeight = qty * 703;
        double heightFt = Integer.parseInt(heightFeet.getText());
        double heightFeetToInch = heightFt * 12;
        double inches = Integer.parseInt(heightInch.getText());
        double inchTtl = heightFeetToInch + inches;
        double bmiHeight = inchTtl * inchTtl;
        double bmi = bmiWeight / bmiHeight;
      showBmi();
        if (bmi <= 18.5){
        message.append("\n" + "Underweight!");
        }
        if (bmi >= 18.5 && bmi <25){
        message.append("\n" + "Normal!");
        }
        if (bmi >= 25 && bmi <30){
        message.append("\n" + "Overweight!");
        }
        if (bmi >=30){
        message.append("\n" + "Obese!");
        }
 
        }
      else {
        message.setText("");
        message.append("\n" + "Invalid input(s).");
      }
    }
    catch (NumberFormatException err) {
      message.setText("");
      message.append("\n" + "Invalid input(s).");
    }
  }
}
 
//Creates what is seen when the calcuate bmi button is clicked.
//It uses a try-catch block to catch any errors input by the user.
//K!Zemaitis
 
  private void showBmi() {
    message.setText("");
    try {
      int qty = Integer.parseInt(weight.getText().trim());
      if (qty > 0) {
        double bmiWeight = qty * 703;
        double heightFt = Integer.parseInt(heightFeet.getText());
        double heightFeetToInch = heightFt * 12;
        double inches = Integer.parseInt(heightInch.getText());
        double inchTtl = heightFeetToInch + inches;
        double bmiHeight = inchTtl * inchTtl;
        double bmi = bmiWeight / bmiHeight;
        DecimalFormat Decimal = new DecimalFormat("#00.00");
        String bodyMassIndex = Decimal.format(bmi);
 
        message.append(qty + " lbs. " + heightFt + " ft. " + inches + " in. ");
 
        message.append("\n" + "Body Mass Index: " + bodyMassIndex);
      }
      else {
        message.append("\n" + "Invalid input(s).");
      }
    }
    catch (NumberFormatException err) {
      message.append("\n" + "Invalid input(s).");
    }
   }
 
//This creates what is displayed in the message box if the user enters valid or invalid data.  It has a try-catch block
//and it catches the error involving anything but a number in the text fields.  It is for the calculate calories burned button.
//K!Zemaitis.
 
 
  private void showSummary() {
    message.setText("");
    try {
      int qty = Integer.parseInt(time.getText().trim());
      if (qty > 0) {
        double calorie = calories[choice.getSelectedIndex()];
        double weigh = Integer.parseInt(weight.getText());
        double weight = weigh / 150;
        double amount = qty * calorie;
        double last = weight * amount;
 
        message.append(qty + " minute(s) of " + (String)choice.getSelectedValue());
        message.append("\n" + weigh + " lbs.");
 
    message.append("\n" + "Total calories burned: " + amount);//THIS IS WHERE THE PROBLEM IS, I THINK!!!
//IT NEEDS TO GET THE NEW WEIGHT INPUT BY THE USER.
      }
      else {
        message.append("\n" + "Invalid input(s)");
      }
    }
    catch (NumberFormatException err) {
      message.append("\n" + "Invalid input(s).");
    }
  }
}

[ UD: edited to break long lines into two for better formatting ]
[ April 25, 2007: Message edited by: Ulf Dittmer ]

[Ulf Dittmer]

The variable 'amount' (where you indicate the problem is) only depends on the type of exercise and the length, not body weight and height, so it's not surprising that it doesn't change. The value of the weight shown in the line above that should change if the button is clicked, though.

As an aside, what are the ActionListeners supposed to do that are attached to the TextFields? It seems that all actions are handled by the buttons (which is a more intuitive way to do it, too).

Since, there is nothing applet-specific in this question, I'm moving it the AWT/Swing forum.

[ken zemaitis]

Figured it out, nevermind!