X and O game

[James Mousseau]

The logic seems correct to me, but for some reason the program does not want to funtion properly, could you take a look at the program and give me some input, and I have a few variables not used in the program, even though they are defined because this is the part I need done in order to use those variables.

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
import java.io.*;
import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
 
 
 
public class XOXO extends JFrame implements ActionListener
{
 
    JButton box1 = new JButton ("1"); //creating the first X and O field
    JButton box2 = new JButton ("2"); //creating the second X and O field
    JButton box3 = new JButton ("3"); //creating the third X and O field
    JButton box4 = new JButton ("4"); //creating the fourth X and O field
    JButton box5 = new JButton ("5"); //creating the fifth X and O field
    JButton box6 = new JButton ("6"); //creating the sixth X and O field
    JButton box7 = new JButton ("7"); //creating the seventh X and O field
    JButton box8 = new JButton ("8"); //creating the eighth X and O field
    JButton box9 = new JButton ("9"); //creating the ninth X and O field
    JButton Save = new JButton ("Lets Play!!!!!!"); //creating the play game button, which saves the players names and score
    JButton Restart = new JButton ("Restart"); //creating the restart button
    JLabel P1 = new JLabel ("P1 score:"); //label showing player 1's score
    JLabel P2 = new JLabel ("P2 scroe:"); //label showing player 2's score
    JLabel Winner = new JLabel ("Get 3 In a row!!!!!!!!!"); //label which player wins
    JLabel Firstlabel = new JLabel ("First Player (X):       "); //label showing player ones name
    JLabel Secondlabel = new JLabel ("Second Player (O): "); //label showing player two name
    JTextField First = new JTextField ("                                 "); //text where first player enteres name
    JTextField Second = new JTextField ("                                 "); //text where second player enteres name
    JTextField PO = new JTextField ("-       "); //how many games player one won
    JTextField PT = new JTextField ("-       "); //how many games player two won
    //Shall we define variables?
 
    int Count = 0;
    int Counter = 0;
    int Counter2 = 0;
 
 
    public XOXO ()
    {
        //Creating the GUI, setting the size, adding the Labels, Text Fields, button and combo box
        //Creating what the user can choose within the combobox
 
        super ("X's and O's"); //Creating the name of the program
        setSize (400, 175); //Setting the size
        setDefaultCloseOperation (JFrame.EXIT_ON_CLOSE);
        Container pane = getContentPane ();
        FlowLayout flow = new FlowLayout ();
        pane.setLayout (flow);
        box1.addActionListener (this); //Making the buttons in the game performable
        box2.addActionListener (this); //Making the buttons in the game performable
        box3.addActionListener (this); //Making the buttons in the game performable
        box4.addActionListener (this); //Making the buttons in the game performable
        box5.addActionListener (this); //Making the buttons in the game performable
        box6.addActionListener (this); //Making the buttons in the game performable
        box7.addActionListener (this); //Making the buttons in the game performable
        box8.addActionListener (this); //Making the buttons in the game performable
        box9.addActionListener (this); //Making the buttons in the game performable
        Save.addActionListener (this); //Making the buttons in the game performable
        Restart.addActionListener (this); //Making the buttons in the game performable
        box1.setEnabled (false); //making the playing field not touchable until players are ready to play
        box2.setEnabled (false); //making the playing field not touchable until players are ready to play
        box3.setEnabled (false); //making the playing field not touchable until players are ready to play
        box4.setEnabled (false); //making the playing field not touchable until players are ready to play
        box5.setEnabled (false); //making the playing field not touchable until players are ready to play
        box6.setEnabled (false); //making the playing field not touchable until players are ready to play
        box7.setEnabled (false); //making the playing field not touchable until players are ready to play
        box8.setEnabled (false); //making the playing field not touchable until players are ready to play
        box9.setEnabled (false); //making the playing field not touchable until players are ready to play
        pane.add (box1); //adding the first X or O playing field
        pane.add (box2); //adding the second X or O playing field
        pane.add (box3); //adding the third X or O playing field
        pane.add (Firstlabel); //adding the first label asking for first players name
        pane.add (First); //adding the first text field where player enters first players name
        First.setPreferredSize (First.getPreferredSize ());
        pane.add (box4); //adding the fourth X or O playing field
        pane.add (box5); //adding the fifth X or O playing field
        pane.add (box6); //adding the sixth X or O playing field
        pane.add (Secondlabel); //adding the first label asking for second players name
        pane.add (Second); //adding the first text field where player enters second players name
        Second.setPreferredSize (Second.getPreferredSize ());
        pane.add (box7); //adding the seventh X or O playing field
        pane.add (box8); //adding the eighth X or O playing field
        pane.add (box9); //adding the ninth X or O playing field
        pane.add (Save); //adding the play game button
        pane.add (Winner); //adding the label to which shows which player won
        pane.add (P1); //adding the label declaring where the first players score is
        pane.add (PO); //adding the first players score
        pane.add (P2); //adding the label declaring where the second players score is
        pane.add (PT); //adding the second players score
        pane.add (Restart); //adding the restart button
        setContentPane (pane);
        setVisible (true);
    }
 
 
    //\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\
    public static void main (String[] arguments)
    {
        XOXO frame = new XOXO ();
    }
 
 
    public void actionPerformed (ActionEvent evt)
    {
        {
            String PlayerOne = (First.getText ()); //First Player
            String PlayerTwo = (Second.getText ()); //Second Player
 
            if ("Restart".equals (evt.getActionCommand ())) //Restarting the game, re-setting everything
            {
                //adding text to all the buttons to which you can choose your X or O to go
                box1.setText (("1"));
                box2.setText (("2"));
                box3.setText (("3"));
                box4.setText (("4"));
                box5.setText (("5"));
                box6.setText (("6"));
                box7.setText (("7"));
                box8.setText (("8"));
                box9.setText (("9"));
                //Making the boxes unable to click until the "Lets Play" button is pressed
                box1.setEnabled (false);
                box2.setEnabled (false);
                box3.setEnabled (false);
                box4.setEnabled (false);
                box5.setEnabled (false);
                box6.setEnabled (false);
                box7.setEnabled (false);
                box8.setEnabled (false);
                box9.setEnabled (false);
                First.setEnabled (true);
                Second.setEnabled (true);
                int Counter = 0;
                int Counter2 = 0;
 
            }
 
            if ("Lets Play!!!!!!".equals (evt.getActionCommand ())) //When this is clicked, it allows the game to begin
            {
                //The scores are ready to be tally'd
                PO.setText (("  0     "));
                PT.setText (("  0     "));
                //The first and second players names are locked
                First.setEnabled (false);
                Second.setEnabled (false);
                //allows the game to begin
                box1.setEnabled (true);
                box2.setEnabled (true);
                box3.setEnabled (true);
                box4.setEnabled (true);
                box5.setEnabled (true);
                box6.setEnabled (true);
                box7.setEnabled (true);
                box8.setEnabled (true);
                box9.setEnabled (true);
            }
          
            /*This is where the buttons (1-9) are clicked, the box will change
            to either the first players X, or the second players O*/
            int p1turn = 1;
            int p2turn = 2;
            int turn = 0;
 
            if ("1".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box1.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                    
                }
                else 
                {
                    box1.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    
                }
            }
             if ("2".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box2.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box2.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("3".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box3.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box3.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("4".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box4.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                   
                }
                else 
                {
                    box4.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("5".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box5.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                   
                }
                else 
                {
                    box5.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("6".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box6.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box6.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("7".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box7.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box7.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("8".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box8.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box8.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("9".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box9.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box9.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
 
            try
            {
 
                FileOutputStream File1;
                PrintStream p;
                File1 = new FileOutputStream ("Players.txt");
                p = new PrintStream (File1);
                p.println (PlayerOne + ", " + PlayerTwo);
                p.close ();
 
            }
 
 
            catch (Exception e)
            {
                //An Error message
                System.out.println ("Error writing to file!");
            }
        }
    }
}

I would really appreciate the help on this one, its been bugging me for a few days now.
[ June 05, 2008: Message edited by: James Mousseau ]

[Rob Spoor]

What does it not do properly?

[James Mousseau]

Through all the if statements, it should output an X first, then an O, but for some reason, its ONLY outputting X's through all the buttons (1-9), I added a system.out.print in there for the p1turn and p2turn, and p1turn seems to always add 2 to it, and stay at the value 3, but p2turn stays at 2, as if the p1turn = p1turn + 2, and the p2turn = p2turn + 2 dont seem to count, only counts once and to p1turn.

The program pretty much runs as its supposed to until it gets to:

    
            /*This is where the buttons (1-9) are clicked, the box will change
            to either the first players X, or the second players O*/
            int p1turn = 1;
            int p2turn = 2;
            int turn = 0;
 
            if ("1".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box1.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                    
                }
                else 
                {
                    box1.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    
                }
            }
             if ("2".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box2.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box2.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("3".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box3.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box3.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("4".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box4.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                   
                }
                else 
                {
                    box4.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("5".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box5.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                   
                }
                else 
                {
                    box5.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("6".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box6.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box6.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("7".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box7.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box7.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("8".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box8.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box8.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
             if ("9".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box9.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    
                }
                else 
                {
                    box9.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }

I was just wondering if there is anything there I cant seem to notice, like brackets, where the "counter" (p1turn, p2turn) is placed.

And Id like to thank you guys for helping me out, im learning more and more everyday

[Ernest Friedman-Hill]

In your program p1Turn, p2Turn, and turn are local variables declared in the actionPerformed() method. That means each time actionPerformed is called -- i.e., each time a button is pressed -- these variables are all recreated from scratch, and initialized to 1, 2, and 0, respectively. If you want those variables to persist between calls to this method -- and you do, since they represent the state of the game -- then they should be declared at class level, outside of any method. Then they are called instance variables, and they're initialized just once when an instance of your class is created.

Make sense?

[James Mousseau]

kind of, I now know that their placement is off, and that makes sence since it seems to repeat the step of adding 2 to p1turn, and it always gets resetted and repeating step 1, Ill try that out...

I think you saved me hours of struggle

Thanks a bunch!

EDIT:

It works like a charm!!!
[ June 06, 2008: Message edited by: James Mousseau ]