Buttons...

[James Mousseau]

How can you say "If this button is clicked, and this button is clicked, and this button is clicked, Do this"

The thing is They have to be clicked within a certain order.

if (("X".equals (box1))&& ("X".equals (box2)) && ("X".equals (box3)))

        if (("X".equals (box1))&& ("X".equals (box2)) && ("X".equals (box3)))
            {
                Winner = new JLabel ("Player One is the Winner!!");
                box1.setEnabled (true);
                box2.setEnabled (true);
                box3.setEnabled (true);
                box4.setEnabled (false);
                box5.setEnabled (false);
                box6.setEnabled (false);
                box7.setEnabled (false);
                box8.setEnabled (false);
                box9.setEnabled (false);
                p1s = p1s + 1;
                
                score1 = "p1s";
                PO.setText ((score1));
                
                }

winner is a Jlabel; box1 - box9 are buttons; p1s = int; PO = TextField; score1 is a string.
and Im unsure on how to get the int p1s to convert it to a string so it can be outputted in the PO textbox.

I would really appreciate the help

[Gregg Bolinger]

So clicking things in Swing just causes events to happen. There is no special rhyme or reason, they just register events. So if you need to keep track of what was clicked in what order that is up to you to keep track of. Think data structure, not GUI.

As far as int to String look at the String API.

String.valueOf(int)

[James Mousseau]

I have the code entered when something is clicked, do this, but I cant seem to find out how to make it if 3 of them are clicked and marked as something, then do this.

I can upload all of the code, but it doesn't seem necessary. I cant seem to find the logic in saying if 3 of the 9 buttons are the same output ("X"), then do something else.

[Gregg Bolinger]

Saying that 3 of the buttons are the same output makes no sense. Sounds to me like you need to keep a multidimensional array that corresponds to your button matrix. I'm just guessing because you really haven't given any context to your problem. I'm assuming this is some sort of game from your Winner label.

You could also query your button container for all of its components, loop through them, and get the text or name of the button (whichever you are changing) but I'd go for the data structure approach and just update it then query it on each button click event.

[James Mousseau]

Yes sir, it is a game.

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
import java.io.*;
import java.awt.event.MouseAdapter;
import java.awt.event.MouseEvent;
 
 
 
public class XOXO extends JFrame implements ActionListener
{
 
    JButton box1 = new JButton ("1"); //creating the first X and O field
    JButton box2 = new JButton ("2"); //creating the second X and O field
    JButton box3 = new JButton ("3"); //creating the third X and O field
    JButton box4 = new JButton ("4"); //creating the fourth X and O field
    JButton box5 = new JButton ("5"); //creating the fifth X and O field
    JButton box6 = new JButton ("6"); //creating the sixth X and O field
    JButton box7 = new JButton ("7"); //creating the seventh X and O field
    JButton box8 = new JButton ("8"); //creating the eighth X and O field
    JButton box9 = new JButton ("9"); //creating the ninth X and O field
    JButton Save = new JButton ("Lets Play!!!!!!"); //creating the play game button, which saves the players names and score
    JButton Restart = new JButton ("Restart"); //creating the restart button
    JLabel P1 = new JLabel ("P1 score:"); //label showing player 1's score
    JLabel P2 = new JLabel ("P2 scroe:"); //label showing player 2's score
    JLabel Winner = new JLabel ("Get 3 In a row!!!!!!!!!"); //label which player wins
    JLabel Firstlabel = new JLabel ("First Player (X):       "); //label showing player ones name
    JLabel Secondlabel = new JLabel ("Second Player (O): "); //label showing player two name
    JTextField First = new JTextField ("                                 "); //text where first player enteres name
    JTextField Second = new JTextField ("                                 "); //text where second player enteres name
    JTextField PO = new JTextField ("--------"); //how many games player one won
    JTextField PT = new JTextField ("--------"); //how many games player two won
    //Shall we define variables?
 
    int Count = 0;
    int Counter = 0;
    int Counter2 = 0;
    int p1turn = 1;
    int p2turn = 2;
    int turn = 0;
    int p1s = 0;
    int p2s = 0;
    String score1;
    
 
 
    public XOXO ()
    {
        //Creating the GUI, setting the size, adding the Labels, Text Fields, button and combo box
        //Creating what the user can choose within the combobox
 
        super ("X's and O's"); //Creating the name of the program
        setSize (400, 175); //Setting the size
        setDefaultCloseOperation (JFrame.EXIT_ON_CLOSE);
        Container pane = getContentPane ();
        FlowLayout flow = new FlowLayout ();
        pane.setLayout (flow);
        box1.addActionListener (this); //Making the buttons in the game performable
        box2.addActionListener (this); //Making the buttons in the game performable
        box3.addActionListener (this); //Making the buttons in the game performable
        box4.addActionListener (this); //Making the buttons in the game performable
        box5.addActionListener (this); //Making the buttons in the game performable
        box6.addActionListener (this); //Making the buttons in the game performable
        box7.addActionListener (this); //Making the buttons in the game performable
        box8.addActionListener (this); //Making the buttons in the game performable
        box9.addActionListener (this); //Making the buttons in the game performable
        Save.addActionListener (this); //Making the buttons in the game performable
        Restart.addActionListener (this); //Making the buttons in the game performable
        box1.setEnabled (false); //making the playing field not touchable until players are ready to play
        box2.setEnabled (false); //making the playing field not touchable until players are ready to play
        box3.setEnabled (false); //making the playing field not touchable until players are ready to play
        box4.setEnabled (false); //making the playing field not touchable until players are ready to play
        box5.setEnabled (false); //making the playing field not touchable until players are ready to play
        box6.setEnabled (false); //making the playing field not touchable until players are ready to play
        box7.setEnabled (false); //making the playing field not touchable until players are ready to play
        box8.setEnabled (false); //making the playing field not touchable until players are ready to play
        box9.setEnabled (false); //making the playing field not touchable until players are ready to play
        pane.add (box1); //adding the first X or O playing field
        pane.add (box2); //adding the second X or O playing field
        pane.add (box3); //adding the third X or O playing field
        pane.add (Firstlabel); //adding the first label asking for first players name
        pane.add (First); //adding the first text field where player enters first players name
        First.setPreferredSize (First.getPreferredSize ());
        pane.add (box4); //adding the fourth X or O playing field
        pane.add (box5); //adding the fifth X or O playing field
        pane.add (box6); //adding the sixth X or O playing field
        pane.add (Secondlabel); //adding the first label asking for second players name
        pane.add (Second); //adding the first text field where player enters second players name
        Second.setPreferredSize (Second.getPreferredSize ());
        pane.add (box7); //adding the seventh X or O playing field
        pane.add (box8); //adding the eighth X or O playing field
        pane.add (box9); //adding the ninth X or O playing field
        pane.add (Save); //adding the play game button
        pane.add (Winner); //adding the label to which shows which player won
        pane.add (P1); //adding the label declaring where the first players score is
        pane.add (PO); //adding the first players score
        pane.add (P2); //adding the label declaring where the second players score is
        pane.add (PT); //adding the second players score
        pane.add (Restart); //adding the restart button
        setContentPane (pane);
        setVisible (true);
     
    }
 
 
    //\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//\\//
    public static void main (String[] arguments)
    {
        XOXO frame = new XOXO ();
    }
 
 
    public void actionPerformed (ActionEvent evt)
    {
        {
            String PlayerOne = (First.getText ()); //First Player
            String PlayerTwo = (Second.getText ()); //Second Player
 
            if ("Restart".equals (evt.getActionCommand ())) //Restarting the game, re-setting everything
            {
                //adding text to all the buttons to which you can choose your X or O to go
                box1.setText (("1"));
                box2.setText (("2"));
                box3.setText (("3"));
                box4.setText (("4"));
                box5.setText (("5"));
                box6.setText (("6"));
                box7.setText (("7"));
                box8.setText (("8"));
                box9.setText (("9"));
                //Making the boxes unable to click until the "Lets Play" button is pressed
                box1.setEnabled (false);
                box2.setEnabled (false);
                box3.setEnabled (false);
                box4.setEnabled (false);
                box5.setEnabled (false);
                box6.setEnabled (false);
                box7.setEnabled (false);
                box8.setEnabled (false);
                box9.setEnabled (false);
                First.setEnabled (true);
                Second.setEnabled (true);
                p1turn = 1;
                p2turn = 2;
                int Counter = 0;
                int Counter2 = 0;
 
 
            }
 
            if ("Lets Play!!!!!!".equals (evt.getActionCommand ())) //When this is clicked, it allows the game to begin
            {
                //The scores are ready to be tally'd
                PO.setText ((" 0 "));
                PT.setText ((" 0 "));
               
                //The first and second players names are locked
                First.setEnabled (false);
                Second.setEnabled (false);
                //allows the game to begin
                box1.setEnabled (true);
                box2.setEnabled (true);
                box3.setEnabled (true);
                box4.setEnabled (true);
                box5.setEnabled (true);
                box6.setEnabled (true);
                box7.setEnabled (true);
                box8.setEnabled (true);
                box9.setEnabled (true);
            }
 
            /*This is where the buttons (1-9) are clicked, the box will change
            to either the first players X, or the second players O*/
 
 
            if ("1".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box1.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
 
 
                }
                else
                {
                    box1.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
 
                }
            }
            if ("2".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box2.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
 
                }
                else
                {
                    box2.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
            if ("3".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box3.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
 
                }
                else
                {
                    box3.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
            if ("4".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box4.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
 
                }
                else
                {
                    box4.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
            if ("5".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box5.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
 
                }
                else
                {
                    box5.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
            if ("6".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box6.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
 
                }
                else
                {
                    box6.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
            if ("7".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box7.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
 
                }
                else
                {
                    box7.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
            if ("8".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box8.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
 
                }
                else
                {
                    box8.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
            if ("9".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box9.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
 
                }
                else
                {
                    box9.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                }
            }
                 if (("X".equals (box1))&& ("X".equals (box2)) && ("X".equals (box3)))
            {
                box1.setEnabled (true);
                box2.setEnabled (true);
                box3.setEnabled (true);
                box4.setEnabled (false);
                box5.setEnabled (false);
                box6.setEnabled (false);
                box7.setEnabled (false);
                box8.setEnabled (false);
                box9.setEnabled (false);
                p1s = p1s + 1;
                String.valueOf(p1s);
                score1 = "p1s";
                PO.setText ((score1));
                }
                try
                {
 
                    FileOutputStream File1;
                    PrintStream p;
                    File1 = new FileOutputStream ("Players.txt");
                    p = new PrintStream (File1);
                    p.println (PlayerOne + ", " + PlayerTwo);
                    p.close ();
 
                }
 
 
                catch (Exception e)
                {
                    //An Error message
                    System.out.println ("Error writing to file");
                }
            }
        }
    }
 

I programmed this code looking at stuff on the internet, kinda new, but I have some knowledge of programming, just not much. its the mathematics left in the program that I must finish, and it doesnt seem to want to work out for me.

And I really appreciate you taking time to review this for me.
[ June 11, 2008: Message edited by: Ulf Dittmer ]

[Gregg Bolinger]

Ok, so here is what I would do. At least something like this.

Create a matrix to hold your x's and o's

char matrix[][] = new char[3][3];

When a button is clicked determine which position in the matrix to update:

matrix[2][1] = "X";

After which, you check the rows, cols, and diags:

// rows
for (int i = 0; i < 3; i++) {
   if(matrix[i][0]==matrix[i][1] &&  matrix[i][0]==matrix[i][2]) {
      // do something because you have a winner
   } 
}
 
// cols
for (int i = 0; i < 3; i++) {
   if(matrix[0][i]==matrix[1][i] &&  matrix[i][0]==matrix[2][i]) {
      // do something because you have a winner
   } 
}
 
// diags
if(matrix[0][0]==matrix[1][1] && matrix[1][1]==matrix[2][2]) {
   // do something because you have a winner
}
 
if(matrix[0][2]==matrix[1][1] && matrix[1][1]==matrix[2][0]) {
   // do something because you have a winner
}

[James Mousseau]

Originally posted by Gregg Bolinger:
Ok, so here is what I would do. At least something like this.

Create a matrix to hold your x's and o's

char matrix[][] = new char[3][3];

When a button is clicked determine which position in the matrix to update:

matrix[2][1] = "X";

After which, you check the rows, cols, and diags:

// rows
for (int i = 0; i < 3; i++) {
   if(matrix[i][0]==matrix[i][1] &&  matrix[i][0]==matrix[i][2]) {
      // do something because you have a winner
   } 
}
 
// cols
for (int i = 0; i < 3; i++) {
   if(matrix[0][i]==matrix[1][i] &&  matrix[i][0]==matrix[2][i]) {
      // do something because you have a winner
   } 
}
 
// diags
if(matrix[0][0]==matrix[1][1] && matrix[1][1]==matrix[2][2]) {
   // do something because you have a winner
}
 
if(matrix[0][2]==matrix[1][1] && matrix[1][1]==matrix[2][0]) {
   // do something because you have a winner
}

This is extremely helpful, but the thing I dont get is "char matrix[][] = new char[3][3];"

When you have the [3][3], what does that mean, im a little unsure of this, is that basically saying 3X3? And for the rows, columns, and diagonals, how does that register 3 across, up and down, and top side to bottom opposite?

And before you go any further, I would really like to thank you and the site for being so helpful, I really appreciate all the help you and the JavaRanch community has done for me.

[Gregg Bolinger]

This is extremely helpful, but the thing I dont get is "char matrix[][] = new char[3][3];"

This is a multidimensional array. Some might call it a matrix. Visually it would look something like this assuming a complete game where X's won.

   0   1   2
 
0  X   O   O
 
1  X   O   X
 
2  X       O

Your winning combination is this

matrix[0][0]
matrix[0][1]
matrix[0][2]

If you follow the cols for loop through it would find this for you. Here is another.

   0   1   2
 
0  O   O   X
 
1  X   X   X
 
2  O       O

matrix[0][1]
matrix[1][1]
matrix[2][1]

Note that arrays start at 0 so an array of length 3 goes from 0,1,2. Does that help?

[James Mousseau]

Makes perfect sense, thanks again.

[James Mousseau]

Tricky situation, it does not seem to want to work for me...

Error sais that "The type of the right sub-expression "java.lang.String", is not assignable to the variable, of type "char""

So I was wondering if I wrote it wrong, because I cant seem to figure out on where to assign the char to the clicks of X's and O's otherwise.

 if ("1".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box1.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix[0][0] = "X";
 
                }
                else
                {
                    box1.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix[0][0] = "O";
 
                }
            }
            if ("2".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box2.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix[1][0] = "X";
                }
                else
                {
                    box2.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix[1][0] = "O";
                }
            }
            if ("3".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box3.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix[2][0] = "X";
                }
                else
                {
                    box3.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix[2][0] = "O";
                }
            }
            if ("4".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box4.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix[0][1] = "X";
                }
                else
                {
                    box4.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix[0][1] = "O";
                }
            }
            if ("5".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box5.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix[1][1] = "X";
                }
                else
                {
                    box5.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix[1][1] = "O";
                }
            }
            if ("6".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box6.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix[2][1] = "X";
                }
                else
                {
                    box6.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix[2][1] = "O";
                }
            }
            if ("7".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box7.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix[0][2] = "X";
                }
                else
                {
                    box7.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix[0][2] = "O";
                }
            }
            if ("8".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box8.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix[1][2] = "X";
                }
                else
                {
                    box8.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix[1][2] = ")";
                }
            }
            if ("9".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box9.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix[2][2] = "X";
                }
                else
                {
                    box9.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix[2][2] = "O";
                }
                 
                // rows
                for (int i = 0 ; i < 3 ; i++)
                {
                    if (matrix [i] [0] == matrix [i] [1] && matrix [i] [0] == matrix [i] [2])
                    {
                        Winner.setText ("Player One Wins!!!!");
                        p1s = p1s + 1;
                        score1 = "p1s";
                        PO.setText ((score1));
                    }
                }
                // cols
                for (int i = 0 ; i < 3 ; i++)
                {
                    if (matrix [0] [i] == matrix [1] [i] && matrix [i] [0] == matrix [2] [i])
                    {
                        Winner.setText ("Player One Wins!!!!");
 

 
                        p1s = p1s + 1;
 
                        score1 = "p1s";
                        PO.setText ((score1));
                    }
                }
                // diags
                if (matrix [0] [0] == matrix [1] [1] && matrix [1] [1] == matrix [2] [2])
                {
                    Winner.setText ("Player One Wins!!!!");
 

 
                    p1s = p1s + 1;
 
                    score1 = "p1s";
                    PO.setText ((score1));
                }
                if (matrix [0] [2] == matrix [1] [1] && matrix [1] [1] == matrix [2] [0])
                {
                    Winner.setText ("Player One Wins!!!!");
 

 
                    p1s = p1s + 1;
 
                    score1 = "p1s";
                    PO.setText ((score1));
                }
            }
 

[Gregg Bolinger]

I Think I might a syntax mistake. Try doing it like this:

matrix[4][3] = 'X';

Notice the single quotes rather than double quotes. char vs String.

[James Mousseau]

Well, it seems to work now, but its the same problem. It only switches up in box9

EDIT:
Could it be the placement on where the cols/rows/diags are placed, what if they are placed in lets say the code where box1 code is for X or O?

Or if it should be placed inside a bracket differently...

Im about ready to get the hammer!
[ June 10, 2008: Message edited by: James Mousseau ]

[Gregg Bolinger]

Well, I assumed there were some holes in my implementation and I thought I'd give you a chance to find them. But you've been struggling along pretty good now so I whipped up very simple version of your app. This version is basically what I'd come up with if I had 15 minutes to get it done. So take it as exactly that and probably not something you'd want to wind up with as final quality. But it does work.

import javax.swing.*;
import java.awt.*;
import java.awt.event.ActionListener;
import java.awt.event.ActionEvent;
 
/**
 * Author: Gregg Bolinger
 * <p/>
 */
public class TicTacToe extends JFrame {
 
  char matrix[][] = new char[3][3];
  private final static char X = 'X';
  private final static char O = 'O';
  private char play = X;
 
  public TicTacToe() {
    super("Tic Tac Toe");
 
    setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
 
    setLayout(new GridLayout(3, 3));
    initMatrix();
 
    final JButton zeroZero = new JButton(" ");
    zeroZero.addActionListener(new ActionListener() {
      public void actionPerformed(ActionEvent e) {
        makePlay(0, 0, zeroZero);
      }
    });
    add(zeroZero);
 
    final JButton zeroOne = new JButton(" ");
    zeroOne.addActionListener(new ActionListener() {
      public void actionPerformed(ActionEvent e) {
        makePlay(0, 1, zeroOne);
      }
    });
    add(zeroOne);
 
    final JButton zeroTwo = new JButton(" ");
    zeroTwo.addActionListener(new ActionListener() {
      public void actionPerformed(ActionEvent e) {
        makePlay(0, 2, zeroTwo);
      }
    });
    add(zeroTwo);
 
    final JButton oneZero = new JButton(" ");
    oneZero.addActionListener(new ActionListener() {
      public void actionPerformed(ActionEvent e) {
        makePlay(1, 0, oneZero);
      }
    });
    add(oneZero);
 
    final JButton oneOne = new JButton(" ");
    oneOne.addActionListener(new ActionListener() {
      public void actionPerformed(ActionEvent e) {
        makePlay(1, 1, oneOne);
      }
    });
    add(oneOne);
 

    final JButton oneTwo = new JButton(" ");
    oneTwo.addActionListener(new ActionListener() {
      public void actionPerformed(ActionEvent e) {
        makePlay(1, 2, oneTwo);
      }
    });
    add(oneTwo);
 
    final JButton twoZero = new JButton(" ");
    twoZero.addActionListener(new ActionListener() {
      public void actionPerformed(ActionEvent e) {
        makePlay(2, 0, twoZero);
      }
    });
    add(twoZero);
 

    final JButton twoOne = new JButton(" ");
    twoOne.addActionListener(new ActionListener() {
      public void actionPerformed(ActionEvent e) {
        makePlay(2, 1, twoOne);
      }
    });
    add(twoOne);
 
    final JButton twoTwo = new JButton(" ");
    twoTwo.addActionListener(new ActionListener() {
      public void actionPerformed(ActionEvent e) {
        makePlay(2, 2, twoTwo);
      }
    });
    add(twoTwo);
 
    pack();
    setSize(400, 400);
    setVisible(true);
 
  }
 
  private void makePlay(int row, int col, JButton button) {
    matrix[row][col] = play;
    button.setText(String.valueOf(play));
    if (play == X) {
      play = O;
    } else {
      play = X;
    }
 
    checkForWinner();
  }
 
  private void initMatrix() {
    for (int row = 0; row < 3; row++) {
      for (int col = 0; col < 3; col++) {
        matrix[row][col] = ' ';
      }
    }
  }
 
  private void checkForWinner() {
 
    // rows
    for (int i = 0; i < 3; i++) {
      if (matrix[i][0] == matrix[i][1] && matrix[i][0] == matrix[i][2] && matrix[i][0] != ' ') {
        System.out.println("Row Winner: " + matrix[i][0]);
      }
    }
 
    // cols
    for (int i = 0; i < 3; i++) {
      if (matrix[0][i] == matrix[1][i] && matrix[i][0] == matrix[2][i] && matrix[0][i] != ' ') {
        System.out.println("Col Winner: " + matrix[0][i]);
      }
    }
 
    // diags
    if (matrix[0][0] == matrix[1][1] && matrix[1][1] == matrix[2][2] && matrix[0][0] != ' ') {
      System.out.println("Diag Winner: " + matrix[0][0]);
    }
 
    if (matrix[0][2] == matrix[1][1] && matrix[1][1] == matrix[2][0] && matrix[0][2] != ' ') {
      System.out.println("Diag Winner: " + matrix[0][2]);
    }
 
  }
 
  public static void main(String[] args) {
    new TicTacToe();
  }
}

[James Mousseau]

Im not too sure where you program, but It didnt seem to want to run in "Ready To Program", which is what I use.

Couldnt see it run, so im still a little bit confused on the mathematics...

I tried piecing a bit of your code in for the mathematics in the private void, and it still wouldnt work properly, it would output the winner, even though the winner didnt win.

I do appreciate the help, I was just wondering with my code if you see a slight difference from yours, because mixing two different program styles usually doesnt work. Yours involves more complexity, compared to my basic coding. (eg, I have it rigged up so if you expand the program it wont look anything like X and O game, you have to keep it as it lies)

Im looking at your code, and I seen some things that I havent "understood" yet.

Im still continuing to fool around with it, but it seems to always get worse... and Im not too sure on why...

   public void actionPerformed (ActionEvent evt)
    {
        {
            String PlayerOne = (First.getText ()); //First Player
            String PlayerTwo = (Second.getText ()); //Second Player
 
            if ("Restart".equals (evt.getActionCommand ())) //Restarting the game, re-setting everything
            {
                //adding text to all the buttons to which you can choose your X or O to go
                box1.setText (("1"));
                box2.setText (("2"));
                box3.setText (("3"));
                box4.setText (("4"));
                box5.setText (("5"));
                box6.setText (("6"));
                box7.setText (("7"));
                box8.setText (("8"));
                box9.setText (("9"));
                //Making the boxes unable to click until the "Lets Play" button is pressed
                box1.setEnabled (false);
                box2.setEnabled (false);
                box3.setEnabled (false);
                box4.setEnabled (false);
                box5.setEnabled (false);
                box6.setEnabled (false);
                box7.setEnabled (false);
                box8.setEnabled (false);
                box9.setEnabled (false);
                First.setEnabled (true);
                Second.setEnabled (true);
                p1turn = 1;
                p2turn = 2;
                int Counter = 0;
                int Counter2 = 0;
                int i = 0;
 
 
            }
 
            if ("Lets Play!!!!!!".equals (evt.getActionCommand ())) //When this is clicked, it allows the game to begin
            {
                //The scores are ready to be tally'd
                PO.setText ((" 0 "));
                PT.setText ((" 0 "));
 
                //The first and second players names are locked
                First.setEnabled (false);
                Second.setEnabled (false);
                //allows the game to begin
                box1.setEnabled (true);
                box2.setEnabled (true);
                box3.setEnabled (true);
                box4.setEnabled (true);
                box5.setEnabled (true);
                box6.setEnabled (true);
                box7.setEnabled (true);
                box8.setEnabled (true);
                box9.setEnabled (true);
            }
 
            /*This is where the buttons (1-9) are clicked, the box will change
            to either the first players X, or the second players O*/
 
 
            if ("1".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box1.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix [0] [0] = 'X';
 
                }
                else
                {
                    box1.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix [0] [0] = 'O';
 
                }
            }
            if ("2".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box2.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix [1] [0] = 'X';
                }
                else
                {
                    box2.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix [1] [0] = 'O';
                }
            }
            if ("3".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box3.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix [2] [0] = 'X';
                }
                else
                {
                    box3.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix [2] [0] = 'O';
                }
            }
            if ("4".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box4.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix [0] [1] = 'X';
                }
                else
                {
                    box4.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix [0] [1] = 'O';
                }
            }
            if ("5".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box5.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix [1] [1] = 'X';
                }
                else
                {
                    box5.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix [1] [1] = 'O';
                }
            }
            if ("6".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box6.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix [2] [1] = 'X';
                }
                else
                {
                    box6.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix [2] [1] = 'O';
                }
            }
            if ("7".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box7.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix [0] [2] = 'X';
                }
                else
                {
                    box7.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix [0] [2] = 'O';
                }
            }
            if ("8".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box8.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix [1] [2] = 'X';
                }
                else
                {
                    box8.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix [1] [2] = 'O';
                }
            }
            if ("9".equals (evt.getActionCommand ())) //If box one is clicked
            {
                if (p1turn < p2turn)
                {
                    box9.setText (("X")); //set the box to X
                    p1turn = p1turn + 2; //Add two to the players turn, so the players turn will be more than the other players turn
                    matrix [2] [2] = 'X';
                }
                else
                {
                    box9.setText (("O")); //set the box to X
                    p2turn = p2turn + 2;
                    matrix [2] [2] = 'O';
                }
            }
        }
        { // rows
            for (int i = 0 ; i < 3 ; i++)
            {
                if (matrix [i] [0] == matrix [i] [1] && matrix [i] [0] == matrix [i] [2] && matrix [i] [0] != ' ')
                {
 
                    Winner.setText ("Winner!!!!!!!!!!!!!!!!!!!!!");
                    box1.setEnabled (false);
                    box2.setEnabled (false);
                    box3.setEnabled (false);
                    box4.setEnabled (false);
                    box5.setEnabled (false);
                    box6.setEnabled (false);
                    box7.setEnabled (false);
                    box8.setEnabled (false);
                    box9.setEnabled (false);
                }
            } // cols
 
 
            for (int i = 0 ; i < 3 ; i++)
            {
                if (matrix [0] [i] == matrix [1] [i] && matrix [i] [0] == matrix [2] [i] && matrix [0] [i] != ' ')
                {
                    Winner.setText ("Winner!!!!!!!!!!!!!!!!!!!!!");
                    box1.setEnabled (false);
                    box2.setEnabled (false);
                    box3.setEnabled (false);
                    box4.setEnabled (false);
                    box5.setEnabled (false);
                    box6.setEnabled (false);
                    box7.setEnabled (false);
                    box8.setEnabled (false);
                    box9.setEnabled (false);
                }
 
            } // diags
 
            {
 
 
                if (matrix [0] [0] == matrix [1] [1] && matrix [1] [1] == matrix [2] [2] && matrix [0] [0] != ' ')
                {
                    Winner.setText ("Winner!!!!!!!!!!!!!!!!!!!!!");
                    box1.setEnabled (false);
                    box2.setEnabled (false);
                    box3.setEnabled (false);
                    box4.setEnabled (false);
                    box5.setEnabled (false);
                    box6.setEnabled (false);
                    box7.setEnabled (false);
                    box8.setEnabled (false);
                    box9.setEnabled (false);
                }
 
 
 
                if (matrix [0] [2] == matrix [1] [1] && matrix [1] [1] == matrix [2] [0] && matrix [0] [2] != ' ')
                {
                    Winner.setText ("Winner!!!!!!!!!!!!!!!!!!!!!");
                    box1.setEnabled (false);
                    box2.setEnabled (false);
                    box3.setEnabled (false);
                    box4.setEnabled (false);
                    box5.setEnabled (false);
                    box6.setEnabled (false);
                    box7.setEnabled (false);
                    box8.setEnabled (false);
                    box9.setEnabled (false);
                }
 
            }
 
            /*
            if (box1.setText = "X" && box2.setText ("X") && box3.setText ("X"))
            {
                Winner.setText ("X Wins!!!!!!!!!!!!!!!!!!!!");
            }
            else
            {
                Winner.setText ("Get 3 In a row!!!!!!!!!");
            }
            */
            try
            {
 
                FileOutputStream File1;
                PrintStream p;
                File1 = new FileOutputStream ("Players.txt");
                p = new PrintStream (File1);
                p.println (PlayerOne + ", " + PlayerTwo);
                p.close ();
 
            }
 
 
            catch (Exception e)
            {
                //An Error message
                System.out.println ("Error writing to file");
            }
        }
    }
}

The thing I dont understand is could the problem be because of the placement of brackets? or the fact that I need more of something (missing something)?

Thats all the buttons, all the commands on the math, and functioning of the program from where I am now (not many changes, but some).

Hopefully a thank you in advance


EDIT:
And I was wondering if this could be an alternate ending to this massacre:

if (box1.setText = "X" && box2.setText ("X") && box3.setText("X"))            
{                
Winner.setText ("X Wins!!!!!!!!!!!!!!!!!!!!");            
}            
else            
{                
Winner.setText ("Get 3 In a row!!!!!!!!!");            
}            

But the thing is I get an error saying its not boolean or something for the line "if (box1.setText = "X" && box2.setText ("X") && box3.setText("X"))"
Is there a way to set it up that way, or is it undoable?
[ June 11, 2008: Message edited by: James Mousseau ]

[Gregg Bolinger]

Im not too sure where you program, but It didnt seem to want to run in "Ready To Program", which is what I use.

I'm not sure what that means.

or the fact that I need more of something (missing something)?

Did you initialize your matrix with ' ' values?

  private void initMatrix() {
    for (int row = 0; row < 3; row++) {
      for (int col = 0; col < 3; col++) {
        matrix[row][col] = ' ';
      }
    }
  }

If you didn't then your if() block will never evaluate to true since you are checking for matrix[][] == ' '. Last night I realized that without a 3rd value (other than X and O) a row could appear to be a winner even though nothing was selected because as the loop runs through and checks each row/col/diag it will see that unselected box's are the same value. So you have to check for the same X or O as well as not being your default 3rd value. In my case I chose a space character.

[James Mousseau]

I just added that in, same problem, but didnt add the void part

I was wondering if this would make the difference

{    
matrix[row][col] = play;    
button.setText(String.valueOf(play));    
if (play == X) 
{      
play = O;    
} else 
{      
play = X;    
}

and I see you set play as char, so would that make a difference? or no?

[Gregg Bolinger]

But the thing is I get an error saying its not boolean or something for the line "if (box1.setText = "X" && box2.setText ("X") && box3.setText("X"))"
Is there a way to set it up that way, or is it undoable?

I'm really not even sure what you are trying to do there. conditional blocks like if() check for true|false. The way to test for equality in Java is usually ==, .equals(), or .comparesTo(), depending on the type of data you are comparing.

== is used for primitives primarily so

if (2 == 2) // int
if ('a' == 'a') // char

.equals is used to check Objects so

if (Player1.equals(Player2))
if ("X".equals("X"))

You can also use .compareTo() to compare Strings

if ("X".compareTo("X") == 0) // returns non zero if false.

[James Mousseau]

if (box1.setText = "X" && box2.setText ("X") && box3.setText("X"))            {
    Winner.setText ("X Wins!!!!!!!!!!!!!!!!!!!!");
} else {
    Winner.setText ("Get 3 In a row!!!!!!!!!");
}

What im trying to say is:

If box1's text is "X", and box2's text is "X", and box3's text is "X"

then output X Wins in a label,

else
leave it at Get 3 in a row.

Because my code sends the text to the buttons on X or O, so if there is 3 in a row that way, then output a winner.

If that makes sense, and I noticed you typed different methods on doing that possibly, which one would I like to use in this sort of format
[ June 11, 2008: Message edited by: Ulf Dittmer ]

[Gregg Bolinger]

if (box1.getText().equals("X") && box2.getText().equals("X") && box3.getText().equals("X")) {
   Winner.setText("X Wins!!!!!!!!!!!!!!!!!!!!!");
}

[Ted Smyth]

Originally posted by James Mousseau:

And I was wondering if this could be an alternate ending to this massacre:

if (box1.setText = "X" && box2.setText ("X") && box3.setText("X"))            
{                
Winner.setText ("X Wins!!!!!!!!!!!!!!!!!!!!");            
}            
else            
{                
Winner.setText ("Get 3 In a row!!!!!!!!!");            
}            

But the thing is I get an error saying its not boolean or something for the line "if (box1.setText = "X" && box2.setText ("X") && box3.setText("X"))"
Is there a way to set it up that way, or is it undoable?

[ June 11, 2008: Message edited by: James Mousseau ]

box1.setText = "X"

Not sure if you fixed this yet, but setText is a method, so you need to add brackets: box1.setText("Some Text"); which sets the text in the box. The method you're looking for is getText() which returns the value of the box's text: box1.getText().equals("X");

The expression

box2.setText ("X")

does not return a boolean value. That's why the compiler complains about it. IF statements must always evaluate to true or false (boolean values). A logical compare: if (someVariable.equals(someotherVariable)) will return true or false, satisfying the requirements of an IF statement.

Also: you can't compare Strings using the == operator, unless they are two references to the same String variable. Use the equals("") method to compare Strings properly (it compares the content of the Strings, where == compares the memory addresses of the two String variables).

So what you want is:

if (box1.getText().equals("X") && box2.getText().equals("X") && box3.getText().equals("X"))            
{                
Winner.setText ("X Wins!!!!!!!!!!!!!!!!!!!!");            
}            
else            
{                
Winner.setText ("Get 3 In a row!!!!!!!!!");            
}   

This way, you are comparing the text content of the boxes with the logical string "X", instead of comparing void (which is what setText("") returns) with the address of a variable you created on the fly, which has the value "X".

... a bit long-winded, but I hope it helps clear up a few conceptual problems with your code.

[James Mousseau]

I Honestly think that solved my whole problem.

It works for box1,2, and 3!

I honestly dont know how to thank you gregg.

Ill try to finish up the program, dont think with that information there, its smooth sailing

Thanks again!


EDIT:

And yes, it did clear it up Ed, Much appreciated for all the help I recieved since I joined.

Ill try to give back to the community in a few years when I start learning more and more about Computer Programming.

[ June 11, 2008: Message edited by: James Mousseau ]

[Ted Smyth]

Good luck and keep having fun!

[James Mousseau]

     
if (box1.getText ().equals ("X") && box2.getText ().equals ("X") && box3.getText ().equals ("X"))
/*^If X's win due to the 3 visible buttons, Set the label to X wins, and block out all the other squares^*/
{
Winner.setText ("X Wins!!!!!!!!!!!!!!!!!!!!!");
box1.setEnabled (true); //keeping 1 of the winning boxes visible
box2.setEnabled (true); //keeping 1 of the winning boxes visible
box3.setEnabled (true); //keeping 1 of the winning boxes visible
box4.setEnabled (false); //disabling the box to show winning combination
box5.setEnabled (false); //disabling the box to show winning combination
box6.setEnabled (false); //disabling the box to show winning combination
box7.setEnabled (false); //disabling the box to show winning combination
box8.setEnabled (false); //disabling the box to show winning combination
box9.setEnabled (false); //disabling the box to show winning combination
PO.setText(String.valueOf(p1s + 1));
}
else
{
Winner.setText ("Get 3 In a row!!!!!!!!!"); //if not, keep the label marked the same as before
}

Its supposed to set the Jlabel to 1, then when the game starts again, how do I keep it counting from 1 on?
it seems to stay at 1.

int p1s = 0;
int p2s = 0;

Is declared in the public class XOXO, and this is the restart to the game under public static void:

if ("Restart".equals (evt.getActionCommand ())) //Restarting the game, re-setting everything
{
//adding text to all the buttons to which you can choose your X or O to go
box1.setText (("1"));
box2.setText (("2"));
box3.setText (("3"));
box4.setText (("4"));
box5.setText (("5"));
box6.setText (("6"));
box7.setText (("7"));
box8.setText (("8"));
box9.setText (("9"));
//Making the boxes unable to click until the "Lets Play" button is pressed
box1.setEnabled (false);
box2.setEnabled (false);
box3.setEnabled (false);
box4.setEnabled (false);
box5.setEnabled (false);
box6.setEnabled (false);
box7.setEnabled (false);
box8.setEnabled (false);
box9.setEnabled (false);
p1turn = 1;
p2turn = 2;
PO.setText(String.valueOf(p1s));
}

Last time I had a problem like this it was where the variables were defined, but Im pretty sure they are where they are supposed to do...

last think I promise
[ June 11, 2008: Message edited by: James Mousseau ]