Win a copy of Programmer's Guide to Java SE 8 Oracle Certified Associate (OCA) this week in the OCAJP forum!
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic

Is it costly to do req.getParameter() multiple times??

 
Sajee Joseph
Ranch Hand
Posts: 200
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hello all,
Please have a look at the statement below? Do u think there is an overheade in the statement (since req.getParameter() is done twice when the paramenet is not null).
String sSearchBy = req.getParameter("SearchBy")==null?"" String)req.getParameter("SearchBy");
Is there a better way to optimize the code??
Thanks,
Sajee Joseph
 
Frank Carver
Sheriff
Posts: 6920
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
You wrote: String sSearchBy = req.getParameter("SearchBy")==null ? "" : ( String)req.getParameter("SearchBy");
Sure, there's plenty of ways to improve this, for example:

Personally, I don't particularly like to hard code the default value ("") in situations like this, so I'd probably take a few minutes to write something like:

The in my code I could use the more expressive:

The biggest advantage of this approach is that it makes it so simple to appy a default value when reading parameters, that I'm much more likely to consider doing it every time, and not risk risk run-time failures through laziness.
 
  • Post Reply
  • Bookmark Topic Watch Topic
  • New Topic