insert statement

[meena latha]

Hi all..i am not able to insert the data into my data base.
Below is my code

try{
System.out.println("Inside the try block");
Connection con = ConnectionDB.getConnection();
 
        //ConnctionDB is my database connection class where i have written code for the database connection.


StringBuffer sql=new StringBuffer("Insert into customerTable(");
sql.append("FirstName,LastName,Role)value(");

sql.append("?,?,?)");
 prepared = con.prepareStatement(sql.toString());
prepared.setString(1,firstname);
prepared.setString(2,lastname);
prepared.setString(3,address);
 
count =prepared.executeUpdate();//line 1
 

if(count==1){
message="Successfully added one user.";
}
prepared.close();
con.close();
}catch(SQLException sq){
message = "Error."+sq.toString();
}
catch(Exception e){}
}

To find the error line is use System.out.println().
When i used that i was able to get output just before line 1.
After line 1 i am not able to get any output.

But i am able to do my select statement properly.
I am not able to find error in my insert statement.
Please give me some suggestion.

Thanks in advance
Ramya

[Shailesh Chandra]

Originally posted by ramya jp:

catch(SQLException sq)
{
  message = "Error."+sq.toString();
}
catch(Exception e)
{
}
 

i was able to get output just before line 1.
After line 1 i am not able to get any output.

You should have posted this in JDBC forum.

1. are you committing your transaction ?
2. If you can see System.out.println before line 1, Then might be there is an exception during insert.

Did you check what does StatckTrace say ?

you can do this simply

catch(SQLException sq)
{
 message = "Error."+sq.toString();
 sq.printStackTrace();
}
catch(Exception e)
{
  e.printStackTrace();
}

Shailesh

[meena latha]

Thanks Shailesh.....
As you said i inserted printStackTrace().
So in my console i got the following error message

[Microsoft][ODBC Microsoft Access Driver] Syntax error in INSERT INTO statement.
at sun.jdbc.odbc.JdbcOdbc.createSQLException(JdbcOdbc.java:6958)
at sun.jdbc.odbc.JdbcOdbc.standardError(JdbcOdbc.java:7115)
at sun.jdbc.odbc.JdbcOdbc.SQLExecute(JdbcOdbc.java:3150)
at sun.jdbc.odbc.JdbcOdbcPreparedStatement.execute(JdbcOdbcPreparedStatement.java:214)
at sun.jdbc.odbc.JdbcOdbcPreparedStatement.executeUpdate(JdbcOdbcPreparedStatement.java:136)
at com.eminence.servlet.InsertServlet.service(InsertServlet.java:56)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.StandardContextValve.invokeInternal(StandardContextValve.java:198)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:152)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:137)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:118)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:929)
at org.apache.coyote.tomcat5.CoyoteAdapter.service(CoyoteAdapter.java:160)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:799)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:705)
at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:577)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:683)
at java.lang.Thread.run(Thread.java:534)
 

So from the message it is obvious that there is error in insert statement,but i am not able to knock off the error.
Can u please check my insert statement and tell me whether there is any syntax error.

Thanks

[Heonkoo Lee]

Correct syntax is as below:

INSERT INTO table_name (col1_name, col2_name) VALUES (value1, value2)

[miguel lisboa]

Correct syntax is as below:

INSERT INTO table_name (col1_name, col2_name) VALUES (value1, value2)

let me (partly) disagree with you; see this

[Carol Enderlin]

miguel,

not sure what your point is.

[miguel lisboa]

i mean that saying that there's only one correct aproach doesnt seem right to me: if you wanna make an insert with all fields you can simply say
INSERT INTO table_name VALUES (value1, value2) , as that site's tutorial refers:

The INSERT INTO Statement
The INSERT INTO statement is used to insert new rows into a table.

Syntax
INSERT INTO table_name
VALUES (value1, value2,....)

You can also specify the columns for which you want to insert data:

INSERT INTO table_name (column1, column2,...)
VALUES (value1, value2,....)

[Bear Bibeault]

Please do not cross-post the same question in multiple forums. It wastes people's time when multiple redundant conversations take place.

[meena latha]

Thanks to all for your response....but still my problem persists.
I am not able to insert the data.
There is my complete code.

public void service(HttpServletRequest request,HttpServletResponse response){

String firstname = request.getParameter("firstname");
String lastname = request.getParameter("lastname");
String address= request.getParameter("address");

String message=null;
ConnectionDB connection= new ConnectionDB();
int count = 0;
try{

Connection con = ConnectionDB.getConnection();
Statement  st = con.createStatement();

System.out.println("before the insert")
String s = "INSERT INTO EntryTable VALUES     ('firstname','lastname','address')";
count = st.executeUpdate(s);

if(count==1){
message="Successfully added one user.";
}
st.close();
con.close();
}catch(SQLException sq){
message = "Error."+sq.toString();
sq.printStackTrace();
}
catch(Exception e){
e.printStackTrace();
}

}

The code inside my ConnectionDB class

try{
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
con=DriverManager.getConnection("jdbc  :-o	  dbc:TestDB");
System.out.println("driver loaded");
}catch(ClassNotFoundException e){
System.out.println("Could not load");

}catch(SQLException sq){
System.out.println("Sql exception found");
}
return con;
}

Will be great if somebody is able to tell me some solution .
Thanks
Ramya
[ May 15, 2005: Message edited by: ramya jp ]