Assignment 1.4

[Neha Gupta]

Hi..
Here is my code for Assignment 1.4.All comments are welcome.
// Read an int at command line 0-99, and display number spelled out
code
-----------------------------------------------------------------

public class Say
    {   
       
        static String snum[] = {"Zero","One","Two","Three","Four","Five", "Six" , "Seven", "Eight" ,"Nine", 
       "Ten","Eleven","Twelve","Thirteen","Fourteen","Fifteen", "Sixteen" , "Seventeen",
               "Eighteen", "Nineteen","Twenty","Thirty","Fourty","Fifty" , "Sixty" , "Seventy","Eighty","Ninty" 
                              };
        static int dnum[] = new int[3];
        public static void main ( String args[] ) 
        {
            
    dnum[0] = Integer.parseInt(args[0]);
            dnum[1] = Integer.parseInt(args[0].substring(0,1));
            dnum[2] = Integer.parseInt(args[0].substring(1,2));
            if ( dnum[0] <= 20 )
                {
            System.out.print( snum[dnum[0]] );
                }
                else 
                {  
   switch(dnum[1]) 
                   {
case 2:  System.out.print( snum[20] + "-" + snum[dnum[2]] ); break;
case 3:  System.out.print( snum[21] + "-" + snum[dnum[2]] ); break;
case 4:  System.out.print( snum[22] + "-" + snum[dnum[2]] ); break;
case 5:  System.out.print( snum[23] + "-" + snum[dnum[2]] ); break;
case 6:  System.out.print( snum[24] + "-" + snum[dnum[2]] ); break;
case 7:  System.out.print( snum[25] + "-" + snum[dnum[2]] ); break;
case 8:  System.out.print( snum[26] + "-" + snum[dnum[2]] ); break;
case 9:  System.out.print( snum[27] + "-" + snum[dnum[2]] ); break;
default: System.out.println("Not a valid Number"); break;

                   }
}              
        }

    }     

[This message has been edited by Marilyn deQueiroz (edited December 05, 2000).]

[Neha Gupta]

I do not have any editor other than Notepad.My code is aligned properly in my editor , after posting it is not indented.HELP ???
ANy free editor available..

[Marilyn de Queiroz]

If you use the ubb code tags, your code will indent the way you have typed it.

[Kapil Sachdeva]

Hi Neha,
Its good logical code u've used in yr program. I would like to suggest a few change in yr program. You can modify this code in such a way so that it will accept any number and display it in words. e.g. 1012 - one thousand and twelve only

[paul wheaton]

Neha,
Usually I prefer that you don't post code here. If you post great code, you will be robbing others of an education.
I suggest that you send this assignment on to [e-mail] and get proper feedback.

[Neha Gupta]

Thanks for the suggestion Kapil,will try doing that.I am just a beginner,Is java HARD to learn.
I will take care Paul not to post code here.

[Shama Khan]

Neha,
You didn't use methods - so that's one alteration you've to make. I like your algorithm though.
Shama

[Jeff McIlvain]

Neha,
When i run your program and input a single digit number I get

Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: 2
at java.lang.String.substring(String.java:1489)
at Say.main(Say.java:3)

Also, when I input 30, 40, 50... I get Thirty-Zero, Forty-Zero, Fifty-Zero...

I'm new to Java, so I don't know if I'm doing something incorrect or not. If so could someone please correct me.
Thanks ~ Jeff

[This message has been edited by Jeff McIlvain (edited January 29, 2001).]
[This message has been edited by Jeff McIlvain (edited January 29, 2001).]

[bill bozeman]

Jeff, you are write on both counts. First you get the error becuase you are calling substring(1,2) on something that only has 1 digit, so substring(1,2) looks at the second digit, which there is none.
And for the second error in output, you get that because there is no checks to see if the input is divisble by ten so you don't print the - and zero part.
Bill