ClockDisplay

[Lisa Beglaw]

On to a new assignment now...

    /**
     * Return the current time of this display in the format HH:MM using AM or PM.
     */
    public String getTime()  //returns getTime as a String
    {
        int hour = hours.getValue();  //from my NumberDisplay class
        if (hour > 12) {
            hour = hour - 12;
        }
        else {
            return displayString;  //this is the only line from the original method
        }
    }

I get an error saying I am missing a return statement. But it is there. So what is the error message REALLY trying to tell me?

[Srinivasa Raghavan]

The error is because you are not returning anything when the condition in the if clause is true.

if (hour > 12) 
{            hour = hour - 12;        
//Return something here
} 

[Lisa Beglaw]

Ahhh...I see.

So if I wanted to add AM or PM to the end how would I go about doing that? I want to keep the clock calculation at military time (24hr) but I want the display to show in regular 12h time. So 23:15 will display as 11:15 PM.

Do I need to define a new field for AM or PM?

And would that then be my 'return' statement?

[Srinivasa Raghavan]

I feel the class SimpleDateFormat should help you.
Else declare a variable, update it accordingly and return it.
[ July 26, 2005: Message edited by: Srinivasa Raghavan ]

[Lisa Beglaw]

I went to that site but it didn't really help me.

Now I have...

    /**      
     * Return the current time of this display in the format HH:MM using AM or PM.
     */
    public String getTime()  //returns getTime as a String     
    {         
        int hour = hours.getValue();         
        String amOrPm = "";         
        if (hour > 12) {             
            hour = hour - 12;             
            amOrPm = " PM";         
        }         
        else {             
            amOrPm = " AM";         
        }     
    }

and am still getting the missing return type error.

[Lisa Beglaw]

Let my clarify that 'didn't really help me� comment. The help may be there, but I am unsure of how to decipher it.

I really haven't found that site to be good use for beginners like myself.

[Srinivasa Raghavan]

Now you are missing return statement in "if" & "else" clause.
Return a value at the end of the method.

public String getTime()  {                 
  int hour = hours.getValue();                 
  String amOrPm = "";                 
  if (hour > 12) {                         
   hour = hour - 12;
   amOrPm = " PM";
  }
  else {
   amOrPm = " AM";
  }         
 return amOrPm;
}

[ July 26, 2005: Message edited by: Srinivasa Raghavan ]
[ July 26, 2005: Message edited by: Srinivasa Raghavan ]

[Srinivasa Raghavan]

Originally posted by Lisa Beglaw:
Let my clarify that 'didn't really help me� comment. The help may be there, but I am unsure of how to decipher it.

I really haven't found that site to be good use for beginners like myself.

Have a look at this site this has a few sample codes. Search for SimpleDateformat in the webpage.
SimpleDateFormat is a class that converts a date to a specified format like short time , long time etc etc ..

Check also this article , it explains about the class
[ July 26, 2005: Message edited by: Srinivasa Raghavan ]

[Lisa Beglaw]

So simple yet so complicated. I keep forgetting that 'else' ISN'T a return statement.

If I have void in my method then I don't need a return, anything else MUST end in "return" + something to return. An hour...and day...whatever.

I don't know when I will get that thru my head!

Thanks for your direction. I will check that other site out as well.

[Srinivasa Raghavan]

But you should also have this in mind, that it's not a good practice, to declare all variables globally ( as a member variable).
[ July 26, 2005: Message edited by: Srinivasa Raghavan ]

[Stefan Wagner]

You may get rid of the else:

public String getTime ()  
{
int hour = hours.getValue ();
String amOrPm = hour + " AM";
if (hour > 12) 
{
amOrPm = (hour-12) + " PM";
}
return amOrPm;
}

[ July 26, 2005: Message edited by: Stefan Wagner ]

[Lisa Beglaw]

Thanks Stefan. I like that way too. Anything that can shorten it up a bit.