java upgrade makes modal dialog lock up application

[Kevin Davies]

I just upgraded from java 1.5.0_01 to java 1.5.0_04 and am now getting a problem with a modal dialog in my java application in Windows (but not in linux). What happens is that I have a modal dialog that comes up and when I do anything that causes a call to dialog.setVisible(false), the dialog disappears (as it should), but the rest of the application is still locked up. The weirdest thing is that this worked without any problem until I updated java versions and it is only in windows. It would seem to indicate there is something screwy in this latest version of the jvm for windows. Any ideas or suggestion?

[Kai Witte]

hello,

although your description would be typical for a a certain kind of bug that keeps appearing and disappearing since 1.2 I can not reproduce the problem you describe. I recommend to provide a test case. Also tell us your exact Windows version.

Here is a test case that does NOT produce your problem:

import javax.swing.*;
import java.awt.Dimension;
 
public class DiaKill {
    private static final Dimension NORMAL_SIZE = new Dimension(150, 150);
 
    public static void main(String[] args) throws InterruptedException {
        final JFrame frame = new JFrame();
        final JDialog dia = new JDialog(frame, true);
 
        SwingUtilities.invokeLater(
                new Runnable() {
                    public void run() {
                        frame.setSize(NORMAL_SIZE);
                        frame.setVisible(true);
                        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
                        dia.setSize(NORMAL_SIZE);
                        dia.setVisible(true);
                    }
                }
        );
        
        Thread.sleep(2000);
 
        SwingUtilities.invokeLater(
                new Runnable() {
                    public void run() {
                        dia.setVisible(false);
                    }
                }
        );
    }
}

Kai

[Kevin Davies]

Unfortunately, it is very hard to reduplicate this problem in some simplified code. I have been trying to, but I have not been successful. The real code is far to large and proprietory to post here.

[Jim Yingst]

From what you've said, sounds like a JDK bug of some sort, yes. If it worked in 1.5.0_01 but not 1.5.0_04, it may be worthwhile for you to try intermediate versions as well. You can find them in Sun's product downloads archive. I'd switch to the most recent JDK version that doesn't exhibit this problem. And search the bug database for reports of similar trouble. If you can't find an existing report that matches what you're seeing, then you'll want to enter a new bug reprot to make Sun aware of the issue. However to do this you will need a test case that you can submit to Sun.

[Kevin Davies]

I was finally able to make a simple code that reproduced the problem

 
import javax.swing.JButton;
import javax.swing.JDialog;
import javax.swing.JFrame;
import javax.swing.JLabel;
import java.awt.event.*;
 
public class Test {
 

static public JDialog makeDialog(int cnt){
final JDialog d1 = new JDialog((JFrame)null,"Dialog "+cnt,true);
d1.addWindowListener(new WindowAdapter(){
@Override
public void windowClosing(WindowEvent event){
d1.setVisible(false);
}
});
if(cnt==0){
d1.getContentPane().add(new JLabel("No more dialogs"));
}
else {
cnt--;
final JDialog d2 = makeDialog(cnt);
JButton b = new JButton("See Dialog "+cnt);
d1.getContentPane().add(b);
b.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e) {
d2.setVisible(true);
}
});
}
d1.pack();
return d1;
}
public static void main(String args[]) {
JDialog dialog = makeDialog(3);
dialog.addWindowListener(new WindowAdapter(){
@Override
public void windowClosing(WindowEvent event){
System.exit(0);
}
});
dialog.setVisible(true);
}
}

[Kai Witte]

Originally posted by Kevin Davies:
I was finally able to make a simple code that reproduced the problem

Excellent, that helps a lot. The program works as you intend (and as it does with older JREs) when you set a proper owner where applicable:

import javax.swing.*;
import java.awt.event.*;
public class Test {
    static public JDialog makeDialog(int cnt, JDialog owner){
        final JDialog d1;
        if (owner == null) {
           d1 = new JDialog((JFrame) null,"Dialog "+cnt,true);
        }
        else {
            d1 = new JDialog(owner,"Dialog "+cnt,true);
        }
        d1.addWindowListener(new WindowAdapter(){
            @Override
            public void windowClosing(WindowEvent event){
                d1.setVisible(false);
            }
        });
        if(cnt==0){
            d1.getContentPane().add(new JLabel("No more dialogs"));
        }
        else {
            cnt--;
            final JDialog d2 = makeDialog(cnt, d1);
            JButton b = new JButton("See Dialog "+cnt);
            d1.getContentPane().add(b);
            b.addActionListener(new ActionListener(){
                public void actionPerformed(ActionEvent e) {
                    d2.setVisible(true);
                }
            });
        }
        d1.pack();
        return d1;
    }
 
    public static void main(String... args) {
        Runnable runnable = new Runnable() {
            public void run() {
                JDialog dialog = makeDialog(3, null);
                dialog.addWindowListener(new WindowAdapter(){
                    @Override
                    public void windowClosing(WindowEvent event){
                        System.exit(0);
                    }
                });
                dialog.setVisible(true);
            }
        };
        SwingUtilities.invokeLater(runnable);
    }
}

(Performing everything in the EDT is probably not related to the problem, but I just do it to make sure we have no problems related to that.)

Kai