Reading strings from a line problem _ any help!!

[celine scarlett]

Hi,

My test main class allows user input to create one integer, which I've converted to a string, plus four strings representing details to be written to a file. When these details are written to the file they initially read correctly, eg:

111,hello one,hello two,hello three,hello four

The problem occurs when I try to write a second set if user entry values to this file. It is expecting four strings as words, and therefore reads and writes the above line as follows,

111,,hello,one,hello,two,hello,three,hello

I have absolutely no idea why this is happening and would really appreciate some help or advice with this problem.

The current code for my test main class is as follows,

  
import simplejava.*;
import videos.*;
import java.io.*;
 
public class AddTitle {
    
    public static void main(String[] args) {
        String film, actor1, actor2, director, title;
        int codeNum;
        
        SimpleReader keyboard = new SimpleReader();
        SimpleWriter screen = new SimpleWriter();
        
        SimpleReader inFile = new SimpleReader("title_test.txt");
        
        TitleList titles = new TitleList(inFile);
        codeNum = keyboard.readInt("Title Code for the Film");
        int intValue = codeNum;
        String stringValue = Integer.toString(intValue);
        film = keyboard.readLine("Film Title?");
        actor1 = keyboard.readLine("Lead Actor?");
        actor2 = keyboard.readLine("Supporting Actor?");
        director = keyboard.readLine("Director?");
        titles.add(new Title(codeNum, film, actor1, actor2, director));
        screen.println(titles);
        
        title = inFile.readLine();
        String[] myStrings = title.split(",");
        for (int i=0; i<myStrings.length; i++)
        System.out.print(myStrings[i]);
        
        SimpleWriter outFile = new SimpleWriter("title_test.txt");
        titles.saveTo(outFile);
        outFile.close();
    }
}

Any help or advice really appreciated at this stage!!

[Peter Chase]

It is rather difficult to give a good reply, because your code is based on the classes like TitleList, SimpleReader and SimpleWriter, which are not part of standard Java.

Guessing at what SimpleReader and SimpleWriter are trying to do, I cannot see anything immediately wrong with your code. However, something must be wrong if you are seeing wrong behaviour, so we would need to see exactly what these other classes do. That might be too much code to post, though.

[celine scarlett]

Hi,

Thanks for the reply. SimpleReader and Writer allow basic reading in and out of files etc. My current code for the TitleList class is as follows,

import simplejava.*;
 
public class TitleList {
    
    private int maxTitles, TitleCount;
    
    private Title[] TitleArray;
    private int numTitles;
    
    Title title;
    
    public TitleList(int max) {
        TitleCount = 0; maxTitles=max;
        TitleArray = new Title[max];
    }
    
    public TitleList() {
        this(1000000);
    }
    
    public TitleList(SimpleReader in) {
        this(in.readInt());
        int entries = in.readInt();
        for (int i = 0; i<entries; i++)
            add(new Title(in));
    }
    
    public int getSize() {
        return TitleCount;
    }
    
    public boolean add(Title newItem) {
        if (TitleCount><maxTitles) {
            TitleArray[TitleCount] = newItem;
            TitleCount++;
            return true;
        } else return false;
    }
    
    public boolean delete(int titleCodeToDel)
{
int delIndex = -1;
 
for(int i=0; (delIndex==-1)&&(i<TitleCount); i++)
{
         if(TitleArray[i].getTitleCode()==titleCodeToDel)
                 delIndex = i;
}
 
if(delIndex == -1)
         return false;
else
{
         for(int j=delIndex; j><TitleCount-1; j++)
                 TitleArray[j] = TitleArray[j+1];
         TitleCount--;
         return true;
}
  }
    
    public Title lookUp(int requiredNum) {
        boolean found = false;
        int next = 0;
        
        while (!found && (next><TitleCount)) {
            if ( TitleArray[next].getTitleCode() == requiredNum)
                found = true;
            else next++;
        }
        if (found) return TitleArray[next];
        else return null;
    }
    
    public void saveTo(SimpleWriter out) {
        int next;
        out.println(maxTitles+" "+TitleCount);
        for (next=0; next><TitleCount; next++)
            TitleArray[next].saveTo(out);
    }
    
    public String toString() {
        int next;
        String result = "";
        result+= "Borrower Count = "+" "+TitleCount;
        result+= " Max Borrowers = "+maxTitles;
        for (next=0; next><TitleCount; next++)
            result+= "\n"+TitleArray[next];
        return result;
    }   
}

The above class also uses the basic Title class which is as follows,

import simplejava.*;
 
public class Title {
    private int titleCode;
    private String filmName, leadActor1, leadActor2, director;
    
    public Title(int title, String film, String lead1, String lead2, String dir) {
        titleCode = title;
        filmName = film;
        leadActor1 = lead1;
        leadActor2 = lead2;
        director = dir;
    }
    
    public Title(SimpleReader in) {
        this(in.readInt(), in.readWord(), in.readWord(), in.readWord(), in.readWord()); 
    //this(in.readInt(), in.readLine());
    }
    
    public void setTitleCode(int title) {
        titleCode = title;  }
    
    public int getTitleCode() {
        return titleCode;  }
    
    public void setFilmName(String film) {
        filmName = film;  }
    
    public String getFilmName() {
        return filmName;  }
    
    public void setLeadActor1(String lead1) {
        leadActor1 = lead1;  }
    
    public String getLeadActor1() {
        return leadActor1;  }
    
    public void setLeadActor2(String lead2) {
        leadActor2 = lead2;  }
    
    public String getLeadActor2() {
        return leadActor2;  }
    
    public void setDirector(String dir) {
        director = dir;  }
    
    public String getDirector() {
        return director;  }
    
    public void saveTo(SimpleWriter out) {
        out.println(titleCode+","+filmName+","+leadActor1+","+leadActor2+","+director);
    }//saveTo method writes details of the Title class to a text file
    
    public String toString() {
        return "Code Number = "+titleCode+" Film = "+filmName+" Lead Actor = "+leadActor1+" Supporting Actor = "
                +leadActor2+" Director = "+director+" ";  }
    
}

Can anybody see why this problem is occurring?

Any help gratefully appreciated!