Reading Objects and Formatting Ouput

[Holly Leery]

Hello there! I was hoping I could get a few pointers on the code below!! Ok, here is the background for what I am doing.

1) The program will read the original sales data from SalesData.txt, that will create salesmen and then that information will be entered into the array list Salesman. The file looks like this (just so ya know):

Jones&2&5&3&0&8&SENIOR
Smith&6&0&2&0&5&JUNIOR
Douglas&1&0&7&5&3&ENTRY
Hollins&9&6&3&7&15&ENTRY
Smythe&0&0&0&0&0&SENIOR
Billings&0&7&12&15&2&JUNIOR
Kozak&3&5&8&22&0&ENTRY

2) Each salesman has a level type of ENTRY, JUNIOR, or SENIOR. There will be an enumerated class for the sales type. There is a variable, bonus, associated with each type. The bonus for SENIOR is 15%. The bonus for JUNIOR is 10%, and the bonus for ENTRY is 5%.
3) The user will be able to enter additional data on the GUI, either a new salesman and his product sales or the user can update an existing salesman.
4) Then once all of the data is entered the data will be written to the Salesman.data as objects.
5) Then also added to the GUI will be an additional button that when it is clicked the user will actually read the Salesman.data file, put the information in a vector, sort it, and last prints the information to the output area on the GUI in alphabetical order.
6) I need to create a NoSalesException. This exception will be thrown from calculateSales and handled from the calling method. To handle this exception, I will print a warning message dialog box that states the name of the salesman and that he has no sales.

I have worked on everything with the exception of the NoSalesException.

So, the program compiles fine, but then I believe the reason why it doesn't work properly after entering in all of the additional salesman information is in the readObjectData method. I was wondering if anyone has any tips or ideas for me in that regard, please just let me know if so. I will take any hlep I can get to finish this one up. Also, I am sorry if this is too detailed, I just thought I would give a good description of what I am doing to begin with that way you had a good understanding of what I am trying to do. Again, if anyone has any tips, ideas or help...please please let me know! Much appreciated!!

Sales:

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
import java.util.ArrayList;
import java.io.*;
import java.util.*;
import java.text.NumberFormat;
 
public class Sales extends JFrame
{
static JLabel salesmanlabel;
static JTextField salesmanname;
static JLabel amtsold;
static JTextField amount;
static JLabel level;
static JComboBox saleslevel;
static JLabel productname;
static JComboBox product;
static JButton salesmandone;
static JButton entrydone;
static JButton calctotal;
static JTextArea output;
static String outp;
static Handler handler = new Handler();
static ArrayList<Salesman> myList = new ArrayList<Salesman>();
static NumberFormat currencyFormat = NumberFormat.getCurrencyInstance();

public Sales()
{
super("Monthly Sales");
setDefaultCloseOperation(EXIT_ON_CLOSE);
Container c = getContentPane();
c.setLayout(new FlowLayout());

salesmanlabel = new JLabel("Salesman:");
salesmanname = new JTextField(20);
amtsold = new JLabel("Amount Sold:");
amount = new JTextField(20);
level = new JLabel("Sales Level:");
saleslevel = new JComboBox();
productname = new JLabel("Product Sold:");
product = new JComboBox();
salesmandone = new JButton("Salesman Entry Done");
entrydone = new JButton("All Data Entry Done");
calctotal = new JButton("Grand Total");
output = new JTextArea(300, 300);

product.addItem("");
product.addItem("Product 1");
product.addItem("Product 2");
product.addItem("Product 3");
product.addItem("Product 4");
product.addItem("Product 5");

saleslevel.addItem("");
saleslevel.addItem("Entry");
saleslevel.addItem("Junior");
saleslevel.addItem("Senior");

c.add(salesmanlabel);
c.add(salesmanname);
c.add(amtsold);
c.add(amount);
c.add(level);
c.add(saleslevel);
c.add(productname);
c.add(product);
c.add(salesmandone);
c.add(entrydone);
c.add(calctotal);
c.add(output);
 
output.setVisible(true);
output.setRows(15);
output.setColumns(25);

salesmandone.addActionListener(handler);
entrydone.addActionListener(handler);
calctotal.addActionListener(handler);
}
 
public static void main (String args[])
{
Sales sale = new Sales();
sale.setSize(300,400);
sale.setVisible(true);

readFileData();
}

public static void readFileData()
{
String line;

try
{
FileReader file = new FileReader("SalesData.txt");
BufferedReader buff = new BufferedReader(file);

while ((line = buff.readLine())!= null)
{
String[] elements = line.split("&");
String name = elements [0];
double sales = 0.0;
double bonus = 0.0;

sales += Double.parseDouble(elements[1]) * 2.98;
sales += Double.parseDouble(elements[2]) * 4.50;
sales += Double.parseDouble(elements[3]) * 9.98;
sales += Double.parseDouble(elements[4]) * 4.49;
sales += Double.parseDouble(elements[5]) * 6.87;

Classification b = Classification.valueOf(elements[6]);

sales += bonus;

myList.add(new Salesman(name, sales));

}
buff.close();
}
catch(IOException ioe)
{
ioe.printStackTrace();
}
}
 
public static class Handler implements ActionListener
{
public void actionPerformed(ActionEvent e)
{
if(e.getSource() == salesmandone)
{
addSalesman();
}
else if(e.getSource() == entrydone)
{
writeFileData();
}
else if(e.getSource() == calctotal)
{
readObjectData();
}
}
}

public static Salesman getSalesman(String salesman)
{
for (Salesman salesm : myList)
{
        if (salesman.equals(salesm.getName()))
        {
             return salesm;
         }
     }
return null;
}

public static void addSalesman()
{
double sales = calculateSales(product.getSelectedIndex(), Integer.parseInt(amount.getText()));

if (getSalesman(salesmanname.getText()) != null)
{
getSalesman(salesmanname.getText()).addToSales(sales);
}
else
{
myList.add(new Salesman(salesmanname.getText(), sales));
}
 
salesmanname.setText("");
product.setSelectedIndex(0);
amount.setText("");
salesmanname.requestFocus();
}

public static double calculateSales(int product,int amount)
{
double sales;

product++;

switch(product)
{
case 2:   sales = (amount * 2.98);
break;
 
case 3:   sales = (amount * 4.50);
break;

case 4:   sales = (amount * 9.98);
break;

case 5:   sales = (amount * 4.49);
break;

case 6:   sales = (amount * 6.87);
break;
 
default: sales = (0.00);
}

if(saleslevel.getSelectedItem().equals("Entry"))
{
sales += sales * .05;
}
if(saleslevel.getSelectedItem().equals("Junior"))
{
sales += sales * .10;
}
if(saleslevel.getSelectedItem().equals("Entry"))
{
sales += sales * .15;
}

return sales;
}
public static void writeFileData()
{
try
{
ObjectOutputStream oos = new ObjectOutputStream(new FileOutputStream("Salesman.data"));
     
for (Salesman s : myList)
{
oos.writeObject(s);
}
oos.close();
}
catch(IOException ioe)
{
                        ioe.printStackTrace();
                }
        }

public static void readObjectData()
{
Vector<Salesman> salesmanList = new Vector<Salesman>();

StringBuilder builder = new StringBuilder("\tTOTAL SALES\n\n");
 
double total = 0.00;

Collections.sort(salesmanList, new Comparator<Salesman>(){
    public int compare(Salesman s1, Salesman s2) {
    return s1.getName().compareTo(s2.getName());}});

    for (Salesman s : salesmanList)
    {
    builder.append(s.toString() +"\n");
    total += s.getSales();
    }
    
    builder.append("\nTotal\t\t       " + currencyFormat.format(total));
     
    try
    {
    ObjectInputStream ois = new ObjectInputStream(new FileInputStream("Salesman.data"));
        Salesman salesman;
        while ((salesman = (Salesman) ois.readObject()) != null)
        {
        salesmanList.add(salesman);
        }
        
output.setText(builder.toString()); 
    }
catch ( IOException ioException )
{
ioException.printStackTrace();
}  
catch (ClassNotFoundException cnfe)
{
    cnfe.printStackTrace();
}
}
}

Salesman:

import java.text.NumberFormat;
import java.io.Serializable;
 
public class Salesman implements Serializable
{
private String name;
private double sales;
private double addToSales;

NumberFormat currencyFormat = NumberFormat.getCurrencyInstance();
 
public Salesman()
{
setName("");
setSales(0);
}
 
public Salesman(String name, double sales)
{
        setName(name);
        setSales(sales);
}
 
public void setName(String name)
{
this.name = name;
}
 
public void setSales(double sales)
{
this.sales = sales;
}
 
public void addToSales(double sales)
{
      this.sales += sales;
}

public String getName()
{
return name;
}
 
public double getSales()
{
return sales;
}

public String toString()
{
return (name + "\t\t       " + currencyFormat.format(sales));
}
}

Classification:

public enum Classification
{
ENTRY(.05),
JUNIOR(.10),
SENIOR(.15);

private double bonus;

Classification(double b)
{
bonus = b;
}

public void setBonus(double b)
{
bonus = b;
}

public double getBonus()
{
return bonus;
}
}

Thanks again!!!

[Garrett Rowe]

Holly Leery: So, the program compiles fine, but then I believe the reason why it doesn't work properly after entering in all of the additional salesman information is in the readObjectData method.

What exactly is it doing after the readObjectData() method call.

Holly Leery: Again, if anyone has any tips, ideas or help...please please let me know!

A couple of things I see that probably have no relation to the problems you're experiencing. In this section of code:

while ((line = buff.readLine())!= null)
{
   String[] elements = line.split("&");
   String name = elements [0];
   double sales = 0.0;
   double bonus = 0.0;

   sales += Double.parseDouble(elements[1]) * 2.98;
   sales += Double.parseDouble(elements[2]) * 4.50;
   sales += Double.parseDouble(elements[3]) * 9.98;
   sales += Double.parseDouble(elements[4]) * 4.49;
   sales += Double.parseDouble(elements[5]) * 6.87;

   Classification b = Classification.valueOf(elements[6]);

   sales += bonus;

   myList.add(new Salesman(name, sales));

}

You never call b.getBonus();. Therefore the Salesman never recieves his proper bonus . Also the calls to close() the streams should be wrapped in a 'finally' block so that the occur even if an IOException occurs.

[Holly Leery]

Oh my goodness you are right I didn't do anything with the bonus...obviously I need to go back in a fix that so that that runs properly. Thank you for pointing that out to me! After the program compiles I can enter in any amount of salesman, the amount of a product sold, that prodct and the salesman level, I then click "All Data Entry Done" which writes the data as objects to Salesman.data and then when I click "Grand Total" to read the data back in and post it in the textarea I get the following error:

java.io.EOFException
        at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputSt
ream.java:2502)
        at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1267)
        at java.io.ObjectInputStream.readObject(ObjectInputStream.java:339)
        at Sales.readObjectData(Sales.java:261)
        at Sales$Handler.actionPerformed(Sales.java:142)
        at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:18
49)
        at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.jav
a:2169)
        at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel
.java:420)
        at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:258
)
        at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonL
istener.java:234)
        at java.awt.Component.processMouseEvent(Component.java:5488)
        at javax.swing.JComponent.processMouseEvent(JComponent.java:3093)
        at java.awt.Component.processEvent(Component.java:5253)
        at java.awt.Container.processEvent(Container.java:1966)
        at java.awt.Component.dispatchEventImpl(Component.java:3955)
        at java.awt.Container.dispatchEventImpl(Container.java:2024)
        at java.awt.Component.dispatchEvent(Component.java:3803)
        at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4212
)
        at java.awt.LightweightDispatcher.processMouseEvent(Container.java:3892)
 
        at java.awt.LightweightDispatcher.dispatchEvent(Container.java:3822)
        at java.awt.Container.dispatchEventImpl(Container.java:2010)
        at java.awt.Window.dispatchEventImpl(Window.java:1766)
        at java.awt.Component.dispatchEvent(Component.java:3803)
        at java.awt.EventQueue.dispatchEvent(EventQueue.java:463)
        at java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchTh
read.java:234)
        at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThre
ad.java:163)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:157)
 
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:149)
 
        at java.awt.EventDispatchThread.run(EventDispatchThread.java:110)

[Garrett Rowe]

Instead of serializing each Salesman individually, you could just serialize the entire Salesman list:

public static void writeFileData()
{
   try
   {
      ObjectOutputStream oos = new ObjectOutputStream(new FileOutputStream("Salesman.data"));
        
      try
      {
         oos.writeObject(myList);
      }
 
      finally
      {
         oos.close();
      }
   }
 
   catch (IOExcpetion ex)
   {
      ex.printStackTrace();
   }
}

And then deserailize like this:

public static void readObjectData()
{
   //...
     
   try
   {
      ObjectInputStream ois = new ObjectInputStream(new FileInputStream("Salesman.data"));
 
      try
      {
         myList = (ArrayList<Salesman>)   ois.readObject();
      }
 
      finally
      {
         ois.close();
      }
   }        
      
   catch ( IOException ioException )
   {
      ioException.printStackTrace();
   }  
 
   catch (ClassNotFoundException cnfe)
   {
      cnfe.printStackTrace();
   }
}

[ March 22, 2006: Message edited by: Garrett Rowe ]

[Holly Leery]

Ok, that makes sense, thank you. Is there a way to format the data to look a certain way and set it in the textarea? What I am doing does not seem to be working properly.

[Holly Leery]

Ok I have two parts printing to the output textarea, the TOTAL SALES line and the actual Total line. The individual sales are not being sent though. Could this have to do with the vector? Unfortunetly I am supposed to be using a vector and I think that is part of my problem.

public static void readObjectData()
{
try
{
Vector<Salesman> salesmanList = new Vector<Salesman>();

StringBuilder builder = new StringBuilder("\tTOTAL SALES\n\n");
 
double total = 0.00;

Collections.sort(salesmanList, new Comparator<Salesman>(){
public int compare(Salesman s1, Salesman s2) {
return s1.getName().compareTo(s2.getName());}});

for (Salesman s : salesmanList)
{
builder.append(s.toString() +"\n");
total += s.getSales();
}
    
builder.append("\nTotal\t\t       " + currencyFormat.format(total));

output.setText(builder.toString()); 
 
ObjectInputStream ois = new ObjectInputStream(new FileInputStream("Salesman.data"));
try
{
Salesman salesman;
while ((salesman = (Salesman) ois.readObject()) != null)
{
salesmanList.add(salesman);
}
}
finally
{
ois.close();
}
}
catch ( IOException ioException )
{      
ioException.printStackTrace();
}      
catch (ClassNotFoundException cnfe)   
{      
cnfe.printStackTrace();   
}
}

[Holly Leery]

Hello there! I was hoping someone could help me out! I would really appreacaite it! I am almost completely done with the program, I am just having two small problems. 1) I cannot figure out how to handle the enum class. I have to use bonus in the readFileData() method, but I am not sure how I am supposed to declare it. I keep getting errors no matter what I try. I know it is probably something extreamly simple, but I am just not seeing it. 2) In addSalesman() I am using an ArithmeticException that is originally thrown from CalcSales() where I created an Exception "NoSalesException". Well it is telling me I cannot have this in the JOptionPane...why is this and what can I do to fix it? Also can I put the salesman name in there?


Sales:

import java.awt.*;
import javax.swing.*;
import java.awt.event.*;
import java.util.ArrayList;
import java.io.*;
import java.util.*;
import java.text.NumberFormat;
 
//Class Sales runs a program that reads data from an existing file (file contains salesmen name and the amount of products sold),
//calculates their sales amount and adds their bonus to it.  The class also allows a user to enter additional salesman information
//which is also calculated and totaled.  Last all of the Salesman data is printed to the textarea.
 
public class Sales extends JFrame
{
static JLabel salesmanlabel;
static JTextField salesmanname;
static JLabel amtsold;
static JTextField amount;
static JLabel level;
static JComboBox saleslevel;
static JLabel productname;
static JComboBox product;
static JButton salesmandone;
static JButton entrydone;
static JButton calctotal;
static JTextArea output;
static String outp;
static Handler handler = new Handler();
static ArrayList<Salesman> myList = new ArrayList<Salesman>();
static NumberFormat currencyFormat = NumberFormat.getCurrencyInstance();

//Creates GUI and adds ActionListeners.
public Sales()
{
super("Monthly Sales");
setDefaultCloseOperation(EXIT_ON_CLOSE);
Container c = getContentPane();
c.setLayout(new FlowLayout());

salesmanlabel = new JLabel("Salesman:");
salesmanname = new JTextField(20);
amtsold = new JLabel("Amount Sold:");
amount = new JTextField(20);
level = new JLabel("Sales Level:");
saleslevel = new JComboBox();
productname = new JLabel("Product Sold:");
product = new JComboBox();
salesmandone = new JButton("Salesman Entry Done");
entrydone = new JButton("All Data Entry Done");
calctotal = new JButton("Grand Total");
output = new JTextArea(300, 300);

product.addItem("");
product.addItem("Product 1");
product.addItem("Product 2");
product.addItem("Product 3");
product.addItem("Product 4");
product.addItem("Product 5");

saleslevel.addItem("");
saleslevel.addItem("Entry");
saleslevel.addItem("Junior");
saleslevel.addItem("Senior");

c.add(salesmanlabel);
c.add(salesmanname);
c.add(amtsold);
c.add(amount);
c.add(level);
c.add(saleslevel);
c.add(productname);
c.add(product);
c.add(salesmandone);
c.add(entrydone);
c.add(calctotal);
c.add(output);
 
output.setVisible(true);
output.setRows(15);
output.setColumns(25);

salesmandone.addActionListener(handler);
entrydone.addActionListener(handler);
calctotal.addActionListener(handler);
}
 
//Creates the JFrame and runs the method readFileData().
public static void main (String args[])
{
Sales sale = new Sales();
sale.setSize(300,400);
sale.setVisible(true);

readFileData();
}

[B]//Reads data from an existing text file and cacualtes a salesmans total sales.
public static void readFileData()
{
String line;
Classification bonus;

try
{
FileReader file = new FileReader("SalesData.txt");
BufferedReader buff = new BufferedReader(file);


while ((line = buff.readLine())!= null)
{
String[] elements = line.split("&");
String name = elements [0];
double sales = 0.0;
double sales1 = 0.0;
double sales2 = 0.0;
double sales3 = 0.0;
double sales4 = 0.0;
double sales5 = 0.0;

sales1 = Double.parseDouble(elements[1]) * 2.98;
sales2 = Double.parseDouble(elements[2]) * 4.50;
sales3 = Double.parseDouble(elements[3]) * 9.98;
sales4 = Double.parseDouble(elements[4]) * 4.49;
sales5 = Double.parseDouble(elements[5]) * 6.87;

bonus = Classification.valueOf(elements[6]);
 
sales = (sales1 + sales2 + sales3 + sales4 + sales5);

sales = sales + (sales * bonus);

myList.add(new Salesman(name, sales));
}
buff.close();
}
catch(IOException ioe)
{
ioe.printStackTrace();
}
}[/B] 
//Implements three ActionListeners to three different buttons on the GUI.
public static class Handler implements ActionListener
{
public void actionPerformed(ActionEvent e)
{
if(e.getSource() == salesmandone)
{
addSalesman();
}
else if(e.getSource() == entrydone)
{
writeFileData();
}
else if(e.getSource() == calctotal)
{
readObjectData();
}
}
}

//Sorts the names of salesman, if a name is already in the ArrayList then the name is not created again,
//instead the additional information is added to the one name.
public static Salesman getSalesman(String salesman)
{
for (Salesman salesm : myList)
{
        if (salesman.equals(salesm.getName()))
        {
             return salesm;
         }
     }
return null;
}

[B]//Adds each Salesman name and sales to the ArrayList
public static void addSalesman()
{
try
{
double sales = calculateSales(product.getSelectedIndex(), Integer.parseInt(amount.getText()));

if (getSalesman(salesmanname.getText()) != null)
{
getSalesman(salesmanname.getText()).addToSales(sales);
}
else
{
myList.add(new Salesman(salesmanname.getText(), sales));
}
 
salesmanname.setText("");
product.setSelectedIndex(0);
amount.setText("");
salesmanname.requestFocus();
}
catch(ArithmeticException ae)
{
JOptionPane.showMessageDialog(this, name + "has no Sales!!", "Sales equals Zero",
JOptionPane.WARNING_MESSAGE);
}
}[/B]
//Calculates each salesman's sales and bonus and then returns that total to addSalesman() to be entered in the ArrayList.
public static double calculateSales(int product,int amount) throws ArithmeticException
{
double sales1;
double sales = 0.0;

product++;

switch(product)
{
case 2:   sales1 = (amount * 2.98);
break;
 
case 3:   sales1 = (amount * 4.50);
break;

case 4:   sales1 = (amount * 9.98);
break;

case 5:   sales1 = (amount * 4.49);
break;

case 6:   sales1 = (amount * 6.87);
break;
 
default: sales1 = (0.00);
}

if(saleslevel.getSelectedItem().equals("Entry"))
{
sales = sales1 + (sales1 * .05);
}
else if(saleslevel.getSelectedItem().equals("Junior"))
{
sales = sales1 + (sales1 * .10);
}
else if(saleslevel.getSelectedItem().equals("Entry"))
{
sales = sales1 + (sales1 * .15);
}

return sales;
}

//Writes the ArrayList data as objects to Salesman.data.
public static void writeFileData()
{
try
{
ObjectOutputStream oos = new ObjectOutputStream(new FileOutputStream("Salesman.data"));
     
try
{
for (Salesman s : myList)
{
oos.writeObject(s);
}
}
finally
{
oos.close();
}
}
catch(IOException ioe)
{
            ioe.printStackTrace();
        }
}
 
//Reads the data in Salesman.data as objects and puts that data into a vector which then sorts the Salesman in alphabetical
//order and then displays the data in the texatarea.
public static void readObjectData()
{
try
{
ObjectInputStream ois = new ObjectInputStream(new FileInputStream("Salesman.data"));

try
{
Vector<Salesman> salesmanList = new Vector<Salesman>();

Salesman salesman;
while ((salesman = (Salesman) ois.readObject()) != null)
{
salesmanList.add(salesman);

StringBuilder builder = new StringBuilder("\tTOTAL SALES\n\n");
 
double total = 0.00;

Collections.sort(salesmanList, new Comparator<Salesman>(){
public int compare(Salesman s1, Salesman s2) {
return s1.getName().compareTo(s2.getName());}});

for (Salesman s : salesmanList)
{
builder.append(s.toString() +"\n");
total += s.getSales();
}
    
builder.append("\nTotal\t\t       " + currencyFormat.format(total));

output.setText(builder.toString()); 
}
}
finally
{
ois.close();
}
}
catch ( IOException ioException )
{      
ioException.printStackTrace();
}      
catch (ClassNotFoundException cnfe)   
{      
cnfe.printStackTrace();   
}
}
}

Classification:

public enum Classification
{
ENTRY(.05),
JUNIOR(.10),
SENIOR(.15);

private double bonus;

Classification(double b)
{
bonus = b;
}
public double getBonus()
{
return bonus;
}
public void setBonus(double b)
{
bonus = b;
}
}

NoSalesException:

import javax.swing.*;
 
public class NoSalesException extends ArithmeticException
{
public NoSalesException()
{
super("Sales equals zero");
}
public NoSalesException(String message)
{
super(message);
}
}

[ March 23, 2006: Message edited by: Holly Leery ]
[ March 23, 2006: Message edited by: Holly Leery ]