indexOf or Pattern Matcher faster/better?

[Brad Walton]

I am just curious as to which of these would be faster, and/or recommended?

eventAction.endsWith("has disconnected")

or

Pattern p = Pattern.compile("has disconnected$");
Matcher m = p.matcher(evenAction);

There will be a LOT of this going on in the program, on many different patterns.

Thanks

[Jeanne Boyarsky]

Brad,
What happened when you tried it?

In general it is good to go with what is clearer (which is the first one) unless it proves to be a performance problem.

[Brad Walton]

Hi Jeanne, thanks for the reply. Both work fine to accomplish the task. I haven't timed these examples, so I am not sure which is faster. But timing this alone wouldn't answer my question anyway. My question was more general, because there will be so many different pattern matches that will be going on in rapid succession, continually, in the program. I was inquiring about whether one method is faster to process than the other, in general.

As far as code clarity, they both seem about the same to me. Maybe the pattern seems a little clearer, but that's because I'm more of a regex person (from Perl programming). But I don't really see that as being a factor in my decision in this case.

[Henry Wong]

This topic came up before -- as I remeber writing a test to compare indexof and regex....

If memory serves, I remember... If the search string is large, like 100000 characters, then indexof wins. And if the search string is small, like 100 characters, then regex wins. (compilation of the regex was not part of the test -- regex was precompiled)

Henry

[Brad Walton]

Thanks Henry. That's what I was looking for.