problem with method "validRoomNumber

[Pepo moussa]

i got a problem with this method which suppose to read a string and check a room number if the 1st letter is upper case or a number and the rest of the room is digits it should return true else false
i do not know what is wrong really but i keep getting error saying else without if so anyone can help

    
private static boolean isValidRoomNumber(String text) 
   {
   StringTokenizer st = new StringTokenizer(text,"|");

if (st.countTokens()==3)
{
String bu = st.nextToken();  
String ro = st.nextToken();

   char chr =ro.charAt(0);
   boolean test1=Character.isUpperCase(chr);
   boolean test2=Character.isDigit(chr);
   
   if(test1==true || test2==true)
   {
   for (int i = 1;i < text.length();i++) 
   {

                         if(Character.isDigit(ro.charAt(i))==true)
     return true;
else
            return false;
       }//for
     
   }//if test
   }// if 
   else 
   return false;
   
  
   }//isValidRoomNumber
  
 

[Ravikanth kolli]

hi
i think the problem is with the return and not with the if else statements. The final else part returns the value false, but in the if the value is returned if the inner if and the for loop is executed. If they are not executed it is not returning anything. check that out and see if that works..

I could not find any other errors with the paranthesis...

[Pepo moussa]

that is my final code nothing with no error but it does not work as i wane it to work ? any idea

         private static boolean isValidRoomNumber(String text) 
   {
   StringTokenizer st = new StringTokenizer(text,"|");

if (st.countTokens()==3)
{
String bu = st.nextToken();  
String ro = st.nextToken();

   char chr =ro.charAt(0);
   boolean test1=Character.isUpperCase(chr);
   boolean test2=Character.isDigit(chr);
   boolean test3=true;
   
   
   for (int i = 1;i < ro.length();i++) 
   {
if(Character.isDigit(ro.charAt(i))==true)
test3=true;
else
       test3=false;
       }//for
   
    
   if(test1==true || test2==true && test3==true)
   
   return true;
 
   }// if
   return false;
 
  
   }//isValidRoomNumber

[Pepo moussa]

hello anyone ..i need help :roll:

[marc weber]

How are you testing this?

[Pepo moussa]

oh well have example if the string "A123" its true or "123" also true the 1st letter has to be capital or a digit and the rest of the string has to digits so string like that "a123" should not work and return false, or "A123a" also wrong and the method should return false.

[marc weber]

Originally posted by I moussa:
oh well have example if the string "A123" its true or "123" also true the 1st letter has to be capital or a digit and the rest of the string has to digits so string like that "a123" should not work and return false, or "A123a" also wrong and the method should return false.

Yes, but what happens when you test using these examples?

For example, how would "A123" be split by this tokenizer? And what would happen if there aren't exactly 3 tokens?
[ March 22, 2008: Message edited by: marc weber ]

[Pepo moussa]

oh my bad i posted the tokenizer i was not using it anyway, now i finally got my code working

private static boolean isValidRoomNumber(String text) 
   {
 

   char chr =text.charAt(0);
   boolean test1=Character.isUpperCase(chr);
   boolean test2=Character.isDigit(chr);
   boolean test3=true;
   
   for(int i=1;i<text.length();i++)
   {
   if(Character.isDigit(text.charAt(i))==true)
   {
   test3=true;
   }
   else
   {
   test3=false;
break;
   }
       }//for
   
     if ((test1==true || test2==true) && test3==true)
   {
   return true;
   }
   else
   return false;

   }//isValidRoomNumber

[Pepo moussa]

the problem was at my testing i was testing it the wrong way :S