FTP Client Problem

[Peter Phung]

I'm writing a FTPClient application, but i keep getting this exception:
java.lang.NullPointerException
at sun.net.TransferProtocolClient.sendServer(TransferProtocolClient.java:99)
at sun.net.ftp.FtpClient.issueCommand(FtpClient.java:160)
at sun.net.ftp.FtpClient.openDataConnection(FtpClient.java:218)
at sun.net.ftp.FtpClient.get(FtpClient.java:315)
at archivetool.FTPClientDialog.getFile(FTPClientDialog.java:579)
at archivetool.FTPClientDialog.access$100(FTPClientDialog.java:22)
at archivetool.FTPClientDialog$3.run(FTPClientDialog.java:202)
the strange thing about this is that the application stops running at line 579, as can be seen above, which is in the middle of a method which performs the same get operation twice. The application performs the operation correctly the first time but not the second time.
Here's my code:

 
    private boolean getFile(int CGM) {
byte[] buffer = new byte[BUFFER_SIZE];
try {
     taDisplay.appendText("\nFile "+fName+": size unknown");
    FileOutputStream out = new FileOutputStream(fName);
    InputStream in = client.get(fName);
    int counter = 0;
    while (true) {
int bytes = in.read(buffer);
if (bytes < 0) {
    break;
}
out.write(buffer, 0, bytes);
counter += bytes;
        int kb = counter/1024;
setProgressString(kb+" KB");
    }
    out.close();
    in.close();
    System.out.println(fName);
    System.out.println(cgmName);
    if (CGM==1) {
taDisplay.appendText("\nFile "+cgmName+": size unknown");
FileOutputStream out1CGM = new FileOutputStream(cgmName);
//Application stops running at the line below
InputStream in1CGM = client.get(cgmName);
counter = 0;
while (true) {
    int bytes = in1CGM.read(buffer);
    if (bytes < 0) {
break;
    }
    out1CGM.write(buffer, 0, bytes);
    counter += bytes;
       int kb = counter/1024;
    setProgressString(kb+" KB");
}
System.out.println("4");
out1CGM.close();
in1CGM.close();
    }
    taDisplay.appendText("\nTransfer complete");
}
catch (Exception e) {
    e.printStackTrace();
    return false;
}
return true;
    }
 

Please can someone help me with this

[Mark Herschberg]

I didn't go through the code thoroughly, but I have two comments.
First, you're referencing an external object, client. It may make sense, but it also means something could be happening outside the method which is effecting it.
Second, consider using the Linlyn code, http://www.cs.uwplatt.edu/classes/se273/comm/ftpcomm.html If you use this, be warned, the basic code creates a byte array, and when the array gets filled, it creates a new one, twice the size, and copies thje contents from one to another. In this way, it's very inefficient. If you have any knowledge about the size of the data, you can make it much more efficent with only a few minutes of work.
--Mark

[Peter Phung]

Unfortunately my work requires me to use only packages and classes released by sun.
I've posted all of the methods which use client below :

 
    private boolean connect() {
fileStruct();
setCursor(Cursor.getPredefinedCursor(Cursor.WAIT_CURSOR));
try {
    taDisplay.setText("");
    String user = tfUserName.getText();
    String vn = "IP-ADDRESS";
    taDisplay.appendText("Connecting to host "+vn);
    client = new FClient(vn);
    client.login(user, pw);
    taDisplay.appendText("\nUser "+user+" login OK");
}
catch (IOException e) {
    System.out.println("Could Not Connect");
    e.printStackTrace();
    setCursor(Cursor.getPredefinedCursor(Cursor.DEFAULT_CURSOR));
    return false;
}
return true;
    }
    private boolean setDirectory(String ulDL) {
if (ulDL.equals("download")) {
    try {
client.cd(dir);
                client.binary();
    }
    catch (IOException ex) {
System.out.println("couldn't change directory");
ex.printStackTrace();
return false;
    }
} else if (ulDL.equals("upload")) {
    try {
client.cd(dir);
                client.binary();
    }
    catch (IOException f) {
try {
    client.cd("peterTest/"+pdp);
    client.mkDir(partNumber);
    client.cd(partNumber);
    client.binary();
}
catch (IOException g) {
    try {
client.mkDir("peterTest/"+pdp);
client.mkDir("peterTest/"+pdp+"/"+partNumber);
client.cd(dir);
client.binary();
    }
    catch (IOException h) {
h.printStackTrace();
setCursor(Cursor.getPredefinedCursor(Cursor.DEFAULT_CURSOR));
return false;
    }
}
    }
}
return true;
    }
 

I've spent ages going over the code but i cant find the problem.
Please can someone help
Thanks

[Peter Phung]

Any help would be apreciated