Problem with Double!!!!!!

[joe kane]

HI, I cant seem to get this working I know its something small,

import javax.swing.JOptionPane;
public class Main_1 {
  
    public static void main(String[] args) {
        
        
String choice;
String choice1, choice2, choice3;
double num1;
double num2;
double num3;
double totals;

choice1 = JOptionPane.showInputDialog("Enter Grade 1");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 1");
}
while ( !choice.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 1");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 1");
}}
    
num1 = Double.parseDouble (choice1);
        
double result1 = methodone(num1);
choice2 = JOptionPane.showInputDialog("Enter Grade 2");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 2");
}
while ( !choice.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 2");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 2");
}}
    
num2 = Double.parseDouble (choice2);
        
double result2 = methodtwo(num2);
choice3 = JOptionPane.showInputDialog("Enter Grade 3");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 3");
}
while ( !choice.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 3");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 3");
}}
    
num3 = Double.parseDouble (choice3);
        
double result3 = methodthree(num3);
totals = methodtotals(result1, result2, result3);
}
    
//------------------------------------------------------------------------------
public static void totals(){
    
    JOptionPane.showMessageDialog(null,"Results"+result1+""+result2+""+result3);
  
}
//------------------------------------------------------------------------------
public double methodone(int x){
    
return ((int)(x * 0.3));
    
}
//------------------------------------------------------------------------------
//------------------------------------------------------------------------------
public double methodtwo(int x){
    
return (x * 0.4);
    
}
//------------------------------------------------------------------------------

//------------------------------------------------------------------------------
public double methodthree(int x){
    
return (x * 0.3);
    
}}
//---------------------------------------------------  

Thanks loads in advance joe Kane..

[Timmy Marks]

some of the first things that I see is that your methods are not static at the bottom of your code, you are passing 3 values in your call to methodtotals/totals (which expects none), you are assigning the results of this method to a variable (the method is void), your methods are expecting int values instead of doubles, and the method is called totals and you are calling it as methodtotals.
The very first thing that I see when reading the code is that you do basically the same thing three times and you have the code in there three times. I would like to recommend the book Refactoring: Improving the Design of Existing Code which is an excellent book detailing how to get rid of such redunduncies.
If you solve the above problems and it still doesn't work, I will look more into it. Hope this helps

[joe kane]

Hi, Pls excuse the code,
Here is the code:

 import javax.swing.JOptionPane;
public class Main_1 {
  
    public static void main(String[] args) {
        
        
String choice;
String choice1, choice2, choice3;
double num1;
double num2;
double num3;
int totals;

choice1 = JOptionPane.showInputDialog("Enter Grade 1");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 1");
}
while ( !choice.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 1");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 1");
}}
    
num1 = Double.parseDouble (choice1);
        
double result1 = methodone(num1);
choice2 = JOptionPane.showInputDialog("Enter Grade 2");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 2");
}
while ( !choice.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 2");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 2");
}}
    
num2 = Double.parseDouble (choice2);
        
double result2 = methodtwo(num2);
choice3 = JOptionPane.showInputDialog("Enter Grade 3");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 3");
}
while ( !choice.matches("[0-9]+" ) ){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 3");
while (choice == null){
JOptionPane.showMessageDialog(null,"Error, Numbers only");
choice = JOptionPane.showInputDialog("Enter Grade 3");
}}
    
num3 = Double.parseDouble (choice3);
        
double result3 = methodthree(num3);
double tot = methodtotals(result1, result2, result3);
}
    
//------------------------------------------------------------------------------
public static double methodtotals(){
    
    JOptionPane.showMessageDialog(null,"Results"+result1+""+result2+""+result3);
  
}
//------------------------------------------------------------------------------
public static double methodone(double x){
    
return (x * 0.3);
    
}
//------------------------------------------------------------------------------
//------------------------------------------------------------------------------
public static double methodtwo(double x){
    
return (x * 0.4);
    
}
//------------------------------------------------------------------------------

//------------------------------------------------------------------------------
public static double methodthree(double x){
    
return (x * 0.3);
    
}}
//--------------------------------------------------- 

Thank joe Kane

[Timmy Marks]

notice that here:

choice1 = JOptionPane.showInputDialog("Enter Grade 1");

you are initializing choice1, but here:

while (choice == null){

you are testing choice