Non-Default Constructor problem

[celine mcgowan]

Hi All,

I wonder if you could help me. I have the following code, which creates a JPanel with a 'Figure of eight' formation of gifs to represent an LED:

  
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
 
public class LED extends JPanel{
    JLabel toph;//Top Horizontal: Lit
    JLabel midh;//Middle Horizontal: Lit
    JLabel both;//Bottom Horizontal: Lit
 
    JLabel tlv;//Top Left Vertical: Lit
    JLabel trv;//Top Right Vertical: Lit
    JLabel blv;//Bottom Left Vertical: Lit
    JLabel brv;//Bottom Right Vertical: Lit
 
public LED(){
 
toph = new JLabel(new ImageIcon("horiz_unlit.gif"));
midh = new JLabel(new ImageIcon("horiz_unlit.gif"));
both = new JLabel(new ImageIcon("horiz_unlit.gif"));
tlv = new JLabel(new ImageIcon("vertical_unlit.gif"));
blv = new JLabel(new ImageIcon("vertical_unlit.gif"));
brv = new JLabel(new ImageIcon("vertical_unlit.gif"));
trv = new JLabel(new ImageIcon("vertical_unlit.gif"));
}
 

        public LED(int bin){

//point the labels to the gifs.
if( (bin & 1) == 0){
        toph = new JLabel(new ImageIcon("horiz_lit.gif"));
}
else{
toph = new JLabel(new ImageIcon("horiz_unlit.gif"));
}

if((bin & 64 )== 0){
midh = new JLabel(new ImageIcon("horiz_lit.gif"));
}
else{
midh = new JLabel(new ImageIcon("horiz_unlit.gif"));
}
 
if((bin & 8) ==0){
both = new JLabel(new ImageIcon("horiz_lit.gif"));
}
else{
both = new JLabel(new ImageIcon("horiz_unlit.gif"));
}
 
if((bin & 32) == 0){
tlv = new JLabel(new ImageIcon("vertical_lit.gif"));
}
else{
tlv = new JLabel(new ImageIcon("vertical_unlit.gif"));
}

if((bin & 2) == 0){
trv = new JLabel(new ImageIcon("vertical_lit.gif"));
}
else{
trv = new JLabel(new ImageIcon("vertical_unlit.gif"));
}
 
if((bin & 16)0){
blv = new JLabel(new ImageIcon("vertical_lit.gif"));
}
else{
blv = new JLabel(new ImageIcon("vertical_unlit.gif"));
}
 
if((bin & 4) == 0){
brv = new JLabel(new ImageIcon("vertical_lit.gif"));
}
else{
brv = new JLabel(new ImageIcon("vertical_unlit.gif"));
}
 

 
//Set up a panel to put the gifs in.
//Top Panel: Makes a 'Square' of the gifs
JPanel topPanel = new JPanel();
        topPanel.setLayout(new BorderLayout());
 
        topPanel.add(toph, BorderLayout.NORTH); //add the top bar of led       
topPanel.add(tlv, BorderLayout.WEST); //add top left vertical bar   
topPanel.add(trv, BorderLayout.EAST); //add top right vertical bar
                topPanel.add(midh, BorderLayout.SOUTH); //add 'middle' horizontal bar
                
                //Bottom Panel: Makes a topless square
                JPanel bottomPanel = new JPanel();
                bottomPanel.setLayout(new BorderLayout());
                
                bottomPanel.add(blv, BorderLayout.WEST);
                bottomPanel.add(brv, BorderLayout.EAST);
                bottomPanel.add(both, BorderLayout.SOUTH);
                
//Add top & bottom panels to LEDPanel
JPanel ledPanel = new JPanel();
                ledPanel.setLayout(new BorderLayout());
        ledPanel.add(topPanel, BorderLayout.NORTH);
        ledPanel.add(bottomPanel, BorderLayout.CENTER);
 

//add the whole panel to the window
                setLayout(new BorderLayout());
        add(ledPanel);        
setBorder(BorderFactory.createEmptyBorder(20,20,20,20));
    }   
 

public static void main (String[] args){
int[] test = {1,0,0,1,0,0,0};
        JFrame frame = new JFrame("LED??!");
        frame.addWindowListener(new WindowAdapter(){
            public void windowClosing(WindowEvent e){                
System.exit(0);            
}        
});            

frame.setContentPane(new LED(test));
        frame.pack();
        frame.setVisible(true);
    }

}

When i try to call this from another class, eg:

  LED myLed = new LED( 2 )

I get a compilation error: Method not found: Constructor LED( int ).

Obviously there is a constructor LED(int) in the LED class. Why can't other classes see it?

Thanks a million,
Celine

[Francis Siu]

hi celine
I have interested to test your program.
In your situation, the compiler can not find out the constructor in the LED class, but can find out the LED class.
Method not found: Constructor LED( int ).
Cound you test the following that you wrote the constructor which overrides the default one?

 LED myLed = new LED(); 

If the compiler can not find out this constructor too, then you can remove both of these constructor and let the compiler find out the default one.
I wonder if you can tell me the result after testing the above procedure
Hope to find out some interesting event

[pascal betz]

hi

you do not pass an

int

but an

int[]

to the Constructor. and there is no Constructor accepting an

int[]

.
I did not read your code so i dont know which is wrong (wether you need to pass an array or an int) but you need to change one of them...

pascal

[celine mcgowan]

Hi Pascal & Siu

Thanks for your help. Sorry Pascal, please ignore the 'main' method in class LED. I am calling constructor new LED( int ) from another class.

Siu, i tried your suggestion & i the default constructor is found. No error message is received. Now i'm really confused!!!

Thanks again,
Celine

[pascal betz]

then please show the code where you call it (and remove the main method since ot wont compile with that)

p

[Hans Achternaam]

Hi Celine,

I copied and compiled the code and had no problem with. Including the constructor call from another class.

BTW are you using a Sun SDK ? This shouldn't matter but since you get an error saying LED( int ) and not LED(int) I just wonder. I'm getting the last error when trying to call a constructor which takes an int and the compiler can not find it. Try this in your class: new LED(1) instead of new LED( 1 )

[celine mcgowan]

Hi Hans,
Yeah, i'm using SunONE Studio. Spaces like this would make a difference? Oh no!!! The people in the cattle drive won't like me taking them out!!
Haha! I'll try that now - thank you all very much for your help.

Hi Again Pascal,
Here's the code calling the LED( int ) constructor:

 import javax.swing.*;
import java.awt.*;
import java.awt.event.*;
 
public class testLED extends JFrame
{
    public LEDPanel led;
    public testLED()
    {
        super( "LED TEST" );
        int bars = 2;
        led = new LEDPanel( bars );
        JPanel myPanel = new JPanel( );
        myPanel.add( led );
        
        
        this.getContentPane().add( myPanel );
        this.pack();
        this.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        this.setVisible(true);
    }
    
    public static void main( String [] args )
    {
        new testLED();
    }
}
 

Thanks again,
Celine

[Hans Achternaam]

Nope, spaces should not make a difference.
Your (new posted) code compiles also without a problem here.

Sorry, no idea what the problem is.
[ August 18, 2004: Message edited by: Hans Achternaam ]

[Francis Siu]

Spaces like this would make a difference? Oh no!!!

Give us five words, "We never do that again"
Of course, I seldom do it.

[fred rosenberger]

I don't see in your code where you are calling the LED(int) constructor. I see you calling a LEDPanel, but i don't see where that is defined.

i was able to get your code to compile by changing the lines

public LEDPanel led;
...
led = new LEDPanel( bars );

to

public LED led;
...
led = new LED( bars );

[Francis Siu]

ar...yes
error message should be: Method not found: Constructor LEDPanel( int ).
Or
class not found: LEDPanel
[ August 18, 2004: Message edited by: siu chung man ]