Simple login form project - all attributes are null and HTTP Status 404 error in some cases

[K. Karacakaya]

That gives only Bachelor's Degree because I have 3 users and all of them has Bachelor's Degree.

[K. Karacakaya]

Oh so sorry I got that and fixed it. Now it gives Bachelor's Degree in combo box.

[Paul Ngom]

Copy and paste this in EditPage.jsp. You are to replace what is in between the <td> and </td>

<td> <select name="degree">  
  <option value="Associate Degree" <%=(((String)session.getAttribute("degree"))!=null && ((String)session.getAttribute("degree")).equals("Associate Degree"))?" selected":""%>>Associate Degree</option>  
  <option value="Bachelor's Degree" <%=(((String)session.getAttribute("degree"))!=null && ((String)session.getAttribute("degree")).equals("Bachelor's Degree"))?" selected":""%>>Bachelor's Degree</option>  
  <option value="Master's Degree" <%=(((String)session.getAttribute("degree"))!=null && ((String)session.getAttribute("degree")).equals("Master's Degree"))?" selected":""%>>Master's Degree</option>  
  <option value="Doctoral Degree" <%=(((String)session.getAttribute("degree"))!=null && ((String)session.getAttribute("degree")).equals("Doctoral Degree"))?" selected":""%>>Doctoral Degree</option>  
  </select></td>  

and tell if the combo changes.

[Paul Ngom]

Ok, fine. What is the next error message you are having?

[K. Karacakaya]

Only HTTP Status 404 message left. It appears when I clicked on SignUp then "Submit", or after logged in Edit then "Submit".

[Paul Ngom]

Let us amend Edit.java first. Replace the method doGet by doPost and remove the other doPost. And don't you think there is a problem with this code?

// Get product information from request.getParameter()  
String un = (String)session.getAttribute("un");  
session.setAttribute("un", un);  
String pass = (String)session.getAttribute("pass");  
session.setAttribute("pass", pass);  
String name = (String)session.getAttribute("name");  
session.setAttribute("name", name);  
String surname = (String)session.getAttribute("surname"); //request.getParameter  
session.setAttribute("surname", surname);  
String email = (String)session.getAttribute("email");  
session.setAttribute("email", email);  
String degree = (String)session.getAttribute("degree");  
session.setAttribute("degree", degree);  

you are receiving from the session and back to the session. I think you should rather issue request.getParameter() on those attributes.

[K. Karacakaya]

Should I use request.getParameter in that part instead of session.getAttribute? Sessions look complicated to me I couldn't figure out how they work.

[Paul Ngom]

Should I use request.getParameter in that part instead of session.getAttribute?

Yes, make that modification. Hope you have also replaced the doGet.

[K. Karacakaya]

Yes. I change doGet method name to doPost, delete other doPost, and use request.getParameter.

[Paul Ngom]

In EditPage.jsp, you said you have an error 404 when you hit the submit button. Do you have the Edit.class in the right directory? It uses EditDetails.class, LoginDao.class and UpdateUser.class as well. So make sure those files are in the right directories.

[K. Karacakaya]

It should be in the right directory (I think). In my first post there is a screenshot of my project explorer.

[Paul Ngom]

Have you compiled the .java files?

[K. Karacakaya]

Yeah there are no errors for all my .javas. It is almost 02 AM here so bed time for me

[Paul Ngom]

Another thing, since you do not use LoginDao in Edit.java and Registration.java, you can remove this in those files.

import com.amzi.dao.LoginDao;

[Paul Ngom]

Ok. Good night and catch you tomorrow.
Regards

[K. Karacakaya]

I copied and pasted most of the import part from LoginServlet. That is why Edit and Registration have import com.amzi.dao.LoginDao. I deleted them now.

[Paul Ngom]

Good morning,
Do you still have the error 404 on Edit servlet that is called from EditPage.jsp?

[K. Karacakaya]

Good morning Paul,
Yeah I have still status 404 error. May it be because of my form actions? If I post here every URL that appears in browser box, will it help you to find out the problem?

[Paul Ngom]

rather post Edit.java servlet.

[K. Karacakaya]

Here it is:

package com.amzi.servlets;

import java.io.IOException;
import java.io.PrintWriter;

import com.amzi.dao.EditDetails;
import com.amzi.dao.UpdateUser;

import javax.servlet.RequestDispatcher;
import javax.servlet.ServletException;
import javax.servlet.annotation.WebServlet;
import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;


/**
* Servlet implementation class UpdateCustomerServlet
*/
@WebServlet("/UpdateCustomerServlet")

public class Edit extends HttpServlet {
private static final long serialVersionUID = 1L;

/**
* @see HttpServlet#HttpServlet()
*/
public Edit() {
super();
// TODO Auto-generated constructor stub
}

/**
* @see HttpServlet#doGet(HttpServletRequest request, HttpServletResponse response)
*/
protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {
// TODO Auto-generated method stub
int return_code;

try {
// Get the PrintWriter object
HttpSession session = request.getSession(true);
PrintWriter writer = response.getWriter();
writer.write("<html><body>");

// Get product information from request.getParameter()
String un = request.getParameter("un");
session.setAttribute("un", un);
String pass = request.getParameter("pass");
session.setAttribute("pass", pass);
String name = request.getParameter("name");
session.setAttribute("name", name);
String surname = request.getParameter("surname"); //request.getParameter
session.setAttribute("surname", surname);
String email = request.getParameter("email");
session.setAttribute("email", email);
String degree = request.getParameter("degree");
session.setAttribute("degree", degree);

// If "UPDATE" button is clicked
if (request.getParameter("submit") != null) {
// Create an instance of ProductBean object
EditDetails editdetails = new EditDetails();
// Set the attribute values for the newly created object
editdetails.setUn(un);
editdetails.setPass(pass);
editdetails.setName(name);
editdetails.setSurname(surname);
editdetails.setEmail(email);
editdetails.setDegree(degree);


// Invoke the ProductBeanDAO's updateProduct() method
UpdateUser updateuser = new UpdateUser();
return_code = updateuser.updateUserMethod(editdetails);

if (return_code != 0)
writer.write("UPDATE successful!<br><br>");
else
writer.write("UPDATE failed!<br><br>");
writer.write("<a href=\"EditPage.jsp\">Back</a> to Product Search Page.");

}

writer.write("</body></html>");
} catch (Exception ex) {
System.out.println("Error: " + ex.getMessage());
}
}
}

[Paul Ngom]

I see no problem with the code. Try to reload the page in browser when the error appears and see if you get the same error. Also post the url.

[K. Karacakaya]

It is still the same. URL: http://localhost:8080/loginpage/Edit

[Paul Ngom]

stop and restart the glassfish server. Call Edit servlet directly from browser using the url that you provided previously. Tell what happens

[K. Karacakaya]

This time it gives 405, when i directly run edit.java
HTTP Status 405 - HTTP method GET is not supported by this URL

type Status report

messageHTTP method GET is not supported by this URL

descriptionThe specified HTTP method is not allowed for the requested resource (HTTP method GET is not supported by this URL).

GlassFish Server Open Source Edition 3.1.2

[Paul Ngom]

Now log in your web app, navigate to the EditPage.jsp and hit the submit button for the current record. Tell then what happens

[K. Karacakaya]

Again Status 404

[Paul Ngom]

To be frank if your compiled servlets are in their right directories, i cannot find why it not working. You can create a new topic in forum and see if somebody can help so that we can advance.

[K. Karacakaya]

Okay Paul I will. And thanks so much for your help. You helped me a lot.

[Paul Ngom]

All is well. As soon as that problem is solved, we could then proceed with the rest. Try to give a detail explanation of the problem in your post.

[Paul Ngom]

Please make your sign up page SignUpPage.jsp to look like this:

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">  
<html>  
<head>  
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">  
<title>Insert title here</title>  
</head>  
<body>  
<h2> Sign Up </h2>  
<hr>  
<form name="frm1" action="Registration" method="post">  
Username: <input type = "text" name = "un"> <br>  
Password: <input type = "password" name = "pass"> <br>  
Retype Password: <input type = "password" name = "pass2"> <br>  
Name: <input type = "text" name = "name"> <br>  
Surname: <input type = "text" name = "surname"> <br>  
E-mail: <input type = "text" name = "email"> <br>  
University Degree: <select name="degree">  
  <option value="none" selected>-</option>  
  <option value="Associate Degree">Associate Degree</option>  
  <option value="Bachelor's Degree">Bachelor's Degree</option>  
  <option value="Master's Degree">Master's Degree</option>  
  <option value="Doctoral Degree">Doctoral Degree</option>  
</select>  
<br>  
<input type = "button" value = "Back" name = "back1" onclick = "JavaScript:window.location='NewFile.jsp';">  
<input type = "submit" value = "Submit" name = "submit1">  
</form>  
  
</body>  
</html>  

[K. Karacakaya]

I corrected but still same. By the way I have created a new topic as you said. If you wanna follow, link is https://coderanch.com/t/634035/Servlets/java/HTTP-Status-Error-basic-login

[K. Karacakaya]

Hey Paul again,
I'm searching to solve this status 404 problem for days. And most problems solved with some web.xml changes about servlet and servlet-mapping. Is my glass fish-web.xml correct (it is created automatically and I didn't change anything)? Should I add sty there? Because <servlet> tag is not working there.

[Paul Ngom]

Should I add sty there?

I think you can leave it as it is.

[K. Karacakaya]

Hi Paul,
When I click on Submit button after sign up process. This page appears:

And for a logged in user, after editing information and clicking on Submit button. This page appears:


Also there is no change in database too.

[Paul Ngom]

Let us deal with Edit first. Inside that servlet, this test is done:

if (request.getParameter("submit") != null) {

there is no field having the name 'submit' in EditPage.jsp. It should rather be submit1

[K. Karacakaya]

Yeah I corrected. Now console shows an error: Error: Error: Parameter index out of range (1 > number of parameters, which is 0).

[Paul Ngom]

I found this in UpdateUser.java

pst = conn  
                .prepareStatement("UPDATE users.pass, users.name, users.surname, users.email, users.degree");  
            pst.setString(1, editdetails.getUn());  
            pst.setString(2, editdetails.getPass());  
            pst.setString(3, editdetails.getName());  
            pst.setString(4, editdetails.getSurname());  
            pst.setString(5, editdetails.getEmail());  
            pst.setString(6, editdetails.getDegree());  
  

The query is not well done. It should be

pst = conn  
                .prepareStatement("update users set pass=?, name=?, surname=?, email=?, degree=? where un=?");  
           
            pst.setString(1, editdetails.getPass());  
            pst.setString(2, editdetails.getName());  
            pst.setString(3, editdetails.getSurname());  
            pst.setString(4, editdetails.getEmail());  
            pst.setString(5, editdetails.getDegree());  
            pst.setString(6, editdetails.getUn()); 

Try that and let us know the outcome.

[K. Karacakaya]

Now it says:
UPDATE failed!

Back to Edit Page.
(I changed error message before).

It is because of return_code = 0. And it has never never changed in UpdateUser.java. It looks like some part of the code is missed.

[Paul Ngom]

Let us debug. Add these lines in Edit.java just after session.setAttribute("degree",degree):

writer.write(un+" <br>");
writer.write(pass+" <br>");
writer.write(name+" <br>");
writer.write(surname+" <br>");
writer.write(email+" <br>");
writer.write(degree+" <br>"); 

and see if all values are correctly passed.

[K. Karacakaya]

null
null
alifakms
yavuzcais
[email protected]
Doctoral Degree
UPDATE failed!

Back to the Edit Page.