Trying to create OO based bank app

[Campbell Ritchie]

Don't have time to read all that code, but initial amount to open an account does not belong in a keyboard input class.
Find out what SOLID means in OO programming. A lot of people no longer believe the O bit, but they do believe S. That means the account class takes case of its minimum, not the input class. There is however nothing wrong with an input method which insists on the amount being in a particular range.
You should design input from a Scanner not to use Exceptions, nor Integer.parseInt. Please search my posts for Scanner, utility class, etc. You should find enough there to enable you to create such a utility class. Beware: there is an error somewhere. And I haven't told you where.

[Tushar Goel]

Thanks Campbell, i read about SOLID and learnt new things but having same doubt on 'L' part. I will again read tonight and trying to get things clear.

You should design input from a Scanner not to use Exceptions, nor Integer.parseInt. Please search my posts for Scanner, utility class,

Checked your previous posts and accordingly corrected.. Thanks Campbell for pointing...

there is an error somewhere. And I haven't told you where.

I have double checked and found few of things which i have corrected now:

1) use of AtominBoolean instead i am using static flag
2) I used map as instance variable but instead i make it static
3) data storing, instead of defining here i have defined another utility class names StoreData which have a static method. I will call this method whenever i able to successfully create account and customer object and passed that data to it.
4) In another utility class which is taking input , i defined private constructor so that instance can not be created.
5) Also in that class i have changed method which taking amount as a input. removed minimum criteria and also improve so that it can receive amount > 0.


Are these one you talking about or i missed something?




Updated Bank class:


/**
*
*/

package onlinebanking;

import org.apache.commons.collections.BidiMap;
import org.apache.commons.collections.bidimap.DualHashBidiMap;

public class Bank {

	// us to store accounts and customer. Use to store two way access of map
	private static BidiMap accounts = new DualHashBidiMap();
	
	// store the condition whether to app continue or exit
	private static boolean isContinue = true;
	
	
	/**
	 * This method will start bank services. It will show available option to the
	 * customer and to make a choice. 1. Create new account 2. Deposit Money
	 * 3. Withdraw money 4. Update Customer Details 5. Exit
	 * As per user choice related service will be called and if user entered 5
	 * then it will set the continue flag to false so that program can be terminated. 
	 * Once user ask for termination it will save the state into the file so that next
	 * time when user comes back it can find all details including account number.
	 */
	protected void startBankServices() {

	    while (isContinue) {
			
			//it will show menu
			showMenu();
			
			//reading user choice as per services provided
			int choice = 
				  Integer.valueOf(MyUtilities.getUserInput("Enter your choice: "));
		    
		    //this method will check the user selected option and
		    //do as per it
			readUserChoice(choice);
		}

	    System.out.println("Thanks for using it");
	}

	/**
	 * This method will invoke the respective operation as per user input
	 * 
	 * @param choice   user selected choice
	 */
	protected void readUserChoice(int choice) {
		
		switch(choice) {
		   
		case 1: 
				 createNewAccount();
				 break;
				 
		case 2:
				 //depositeMoney();
				 System.out.println("In deposit");
				 break;
		case 3: 
				 //withdrawMoney();
				 System.out.println("In withdraw");
				 break;
		case 4:
			     //updateCustomerDetails();
				 System.out.println("In update customer detail");
			     break;
		case 5:   		 
			     //exit from the program
		   		isContinue = false;
		   		break;
	     			     
	    default:
	    		 System.out.println("Invalid choice. Please select between(1-5)");
	    		 break;
		}
		
	}

	/**
	 * This method will take customer detail to open a new account.
	 */
	private void createNewAccount()  {
	
		System.out.println("Welcome to XYZ bank, please enter your details:");
		
		// taking customer name
	    String name = MyUtilities.getUserInput("Enter your  name: ");
	    
		//taking customer date of birth
 		String dateOfBirth = 
 				MyUtilities.getCustomerDateOfBirth("Enter date of birth (mm/dd/yyyy): ");
 		
		//taking amount from the user
 		int initialAmount  = 
 				MyUtilities.getUserEnteredAmount("Select amount (should be greater than 0): ");
			
		 System.out.println(name + " " + dateOfBirth + " " + initialAmount);
	 	
		
	//	Customer customer = generateCustomer(name, dateOfBirth);
//		Account  account  = generateAccount(initialAmount, AccountType.SAVING);

		//store customer and account in map
	//	accounts.put(account, customer);
	 			    
		//StoreData.storeData(account, customer);		
	}

	/**
	 * This method will display the menu option to the user
	 */
	private void showMenu() {
		
		System.out.println("********************************************");
		System.out.println("*        1.  Create new account            *");
		System.out.println("*        2.  Deposite money                *");
		System.out.println("*        3.  Withdraw money                *");
		System.out.println("*        4.  Update customer details       *"); 
		System.out.println("*        5.  Exit                          *");
		System.out.println("********************************************");
		
	}
}

MyUtility Class

package onlinebanking;

import java.util.Scanner;
import java.util.regex.Pattern;

public class MyUtilities {

	private final static Scanner INPUT_SCANNER = new Scanner(System.in);
	
	// date format which needs to be taken by the customer
	private final static String REGEX = "\\d\\d/\\d\\d/\\d\\d\\d\\d" ;
	
	private MyUtilities() {
		
	}
	
	/**
	 * This method will take user input. It will check whether user entered empty string or
	 * data. If user entered empty string then it will keep asking until it received it.
	 * 
	 * @param message   type of data is required (What is  your name, date of birth etc)
	 * @return  input   input entered by the user
	 */
	public static String getUserInput(String message) {
		
		String input = "";
		
		while (input.trim().isEmpty()) {
			
			//display what data is required
		    System.out.print(message);	
		    
		    input = INPUT_SCANNER.nextLine();;
		}
		
		return input;
	}
	
	/**
	 * This method will receive integer value. Value must be greater than 0 else
	 * it will keep asking for the same.
	 * 
	 * @param      message   type of data is required (What is  your name, date of birth etc)
	 * @return     value     value entered by the customer
	 */
	public static int getUserEnteredAmount(String message) {

		int value = 0;
	
		 while (value <= 0) {
			 
			 System.out.println(message);
			 value = INPUT_SCANNER.nextInt();
		 }
		
			return value;
	}
	
	/**
	 * This method receives the date of birth of the customer and compare
	 * with the dd/mm/yyyy format. If it is not in desired format then 
	 * it will again asked for the date of birth.
	 * 
	 * @param message   type of data is required (What is  your name, date of birth etc)
	 * @return  inputDateOfBirth  date of birth
	 */
	public static String getCustomerDateOfBirth(String message) {
		
		String inputDateOfBirth = "";
				
		while (!Pattern.matches(REGEX, inputDateOfBirth)) {
			inputDateOfBirth = getUserInput(message);
		}
		
		return inputDateOfBirth;
	}
}	

[Campbell Ritchie]

Tushar Goel wrote: . . .

there is an error somewhere. And I haven't told you where.

. . .Are these one you talking about . . .

No. Most of those things you described do look suspicious, and I suspect some of your changes have made them worse, but I meant an error somewhere in what I wrote. It shouldn't be too difficult to find if you read the whole thread.

[Tushar Goel]

I suspect some of your changes have made them worse

I thought they were good. Please tell me what went wrong..

I meant an error somewhere in what I wrote

I think there is possibility of this reference escape before account constructor creates.. Is it correct ? I am also trying to think any other error..

[Campbell Ritchie]

I mentioned the error after I said to search. If you search as I said, then you are likely to find the error. At least the error I know about

The bit about letting a this reference escape is not an error.

[Tushar Goel]

I searched again and read yours and other posts and also i read category UserInput , i think now you are referring to the case in which user entered input in wrong format. All others methods
except nextLine() method in Scanner class throws InputMismatchException if user entered input in wrong format.

Is this one you referring to? I tried hard to think about it and thought this only.

Also Thanks you, i come across very good posts and article related to Scanner/Utility class while searching for it. Thanks again..

This is the modified utility class:

package onlinebanking;

import java.util.Scanner;
import java.util.regex.Pattern;

/**
 * @author etusgoe
 *
 */
public final class MyUtilities {

	private final static Scanner INPUT_SCANNER = new Scanner(System.in);
	
	// date format which needs to be taken by the customer
	private final static String REGEX = "\\d\\d/\\d\\d/\\d\\d\\d\\d" ;
	
	private MyUtilities() {
		
	}
	
	/**
	 * This method will take user input. It removed the unwanted spaces as well from the 
	 * input which can be entered by user wrongly.
	 * 
	 * @param message   type of data is required (What is  your name, date of birth etc)
	 * @return  input   input entered by the user
	 */
	private final static String getUserInput(String message) {
		
		    //display what data is required
		    System.out.print(message);	
		    
		    return INPUT_SCANNER.nextLine().trim();
	}
	
	/**
	 * This method will take the namer from the user. If the name is empty it will
	 * inform user about invalid input and asked again for the valid name.
	 * 
	 * @param prompt type of data is required (What is  your name, date of birth etc)
	 * @return Name of the customer
	 */
	public final static String getUserName(String prompt) {
		
		 String name ;
		 
		 while ((name = getUserInput(prompt)).trim().isEmpty()) {
			 
			 System.out.println("Invalid name");
		 }
		 
		 return name;
		
	}
	/**
	 * This method validates the input entered by the user. If user enters nothing (just entered it)
	 * or entered any amount less than or equal to 0 then it will show invalid amount and ask again
	 * to enter correct amount.
	 * 
	 * @param      message   type of data is required (What is  your name, date of birth etc)
	 * @return     value     value entered by the customer
	 */
	public final static Integer getUserEnteredAmount(String message) {

		Integer value;
	
		 while ((value = integerOrNull(message)) == null || value <= 0) {
			 System.out.println("Invalid amount");
		 }
			return value;
	}
	
    /**
     * This method will convert amount entered by customer into the Integer. If user
     * enter invalid amount then it returns null.
     * 
     * @param prompt   type of data required from the user
     * @return         Integer object. Value of string into the string if valid. Null if
     * 				   user enters invalid amount
     * @exception  NumberFormatException        When user enters invalid amount null or 
     * 											less than or equal to 0
     */
	private final static Integer integerOrNull(String prompt) {
				
		try {
			return Integer.valueOf(getUserInput(prompt));
		} catch (NumberFormatException e) {
			return null;
		}
		
	}
	
	/**
	 * This method receives the date of birth of the customer and compare
	 * with the dd/mm/yyyy format. If it is not in desired format then 
	 * it will again asked for the date of birth.
	 * 
	 * @param message   type of data is required (What is  your name, date of birth etc)
	 * @return  inputDateOfBirth  date of birth
	 */
	public final static String getCustomerDateOfBirth(String message) {
		
		String inputDateOfBirth = "";
				
		while (!Pattern.matches(REGEX, inputDateOfBirth)) {
			inputDateOfBirth = getUserInput(message);
		}
		
		return inputDateOfBirth;
	}
	
	/**
	 * This method will take a user choice about which bank services it want to
	 * used. It will show invalid choice if user entered anything other than the
	 * number and again ask to re-enter.
	 * 
	 * @param prompt type of data is required (What is  your name, date of birth etc)
	 * @return  value  choice selected by the user
	 */
	public final static Integer getUserChoice(String prompt) {
		
		Integer value ;
		
		while ((value=integerOrNull(prompt)) == null) {
			System.out.println("Invalid choice");
		}
				
		return value;
	}
}	

[Campbell Ritchie]

Tushar Goel wrote: . . . category UserInput , i think now you are referring to the case in which user entered input in wrong format. . . .

No, that wasn't the error I meant. If you search my posts for "Prasanna Raman daft mistake" you might get closer. Hint: restrict your search to posts after 16th January this year. And before 18th January. And read the whole thread.

I have a different opinion of Scanner from Winston's. You need to get to know how Scanner works and you need to let it do its work. You do not need to handle IOExceptions because Scanner does that for you. You do not need to deal with patterns and regexes because Scanner does that all for you. The only Exception you need to worry about is InputMismatchException, and Rob Spoor told me a long time ago that is completely avoidable. You use Scanner's methods and Scanner's methods only and you get a method which takes an int from the command line/terminal and repeats the prompt until a valid int is entered. Look through the methods of Scanner and see if you can work out how to do it. Probably better to return an int than an Integer.
You can overload that method to accept an int in a particular range. You can overload that message to display a custom error message. You put all those methods in a utility class. You work out whether that class will be thread‑safe or not without synchronisation.

Then you read what it says in the books about nextLine, and there is a good chance it will be wrong. The post I hope you have found now, with or without daft mistakes, and this post (minus the rant) will tell you what nextLine actually does. You should by now know how to write a static method which returns the next “full” line, i.e. the next line returned from the nextLine method for which trim().isEmpty() returns false. You can use that to get name entry. Because you are using that utility class as a universal resource, it should be in its own package. It should not have things like "invalid name" in. In fact you will get no error messages from this sort of code:-

int i = KeyboardInputs.intFromKeyboard("Enter ...");
int j = KeyboardInputs.intFromKeyboard("Enter ..."));
int k = KeyboardInputs.intFromKeyboard("Enter ..."));
String name = KeyboardInputs.lineFromLeyboard"Enter name");

…for all the following inputs123 456 789 Campbell Ritchie123 456 789 Campbell Ritchie123 456 789 Campbell RitchieThe Scanner will simply ignore the excess whitespace and your method will silently skip the empty lines.
Since you are using that class as a universal resource you want to create methods to get doubles, BibDecimal, BigIntegers, etc from the keyboard similarly. Now you have a universal resource, you can use it for the banking app.

[Winston Gutkowski]

Campbell Ritchie wrote:I have a different opinion of Scanner from Winston's.

Very true.

You need to get to know how Scanner works and you need to let it do its work.

And that's basically it.

You do not need to handle IOExceptions because Scanner does that for you.

Agreed.

You do not need to deal with patterns and regexes because Scanner does that all for you.

And so does Integer, or Double, or whatever type you want to get from a String - including custom ones. So why would you want to use one approach just for the types that Scanner provides, and a different one for all the others?

I doubt we'll ever agree on this one.

Probably better to return an int than an Integer.

Not necessarily; and specifically not from integerOrNull(). After that, it very much depends whether you actually need an int or not. After all, there's no point in unboxing unnecessarily.

@Tashar: The methodology I describe in UserInput is by no means the only way to do it; I just find it easier. I mainly wrote the article to get you thinking about the business of input - ie, the validation loops.

If you decide you prefer Campbell's idea of using Scanner's own methods and learning the class properly, I'd be the last person to suggest you don't.

Winston

[Paweł Baczyński]

I think using static flags is not a good idea.
What if you have two instances of Bank class?

[Campbell Ritchie]

Winston Gutkowski wrote: . . . Very true.

Because there are always several ways to do things in computing and there are several correct ways to do it.

. . . So why would you want to use one approach just for the types that Scanner provides, and a different one for all the others? . . .

Because that approach will deal with 95% of all your keyboard inputs and you can write custom classes for all the others. Scanner provides input for all the primitive types and the two BigXXX classes in the java.math package.

. . .
Not necessarily; . . .

I did say probably, not definitely

[Campbell Ritchie]

When I wrote: . . . Scanner provides input for all the primitive types . . .

… I knew it was't true. There is no nextChar method (or at least there wasn't last time I looked). You would have to use next().charAt(0) but that is a bit like System.in.read() which I warn people against using.


Would Winston and I agree on that?

Another thing about using the hasNextXXX methods of Scanner: they allow you to inspect the next token and you can then request new input and completely obviate the need for Exception handling. You can even obviate NumberFormatExceptions

String s;
do
{
   s = ...;
   Scanner scan = new Scanner(s);
} while (!scan.hasNextInt()); //end do
int i = Integer.parseInt(s);

[Tushar Goel]

@Campbell.. I crack it. Thanks to you and Rob...

I have made little bit other changes to remove that alternate line display issue. In getNumber() method i used while instead of do-while.

It should be good now..

	

    public static final String userInput(String prompt) {
	 
		  String value ;
		  System.out.print(prompt);
		  while ((value = INPUT.nextLine()).trim().isEmpty()) {
			
			  System.out.print(prompt);
		  }
		  
		  return value;
     }

    public static final int getNumber(String prompt) {
		  
		  System.out.print(prompt);
		  
		   while (!INPUT.hasNextInt()) {
			   System.out.print(prompt);
			   INPUT.next();
		   }

		   return INPUT.nextInt();
	  }

	  

@Winston there are several correct way to achieve a common task. So both of you shared 2 separate way to achieve a common task. It is just which one is clicked... Thanks for the article.. It clear some of my doubts.

@Pawel Actually i was confused between to make a app as single threaded or multi-threaded. So initially i set it as instance variable and later changed it to static. But i think i should revert back to instance case.. Thanks for suggestion...

[Campbell Ritchie]

Well done

I would call the method getInt not getNumber. I suggest you only need to print the prompt once in the getLine method and you might consider printing an error message like "Incorrect format for number: please try again: " in line 20.
You realise that lines 20 and 21 can be swapped round without any difference in output?

I suggest you start with a single‑threaded app at present. Only add threading if you need it. See this recent thread.

[Tushar Goel]

Well done

Thanks Campbell. though it took little longer but it got me learn several things..

I would call the method getInt not getNumber. I suggest you only need to print the prompt once in the getLine method

Corrected

You realise that lines 20 and 21 can be swapped round without any difference in output?

Yeah, no as such difference observed

I suggest you start with a single‑threaded app at present

ok.

After that i have modified by bank class.. Please check if it is ok..

package onlinebanking;

import org.apache.commons.collections.BidiMap;
import org.apache.commons.collections.bidimap.DualHashBidiMap;
import org.utility.KeyboardInput;


/**
 * @author etusgoe
 *
 */
public class Bank {

	// us to store accounts and customer. Use to store two way access of map
	private static final BidiMap accounts = new DualHashBidiMap();
	
	// store the condition whether to app continue or exit
	private boolean isContinue = true;
	
	
	/**
	 * This method will start bank services. It will show available option to the
	 * customer and to make a choice. 1. Create new account 2. Deposit Money
	 * 3. Withdraw money 4. Update Customer Details 5. Exit
	 * As per user choice related service will be called and if user entered 5
	 * then it will set the continue flag to false so that program can be terminated. 
	 * Once user ask for termination it will save the state into the file so that next
	 * time when user comes back it can find all details including account number.
	 */
	protected void startBankServices() {

	    while (isContinue) {
			
			//it will show menu
			showMenu();
			
			//reading user choice as per services provided
			int choice = MyUtilities.getUserChoice("Enter your choice: ");
		    
		    //this method will check the user selected option and
		    //do as per it
			readUserChoice(choice);
		}

	    System.out.println("Thanks for using it");
	}

	/**
	 * This method will invoke the respective operation as per user input
	 * 
	 * @param choice   user selected choice
	 */
	protected void readUserChoice(int choice) {
		
		switch(choice) {
		   
		case 1: 
				 createNewAccount();
				 break;
				 
		case 2:
				 //depositeMoney();
				 System.out.println("In deposit");
				 break;
		case 3: 
				 //withdrawMoney();
				 System.out.println("In withdraw");
				 break;
		case 4:
			     //updateCustomerDetails();
				 System.out.println("In update customer detail");
			     break;
		case 5:   		 
			     //exit from the program
		   		isContinue = false;
		   		break;
	     			     
	    default:
	    		 System.out.println("Invalid choice. Please select between(1-5)");
	    		 break;
		}
		
	}

	/**
	 * This method will take customer detail to open a new account.
	 */
	private void createNewAccount()  {
	
		System.out.println("Welcome to XYZ bank, please enter your details:");
		
		// taking customer name
	    String name = KeyboardInput.getUserName("Enter your  name: ");
	    
		//taking customer date of birth
 		String dateOfBirth = 
 				KeyboardInput.getCustomerDateOfBirth("Enter date of birth (mm/dd/yyyy): ");
 		
		//taking amount from the user
 		int initialAmount  = 
 				KeyboardInput.getInt("Select amount (should be greater than 0): ");
			
		 System.out.println(name + " " + dateOfBirth + " " + initialAmount);
	 	
		
	//	Customer customer = generateCustomer(name, dateOfBirth);
//		Account  account  = generateAccount(initialAmount, AccountType.SAVING);

		//store customer and account in map
	//	accounts.put(account, customer);
	 			    
		//StoreData.storeData(account, customer);		
	}

	/**
	 * This method will display the menu option to the user
	 */
	private void showMenu() {
		
		System.out.println("********************************************");
		System.out.println("*        1.  Create new account            *");
		System.out.println("*        2.  Deposite money                *");
		System.out.println("*        3.  Withdraw money                *");
		System.out.println("*        4.  Update customer details       *"); 
		System.out.println("*        5.  Exit                          *");
		System.out.println("********************************************");
		
	}
}

[Tushar Goel]

Utility class:

/**
*
*/

package org.utility;

import java.util.Scanner;
import java.util.regex.Pattern;

/**
 * @author etusgoe
 *
 */
public final class KeyboardInput {

	  private final static Scanner INPUT = new Scanner(System.in);
	  
	  // date format which needs to be taken by the customer
	  private final static String REGEX = "\\d\\d/\\d\\d/\\d\\d\\d\\d" ;
		
	  private KeyboardInput () {
		  
	  }
	  
	  /**
	   * This method will receive a input as a string and keep asking till 
	   * user enters some length string. If string is empty then it will
	   * keep asking for it.
	   * 
	   * @param prompt type of data is required (What is  your name, date of birth etc)
	   * @return  value   String input entered
	   */
	  public static final String userInput(String prompt) {
		  
		  String value ;

		  System.out.print(prompt);
		  
		  while ((value = INPUT.nextLine()).trim().isEmpty()) {
			  	System.out.println("Not a valid input. Please try again.");
			  	System.out.print(prompt);
		  }
		  
		  return value;
	  }
	  
	/**
	 * This method validates the input entered by the user. If user enters any number
	 * in invalid format then it will again ask for the input.
	 * 
	 * @param      message   type of data is required (What is  your name, date of birth etc)
	 * @return     value     amount entered by the customer
	 */
	public static final int getInt(String prompt) {
		  
		  System.out.print(prompt);
		  
		   while (!INPUT.hasNextInt()) {
			   System.out.println("Not a number. Please enter again");
			   System.out.print(prompt);
			   INPUT.next();
		   }

		   return INPUT.nextInt();
	  }
	
	/**
	 * This method will take the name from the user. If the name is empty it will
	 * inform user about invalid input and asked again for the valid name.
	 * 
	 * @param prompt type of data is required (What is  your name, date of birth etc)
	 * @return Name of the customer
	 */
	public final static String getUserName(String prompt) {

		return userInput(prompt);		
	}	
	
	/**
	 * This method receives the date of birth of the customer and compare
	 * with the dd/mm/yyyy format. If it is not in desired format then 
	 * it will again asked for the date of birth.
	 * 
	 * @param message   type of data is required (What is  your name, date of birth etc)
	 * @return  inputDateOfBirth  date of birth
	 */
	public final static String getCustomerDateOfBirth(String prompt) {
		
		String inputDateOfBirth = "";

		inputDateOfBirth = userInput(prompt);
		
		while (!Pattern.matches(REGEX, inputDateOfBirth)) {
	   	    System.out.println("Not a valid date of birth. Please enter again.");
	   	    inputDateOfBirth = userInput(prompt);
		}
		
		return inputDateOfBirth;
	}
}

[Campbell Ritchie]

The user name and date of birth methods don't belong in a utility class. The idea of the utility class is that you can use it for input for everything you write, not simply the banking app. You might do well have a generalised date method there which returns a LocalDate object, however.
Unless you own the website www.utility.org you should use a different package name. Package names are described in the Java Tutorials.

[Winston Gutkowski]

Tushar Goel wrote:@Winston there are several correct way to achieve a common task. So both of you shared 2 separate way to achieve a common task. It is just which one is clicked... Thanks for the article.. It clear some of my doubts.

Glad it helped; and, as Campbell said: WELL DONE.

As (I hope) you're starting to discover, there is no one "right" way to do things, which is why it's so important to understand WHAT you're doing (ie, the process involved), not HOW you intend to do it (the code).

Code is cheap, and can almost always be changed; what you're doing can't. Classes and objects and interfaces are mostly about 'what'; and the reason we have all these SOLID rules is so that if you don't like how you've done something, you can rip it out and start again.

For more information, you might try the WhatNotHow (←click) page.

Winston

[Tushar Goel]

which is why it's so important to understand WHAT you're doing (ie, the process involved), not HOW you intend to do it (the code).

This what i am learning from you guys and cannot be done without you guys help.. Thanks again to you, Campbell and other folks which helping us time to time...

[Campbell Ritchie]

You're welcome
I see you are putting the bank together bit by bit. I think that is the correct way to do it. I suggest your Maps should be parametrised classes. Not Map but Map<Customer, Account> or maybe Map<List<Customer>, List<Account>>

[Campbell Ritchie]

But remember what I said earlier about mutable types in Maps.

At least I think I said something earlier.

[Tushar Goel]

But remember what I said earlier about mutable types in Maps.

Yes you told me about bi directional map and i am going to use Account and Customer as a attribute in this..

date method there which returns a LocalDate object

I am using 1.7 and do not have rights to install 8 as i am using my current employer laptop but will search for alternative..

the user name and date of birth methods don't belong in a utility class

Corrected

Unless you own the website www.utility.org you should use a different package name

corrected

If everything is fine till date (except dateOfBirth method which i correct soon) should i start working on customer class or anything i still missed in Bank class?

[Campbell Ritchie]

Tushar Goel wrote: . . .
Yes you told me about bi directional map and i am going to use Account and Customer as a attribute in this..

Remember what happens if keys in a Map change their hash codes.

. . .
I am using 1.7 and do not have rights to install 8 as i am using my current employer laptop but will search for alternative..

Look for Joda Time. It is supposed to be good, but I haven't used it myself.

. . . should i start working on customer class or anything i still missed in Bank class?

You appear to be working on the create account method. That needs a Customer and an Account, so you will have to implement thsoe two classes before you can finish that method.

[Tushar Goel]

Remember what happens if keys in a Map change their hash codes.

Yes, i need to make sure that account and customer object have unique hash code and that can be achieved using unique account and customer id...

You appear to be working on the create account method

I started earlier but i stopped and thought to go in slow space and concentrate on one class first.. I have not done anything till now.

Ok, so should i start with customer class first and meantime i will read about Joda time.?

[Campbell Ritchie]

You decide whcih class you are going to create first.
Create the classes as standalone apps, possibly with their own main methods each, as it tells you not to do here. Put code in those main methods to test all the methods of the class. Then you will know the class works


Then you can get rid of the unnecessary main methods, maybe by changing their access to private.

[Tushar Goel]

I have added date method in utility class. I have one doubt here, if i passed directly string as below it always showing month as Jan but Year and day is same as i passed. I dont understand why?

String date = .... ;

DateTimeFormatter dtf = DateTimeFormat.forPattern("dd-MMM-yy");
LocalDate localDate = dtf.parseLocalDate(date);
System.out.println(localDate);  

To overcome this i need to split the string by delimiter and create a local object and passed each of the part into this. Then it working fine...

	public final static LocalDate getDate(String prompt) {
		
		String inputDate = "";

		do {
			System.out.print(prompt);
			inputDate = INPUT.nextLine().trim();
		} while (!Pattern.matches(REGEX, inputDate));

		//split the string with delimiter '-'
		String []number = inputDate.split("-");
		
		//creating an local date object and pass integer value of it
		LocalDate localDate = new LocalDate(Integer.parseInt(number[2]),
												Integer.parseInt(number[1]),
													Integer.parseInt(number[0]));
		
		return localDate;
    }

	public static final int getInt(String prompt) {
		
		  System.out.print(prompt);
		  
		   while (!INPUT.hasNextInt()) {
			   System.out.println("Not a number. Please enter again");
			   System.out.print(prompt);
			   INPUT.next();
		   } 

		   int value = INPUT.nextInt();
		   
		   // to remove enter key from the int output
		   INPUT.nextLine(); 
		   
		   return value;
	  }

Also i tried to test my utility class. This is my first attempt to use JUnit...

/**
 * 
 */
package test;

import static org.junit.Assert.*;

import org.joda.time.format.DateTimeFormat;
import org.joda.time.format.DateTimeFormatter;
import org.junit.Test;

import utility.KeyboardInput;

/**
 * @author etusgoe
 *
 */
public class BankClassTest {

	/**
	 * Test method for {@link utility.KeyboardInput#userInput(java.lang.String)}.
	 */
	@Test
	public void testUserInput() {
		assertEquals("Result: ", "Tushar", KeyboardInput.userInput("Enter you name: "));
	}

	/**
	 * Test method for {@link utility.KeyboardInput#getInt(java.lang.String)}.
	 */
	@Test
	public void testGetInt() {
		assertEquals("Result: ", -1, KeyboardInput.getInt("Enter amount: "));
		assertEquals("Result: ", 0, KeyboardInput.getInt("Enter amount: "));
		assertEquals("Result: ", 11, KeyboardInput.getInt("Enter amount: "));
	}

	/**
	 * Test method for {@link utility.KeyboardInput#getDate(java.lang.String)}.
	 */
	@Test
	public void testGetDate() {
		DateTimeFormatter dateTimeFormat = DateTimeFormat.forPattern("dd-MMM-yy");
		
		assertEquals("Result:", "06-Jan-86", 
				 dateTimeFormat.print(KeyboardInput.getDate("Enter date in dd-mm-yyyy format:")));
		assertEquals("Result:", "06-Nov-90", 
				 dateTimeFormat.print(KeyboardInput.getDate("Enter date in dd-mm-yyyy format:")));
		assertEquals("Result:", "06-Dec-90", 
				 dateTimeFormat.print(KeyboardInput.getDate("Enter date in dd-mm-yyyy format:")));
	}

}

[Campbell Ritchie]

If you are using Scanner why use Integer.parseInt? That risks throwing a NumberFormatException and the idea of those loops with Scanners is to get rid of all Exceptions.
Go through the Scanner documentation and see whether there is any way to get a date out of it. (I couldn't find anything.)

You can create a Scanner to scan a String, and tokenise that String. Then you can inspect the tokens and you can obviate the Exception like this:-

String input;
Scanner textScan;
boolean readProperly;
int i;
int j;
int k;
System.out.print("Please enter ...");
do
{
   input = ...;
   textScan = new Scanner(input);
   textScan.setDelimiter(...);
   readProperly = textScan.hasNextInt();
   if (readProperly)
   {
      i = textScan.nextInt();
   }
   readProperly = readProperly && textScan.hasNextInt();
   if (readProperly)
   {
      j = textScan.nextInt();
   }
   readProperly = readProperly && textScan.hasNextInt();
   if (readProperly)
   {
      k = textScan.nextInt();
   }
   else
   {
      System.err.printf(
            "Text entered \u201c%s\u201d incorrect format: please try again: ",
             input);
   }
} while (!readProperly);

That is crude code which I knocked together in two minutes, so you can probably improve it. You know that Calendar.JANUARY ≠ 1, I presume?

Totaly different approach.
Google for Toedter and Calendar applet. Toedter has a calendar applet which you call and you get a popup with a date picker on. You highlight July 2014 and 5 and you get a Date object returned.

[Campbell Ritchie]

You will have difficult with asserting equals between

"06-Jan-86"

and a

date in dd-mm-yyyy format

[Tushar Goel]

That risks throwing a NumberFormatException and the idea of those loops with Scanners is to get rid of all Exceptions.

Actually, i am thinking, it may not throw any number format exception.. I already using a loop which will capture all the wrong input and only correct input goes to parse method....
May be i am wrong or have not done enough testing?

private final static String REGEX = "\\d\\d-\\d\\d-\\d\\d\\d\\d" ;

loop:

          do {
			System.out.print(prompt);
			inputDate = INPUT.nextLine().trim();
		} while (!Pattern.matches(REGEX, inputDate));

	  //split and conversion code

Testing:
Enter date of birth (dd-mm-yyyy): ee-ee-eeee
Enter date of birth (dd-mm-yyyy): qq-ee-qqqq
Enter date of birth (dd-mm-yyyy): 11-ee-111
Enter date of birth (dd-mm-yyyy): 11-11-2002

output: 11-Nov-2002

Though i will try to do it your way as well...

You will have difficult with asserting equals between

Thanks, i will modify it to dd-mm-yyyy but when i tested there was not problem. After receiving input in mm-dd-yyyy formnat, i am changing it to dd-mm-yy and then comparing it.
But i think that's not a good way. So will change it.. Thanks...

[Campbell Ritchie]

The more ways you try, the more chance there is of finding the best way

[Tushar Goel]

Agreed.. Silly me..

I am away for 2 days and get back on monday. I will paste updated code then...

[Tushar Goel]

I mixed both of us idea and come up this method. do-while loop accepts the input in correct format and then with scanner methods
i get day , month and year details. This will help to avoid any input mismatch exception and i think better then my previous
version:

	public final static LocalDate getDate(String prompt, String delimiter) {
		
          		
		String inputDate = "";
		int day;
		int month;
		int year;

               // loop to accept input in correct format only.
		do {
			System.out.print(prompt);
			inputDate = INPUT.nextLine().trim();
		} while (!Pattern.matches(REGEX, inputDate));

		Scanner scanner = new Scanner(inputDate);
		
		//split the string with delimiter '-'
               scanner.useDelimiter(delimiter);
        
                //getting day , month and year details from the input entered by the user
		day = scanner.nextInt();
		month = scanner.nextInt();
		year = scanner.nextInt();
		
		//creating an local date object and pass integer value of it
		LocalDate localDate = new LocalDate(year, month, day);
		scanner.close();
		
		return localDate;	
    }

[Campbell Ritchie]

Why are you only using hyphen as a delimiter? You can set up a regex which will accept space, punctuation etc or a combination as a delimiter. Then you can pass 7/7/14, 7.7.14, 7:7:14, 07-07-14, 07 07 14 etc and they can all be recognised. This part of the Java® Tutorials will probably help you.
If you are feeling really ambitious, you can accept words and get them with a Map

Map<String, Integer> DateMap = new XYZMap<>(48); //Four Strings per month=48
DateMap.put("Ja", LocalDate.JANUARY);
DateMap.put("Jan", LocalDate.JANUARY);
DateMap.put("January", LocalDate.JANUARY);
// etc
DateMap.put("12", LocalDate.DECEMBER);

Have you confirmed that January == 1 for LocalDate?

[Tushar Goel]

Why are you only using hyphen as a delimiter?

Sorry, i was not able to think it make more generic

This part of the Java® Tutorials will probably help you.

Thanks.. It helped me to make it more generic. They are like Perl. I did work on some perl 2 years back but forget about it now.

 // date format which needs to be taken by the customer
 private final static String REGEX = "\\d\\d\\W\\d\\d\\W\\d\\d\\d\\d" ;

public final static LocalDate getDate(String prompt) {

        
        String inputDate = "";  
        int day;  
        int month;  
        int year;  
        boolean isValidFormat ;
  
        System.out.print(prompt);  
        
        // loop to accept input in correct format only.  
        do {  
            inputDate = INPUT.nextLine().trim();
            isValidFormat = Pattern.matches(REGEX, inputDate);
            
            if (!isValidFormat) {
            	System.err.printf("Input \u201c%s\u201d incorrect format. Please try again:", inputDate);
            }
        
        } while (!isValidFormat);  
  
        Scanner scanner = new Scanner(inputDate);  
          
        //split the string with delimiter 
         scanner.useDelimiter("\\W");  
          
         //getting day , month and year details from the input entered by the user  
        day = scanner.nextInt();  
        month = scanner.nextInt();  
        year = scanner.nextInt();  
          
        //creating an local date object and pass integer value of it  
        LocalDate localDate = new LocalDate(year, month, day);  
        scanner.close();  
          
        return localDate;     
    }  
	

If you are feeling really ambitious, you can accept words and get them with a Map

Thanks for the way but may implement it later

Have you confirmed that January == 1 for LocalDate?

No, they are not.. We need to use Month class which have static variable as JANUARY. Just for your information, i am using joda time
They are methods available from which we can get specific date,month in integer or string format. There are so much available to read
but i read some part of it only.

[Campbell Ritchie]

Getting along nicely

I would have used something like [\\p] or [\\p\\s] for the separator and \\d{1,2} for the numbers. But \\W looks good. Go back to that tutorial and check. I believe the Java® regular expressions framework is based on Perl, but again not certain.

I suspect that the Java8 time API is based on Joda time; others may know more than me.

[Tushar Goel]

Getting along nicely

Thank you..

I would have used something like [\\p] or [\\p\\s] for the separator and \\d{1,2} for the numbers. But \\W looks good. Go back to that tutorial and check.

I have re-read the tutorial and updated my REGEX part now it is accepting only day upto 1-31 , month 1-12. Also i tried to put a logic to check if user entered correct day
in that month or not. i.e. user can not enter 30 or 31 day for Feb month etc..

	

  private final static String REGEX = "([0-2][1-9]|[123][0]|[3][1])\\W([0][1-9]|[1][0-2])\\W\\d\\d\\d\\d" ;

public final static LocalDate getDate(String prompt) {

        
		//entered string
        String inputDate = "";
        
        //to store particular values enter by use
        int day = 0;  
        int month = 0;  
        int year = 0;  
        
        //to check if input is in correct format
        boolean isValidFormat ;
        
        // to store datetime object created for the month user entered
        DateTime dateTime;
  
        System.out.print(prompt);  
        
        // loop to accept input in correct format only.  
        do {  
            inputDate = INPUT.nextLine().trim();
            isValidFormat = Pattern.matches(REGEX, inputDate);
            
            if (!isValidFormat) {
            	System.err.printf("Input \u201c%s\u201d incorrect format. Please try again:", inputDate);
            } else {
            	
                Scanner scanner = new Scanner(inputDate);  
                
                //split the string with delimiter 
                 scanner.useDelimiter("\\W");  
                  
                 //getting day , month and year details from the input entered by the user  
                day = scanner.nextInt();  
                month = scanner.nextInt();  
                year = scanner.nextInt();  
                  
                //making DateTime object of that particular month in which
                //customer born
            	dateTime = new DateTime(year, month, 1, 0 , 0);
            	
            	//comparing date with the max days available in the month customer
            	//entered. If it is less than the max available day then it warn
            	//the customer and again asked for the input.
            	if (dateTime.dayOfMonth().getMaximumValue() < day) {
            	   System.err.printf("Day \u201c%d\u201d is not available " +
            	                         "in month \u201c%s\u201d. Please enter again" ,
            	                                  day, dateTime.monthOfYear().getAsShortText());
            	   isValidFormat = false;
            	} else {
            		scanner.close();  
            	}
            	
            }
        
        } while (!isValidFormat);  
  
        System.out.println(day + " " + month + " " + year);
       
        //creating an local date object and pass integer value of it  
        LocalDate localDate = new LocalDate(year, month, day);  
        
          
        return localDate;     
    }  

[Campbell Ritchie]

I presume that is part of the keyboard inputs class? Getting better.
I think convention has it that you write private static final rather than private final static but that is only a minor style point. The field might better be called DATE_REGEX; then it is obvious to all reading it what it means.

[Tushar Goel]

I presume that is part of the keyboard inputs class?

Yes, it is.

private static final rather than private final static

Corrected

The field might better be called DATE_REGEX;

Corrected


What should i do next now?

[Campbell Ritchie]

Confirm that every method in the keyboard input class works, for normal and abnormal input. Then you can put it away and use it for all sorts of other applications.

[Tushar Goel]

It seems working fine for me for the inputs i passed.. Though i have 1 doubt here. While testing i found out that nextInt() in getDate method remove leading 0s from the input.
So say if i entered 01 01 1990 then it will remove and give us like 1 1 1990. It seems to be issue with me. Rest is looking fine.

package test;

import static org.junit.Assert.*;

import org.joda.time.format.DateTimeFormat;
import org.joda.time.format.DateTimeFormatter;
import org.junit.Test;

import utility.KeyboardInput;

/**
 * @author etusgoe
 *
 */
public class BankClassTest {

	/**
	 * Test method for {@link utility.KeyboardInput#userInput(java.lang.String)}.
	 */
	@Test
	public void testUserInput() {
		assertEquals("Result: ", "Tushar", KeyboardInput.userInput("Enter you name: "));
	}

	/**
	 * Test method for {@link utility.KeyboardInput#getInt(java.lang.String)}.
	 */
	@Test
	public void testGetInt() {
		assertEquals("Result: ", -1, KeyboardInput.getInt("Enter amount: "));
		assertEquals("Result: ", 0, KeyboardInput.getInt("Enter amount: "));
		assertEquals("Result: ", 11, KeyboardInput.getInt("Enter amount: "));
	}

	/**
	 * Test method for {@link utility.KeyboardInput#getDate(java.lang.String)}.
	 */
	@Test
	public void testGetDate() {
		DateTimeFormatter dateTimeFormat = DateTimeFormat.forPattern("dd-mm-yyyy");
		
		assertEquals("Result:", "15-2-1990", 
				 dateTimeFormat.print(KeyboardInput.getDate("Enter date in dd-mm-yyyy format:")));
		assertEquals("Result:", "16-11-2990", 
				 dateTimeFormat.print(KeyboardInput.getDate("Enter date in dd-mm-yyyy format:")));
		assertEquals("Result:", "26-12-2990", 
				 dateTimeFormat.print(KeyboardInput.getDate("Enter date in dd-mm-yyyy format:")));
	}

}

[Campbell Ritchie]

You would never expect to have leading 0s in numbers.