design pattern DAO

[Philippe Ponceblanc]

Hello Carey,
 I do not know how to thank you. Thank you for your help online,
have arrived at the end of this part of my classrooms site, like youtube with the vocal translation that I will implement later ..

Last error getConnection, we created a static method but it is not recognized by eclipse.

    public void ajouter(Video video) throws DaoException {
        Connection connexion = null;
        PreparedStatement preparedStatement = null;

        try {
            connexion = daoFactory.getConnection(); // error getConnection
            preparedStatement = connexion.prepareStatement("INSERT INTO video(fichier, titre, commentaire) VALUES(?, ?, ?, ?);");
            preparedStatement.setString(1, video.getFichier());
            preparedStatement.setString(3, video.getTitre());
            preparedStatement.setString(4, video.getCommentaire());
            preparedStatement.executeUpdate();
            connexion.commit();
        } catch (SQLException e) {
            try {
                if (connexion != null) {
                    connexion.rollback();
                }
            } catch (SQLException e2) {
            }
            throw new DaoException("Impossible de communiquer avec la base de données SQLException");
        }
        finally {
            try {
                if (connexion != null) {
                    connexion.close();  
                }
            } catch (SQLException e) {
                throw new DaoException("Impossible de communiquer avec la base de données SQLException");
            }
        }

    }

    @Override
    public List<Video> lister() throws DaoException {
        List<Video> videos = new ArrayList<Video>();
        Connection connexion = null;
        Statement statement = null;
        ResultSet resultat = null;

        try {
            
        	connexion = DaoFactory.getConnection(); // error getConnection
            statement = connexion.createStatement();
            resultat = statement.executeQuery("SELECT fichier, titre, commentaire FROM video;");

            while (resultat.next()) {
                
            	String fichier = resultat.getString("fichier");
                String titre = resultat.getString("titre");
                String commentaire = resultat.getString("commentaire");

                Video video = new Video();
                video.setFichier(fichier);
                video.setTitre(titre);
                video.setCommentaire(commentaire);

                video.add(video);
            }
        } catch (SQLException e) {
            throw new DaoException("Impossible de communiquer avec la base de données; SQLException");
        } catch (BeanException e) {
            throw new DaoException("Les données de la base sont invalides: bean");
        }
        finally {
            try {
                if (connexion != null) {
                    connexion.close();  
                }
            } catch (SQLException e) {
                throw new DaoException("Impossible de communiquer avec la base de données : fermeture");
            }
        }
        return videos;
    }

again for add.video i have do like this, tell me if it's a mistacke?

	public void add(Video video) {
		
		this.add(video);
	}

King regards Carey
Philippe

[Carey Brown]

Carey Brown wrote:An add() method is "usually" used to add an instance to a collection. Your collection is a List<Video> whose name is "videos" with a lower case "v". So to add your new "video" instance to your "videos" list you need

                videos.add(video);

(Haven't we been here before?)

The add() method is a method in List. You do not want to create your own add() method.

[Philippe Ponceblanc]

Hi,
after a discussion with a JEE engineer / eclipse french, the latter tells me this:

It certainly would be if you called it, but in VideoDaoImpl you call getConnection (), which does not have the same signature, so it's not the same method.

In fact, the error is in DaoFactory: the getConnection method should not have arguments but use the attributes of the class (values passed to the constructor).

It would be nice to think of a pool of connections as well.

It seems clear to me that the method does not have the same signature!
but past the parameters in the constructor; I do not understand at all !
The connection pool is worse I do not see the code it should apply

[Frits Walraven]

Congratulations Philippe Ponceblanc,

Your question has made it to our Journal.

Have a Cow!