How to merge consecutive values into a range?

[Carey Brown]

Piet Souris wrote:

Carey Brown wrote:I don't understand how P, R, S is a sequence when it is missing the 'Q'.

I asked a question about that. The answer was (if I recall corretly) that these letters are always consecutive. Otherwise I guess it will be even more complex....

I was expecting an output of
201/21P
201/21[R-S]

[kiraz cevik]

Carey Brown wrote:

Piet Souris wrote:

Carey Brown wrote:I don't understand how P, R, S is a sequence when it is missing the 'Q'.

I asked a question about that. The answer was (if I recall corretly) that these letters are always consecutive. Otherwise I guess it will be even more complex....

I was expecting an output of
201/21P
201/21[R-S]

Since Q is in the English alphabet, it's like you wrote it.It is true

[kiraz cevik]

kiraz cevik wrote:

Piet Souris wrote:hi Kiraz,
the map that I created was only meant to be an intermediate result. It was my intention to go on processing. My further ideas were:

create an enum

enum FnalTokenType {
    JUST_A_NUMBER, JUST_A_STRING, ...
}

and have new new Class:

class FinalToken {
    int id;
    String name;
    List<Character> chars;
    FinalTokenType type;
   
    // Constructor et cetera
 
   @Override
    public String toString() {
        if (type = JUS_A_NUMBER || JUST_A_STRING) return name;
        if (chars.length == 1) return name + chars.get(0);
        return name + "[" + chars.get(0) + "-" + chars.get(chars.size() - 1) + "]";
    }
}

Now, I would have a method that processes my intermediate results in the map, and creates a List<FinalToken>. Supose you have this entry in the map:

["300", list = [,A, B, C] ]

Because of the empty char at the start of the list (coming from the Token 300 without any chars) I create two FinalTokens: with 300 and type JUST_A_NUMBER, and 300 with list [A, B, C], with type NUMBER_WITH_ChAR.
The last one will output the toString result: 300[A-C].
So I have a List<FinalToken>. My last step is to go from top to bottom, and when I encounter type JUST_A_NUMBER, I will check if the next couple of elements are also of type JUST_A_NUMBER and have consecutive ints. Then I will output the [300 - 350] form.

Well, sounds more complicated than it is (I hope), but I have not yet had time (or courage) to implement all this (well, I do have the enum).

This was what I had in mind. Wondering if others have come up with someting more simple.
   

Thank you. Do I create an enum class separate from the code you originally wrote?Is the FinalToken class created separately

I am sorry.I'm a beginner in Java, I created the same enum class, but it didn't work.

[Piet Souris]

kiraz cevik wrote:Since Q is in the English alphabet, it's like you wrote it.It is true

But that leads to problems. In your language the Q is missing, so you would interprete [P-S] as [P. R, S], but in the west we would interprete this as [P, Q, R, S]. To prevent problems like this, I suggest that you add the alphabet that is used here, in the correct order. For instance, with such a table and interpreting [P-S] as [P, Q, R, S] we can then see that the Q should not be there. Or maybe an alternative is to define a fixed alphabet that you will use, so that no misundertanding is possible. With one of those possibilities in mind, and suppuse A, B and C are allowed letters, is 1A, 1C possible, or can we rely on letters always being consecutive?

[Piet Souris]

kiraz cevik wrote:I am sorry.I'm a beginner in Java, I created the same enum class, but it didn't work.

Well, my enum was incomplete, I was only showing the idea. Since I only need that to simply see if a FinalToken is just a number (and so can check if we have a sequence of them in the List<FinalToken>, we only need for now just two enum values: JUST_A_NUMBER and OTHER. But if that is not enough, then we can always expand it as necessary. I hope to have time tomorrow to implement the rest of what I described.

[kiraz cevik]

Piet Souris wrote:

kiraz cevik wrote:Since Q is in the English alphabet, it's like you wrote it.It is true

But that leads to problems. In your language the Q is missing, so you would interprete [P-S] as [P. R, S], but in the west we would interprete this as [P, Q, R, S]. To prevent problems like this, I suggest that you add the alphabet that is used here, in the correct order. For instance, with such a table and interpreting [P-S] as [P, Q, R, S] we can then see that the Q should not be there. Or maybe an alternative is to define a fixed alphabet that you will use, so that no misundertanding is possible. With one of those possibilities in mind, and suppuse A, B and C are allowed letters, is 1A, 1C possible, or can we rely on letters always being consecutive?

Thanks
[P-Q-R-S]=[P-S] Must be shaped.
You can always rely consecutive letters.
300A, 301B, 302C =[300-302][A-C] no. This has not to be sorted.  Because it's not serial.
I wanted to remind you.

[Piet Souris]

Had some time to work further on the problem. Almost there, one final thing to do. That is if we have the consecutive Toekns 2, 3, 4, 5 then it should display [2-5]. I also incorporatd that "100/50" comes before "100/100". Don't know if that is necessary, though, but I was busy anyway. It is still a raw version, hardly tested, but here goes:

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Comparator;
import java.util.List;
import java.util.Map;
import java.util.TreeMap;
import java.util.TreeSet;
import static java.util.stream.Collectors.groupingBy;
import static java.util.stream.Collectors.mapping;
import static java.util.stream.Collectors.toCollection;

/**
 *
 * @author Piet
 */
public class KirazCevik {
    public static void main(String... args) {
        String[] piep = {"100/100", "100/50", "1", "2", "2A", "2B", "2C", "3", "3A", "4", "5", 
                        "6", "32C", "32D", "50", "51/1", "51/2", "60", "61", "62", 
                        "200-2E", "200-2F", "200-2G", "200-2H", "201C", "201/21P", 
                        "201/21R", "201/21S","300","300A","301-2A", "542/2K", "542/2L","583-1", 
                        "583-585D", "583-585E", "605", "605A", "605B","605C", "800A"
        };
        
        var firstint = Comparator.comparingInt(KirazCevik::getFirstInt);
        var secondint = Comparator.comparingInt(KirazCevik::getSecondInt);
        var comparator = firstint.thenComparing(secondint);

        var table = Arrays.stream(piep)
            .collect(
                groupingBy(
                    KirazCevik::getMid, 
                    () -> new TreeMap<>(comparator), 
                    mapping(KirazCevik::getLetter, toCollection(TreeSet::new))
                )
            )
        ;

        List<Token> list = processMap(table); 
        list.forEach(System.out::println);
        print(list);   // this method should turn the entries 2, 3, 4, 5 into [2-5]
    }
    
    static List<Token> processMap(TreeMap<String, TreeSet<Character>> map) {
        List<Token> result = new ArrayList<>();
        map.entrySet().forEach(e -> {
            if (e.getValue().first() == 0) {
                result.add(new Token(e.getKey()));
                e.getValue().pollFirst();
            }
            if (!e.getValue().isEmpty()) result.add(new Token(e));
        });
        return result;
    }
    
    static int getFirstInt(String s) {
        var t = s.split("[-/]");
        return Integer.parseInt(t[0]);
    }
    
    static int getSecondInt(String s) {
        var t = s.split("[-/]");
        return t.length == 2 ? Integer.parseInt(t[1]) : -1;
    }
    
    static String getMid(String s) {
        int t = s.length() - 1;
        if (Character.isLetter(s.charAt(t))) return s.substring(0, t);
        return s;
    }
    
    static char getLetter(String s) {
        char t = s.charAt(s.length() - 1);
        return (Character.isLetter(t)) ? t : 0;
    }
    
    private static void print(List<Token> list) {
        // ToDo yet
        System.out.println("method 'print' not yet implemented");
    }
}

class Token {
    int id1;
    int id2;
    String mid;
    List<Character> chars;
    TokenType type;
    
    Token(Map.Entry<String, TreeSet<Character>> e) {
        id1 = KirazCevik.getFirstInt(e.getKey());
        id2 = KirazCevik.getSecondInt(e.getKey());
        mid = e.getKey();
        chars = new ArrayList<>(e.getValue());
        type = TokenType.OTHER;
    }
    
    Token(String s) {
        id1 = KirazCevik.getFirstInt(s);
        id2 = KirazCevik.getSecondInt(s);
        mid = s;
        type = id2 == -1 ? TokenType.JUST_A_NUMBER : TokenType.JUST_A_STRING;
    }
    
    public String getString() {
        return mid;
    }
    
    @Override
    public String toString() {
        var sb = new StringBuilder();
        sb.append(mid);
        if (type == TokenType.OTHER) {
            if (chars.size() == 1) sb.append(chars.get(0));
            else sb.append("[" + chars.get(0) + "-" + chars.get(chars.size() - 1) + "]");
        }
        return sb.toString();
    }
}

enum TokenType {
    JUST_A_NUMBER, JUST_A_STRING, OTHER
}

[Piet Souris]

Just added the missing method. It's a bit messy, but up to you to give it a thorough test and to make the code a little more neat. If you find any errors, please let me know.

import java.util.ArrayList;
import java.util.Arrays;
import java.util.Comparator;
import java.util.List;
import java.util.Map;
import java.util.TreeMap;
import java.util.TreeSet;
import static java.util.stream.Collectors.groupingBy;
import static java.util.stream.Collectors.mapping;
import static java.util.stream.Collectors.toCollection;

/**
 *
 * @author Piet
 */
public class KirazCevik {
    public static void main(String... args) {
        String[] piep = {"100/100", "100/50", "2A", "2B", "2C", "3", "3A", "4", "5", 
                        "6", "32C", "32D", "50", "51/1", "51/2", "60", "61", "62", 
                        "200-2E", "200-2F", "200-2G", "200-2H", "201C", "201/21P", 
                        "201/21R", "201/21S","300","300A","301-2A", "542/2K", "542/2L","583-1", 
                        "583-585D", "583-585E", "605", "605A", "605B","605C", "800A", "1", "2"
        };
        
        var firstint = Comparator.comparingInt(KirazCevik::getFirstInt);
        var secondint = Comparator.comparingInt(KirazCevik::getSecondInt);
        var comparator = firstint.thenComparing(secondint);

        var table = Arrays.stream(piep)
            .collect(
                groupingBy(
                    KirazCevik::getMid, 
                    () -> new TreeMap<>(comparator), 
                    mapping(KirazCevik::getLetter, toCollection(TreeSet::new))
                )
            )
        ;

        List<Token> list = processMap(table); 
        list.forEach(System.out::println);
        System.out.println("************************************");
        List<String> finalList = processFinal(list);     // this method should turn the entries 2, 3, 4, 5 into [2-5]
        finalList.forEach(System.out::println);;   
    }
    
    static List<Token> processMap(TreeMap<String, TreeSet<Character>> map) {
        List<Token> result = new ArrayList<>();
        map.entrySet().forEach(e -> {
            if (e.getValue().first() == 0) {
                result.add(new Token(e.getKey()));
                e.getValue().pollFirst();
            }
            if (!e.getValue().isEmpty()) result.add(new Token(e));
        });
        return result;
    }
    
    private static List<String> processFinal(List<Token> tokens) {
        List<String> result = new ArrayList<>();
        for (int mainIndex = 0; mainIndex < tokens.size(); mainIndex++) {
            var token = tokens.get(mainIndex);
            if (token.type != TokenType.JUST_A_NUMBER) {
                result.add(token.toString());
                continue;
            }
            int targetID = token.id1 + 1;
            int subIndex;
            for (subIndex = 1; mainIndex + subIndex < tokens.size(); subIndex++) {
                var t = tokens.get(mainIndex + subIndex);
                if (t.type != TokenType.JUST_A_NUMBER || t.id1 != targetID) break;
                targetID++;
            }
            if (subIndex > 1) {
                result.add("[" + token.id1 + "-" + (targetID - 1) + "]");
                mainIndex += subIndex - 1;
            }
            else result.add("" + token.id1);
        }
        return result;
    }
    
    static int getFirstInt(String s) {
        var t = s.split("[-/]");
        return Integer.parseInt(t[0]);
    }
    
    static int getSecondInt(String s) {
        var t = s.split("[-/]");
        return t.length == 2 ? Integer.parseInt(t[1]) : -1;
    }
    
    static String getMid(String s) {
        int t = s.length() - 1;
        if (Character.isLetter(s.charAt(t))) return s.substring(0, t);
        return s;
    }
    
    static char getLetter(String s) {
        char t = s.charAt(s.length() - 1);
        return (Character.isLetter(t)) ? t : 0;
    }
    
    private static void print(List<Token> list) {
        // ToDo yet
        System.out.println("method 'print' not yet implemented");
    }
}

class Token {
    int id1;
    int id2;
    String mid;
    List<Character> chars;
    TokenType type;
    
    Token(Map.Entry<String, TreeSet<Character>> e) {
        id1 = KirazCevik.getFirstInt(e.getKey());
        id2 = KirazCevik.getSecondInt(e.getKey());
        mid = e.getKey();
        chars = new ArrayList<>(e.getValue());
        type = TokenType.OTHER;
    }
    
    Token(String s) {
        id1 = KirazCevik.getFirstInt(s);
        id2 = KirazCevik.getSecondInt(s);
        mid = s;
        type = id2 == -1 ? TokenType.JUST_A_NUMBER : TokenType.JUST_A_STRING;
    }
    
    public String getString() {
        return mid;
    }
    
    @Override
    public String toString() {
        var sb = new StringBuilder();
        sb.append(mid);
        if (type == TokenType.OTHER) {
            if (chars.size() == 1) sb.append(chars.get(0));
            else sb.append("[" + chars.get(0) + "-" + chars.get(chars.size() - 1) + "]");
        }
        return sb.toString();
    }
}

enum TokenType {
    JUST_A_NUMBER, JUST_A_STRING, OTHER
}

[kiraz cevik]

[quoted text removed]

Thank you very much for your help.

[Piet Souris]

You're welcome!

[Knute Snortum]

kiraz cevik,

It is not necessary to quote the entire previous message when the context is clear.  Only quote as much text as needed to provide context.